René's URL Explorer Experiment


Title: fix(inbox): require an authenticated sender before an email acts as a workspace member by waleedlatif1 · Pull Request #10059 · simstudioai/sim · GitHub

Open Graph Title: fix(inbox): require an authenticated sender before an email acts as a workspace member by waleedlatif1 · Pull Request #10059 · simstudioai/sim

X Title: fix(inbox): require an authenticated sender before an email acts as a workspace member by waleedlatif1 · Pull Request #10059 · simstudioai/sim

Description: Summary An inbox email's From header is written by the sender, but the webhook allow-gate and the executor both treated a From matching a workspace member as that member: their write permission and their raw-secret mount. AgentMail only drops mail that fails DMARC under quarantine/reject, and it delivers mail with no unauthenticated label when only an unaligned envelope SPF passes. So a forged From for a member whose domain publishes no DMARC record reached the agent with that member's authority The webhook now reads AgentMail's authentication_results and persists a sender_authenticated verdict on the task. A pass counts on aligned SPF, DMARC, or DKIM whose signing domain shares the From address's registrable domain (DMARC relaxed alignment, via tldts) Member admission at the webhook and member actor resolution in the executor both require that verdict. An unauthenticated message naming a member is treated as external: rejected unless allow-listed, and an allow-listed run stays capped at read with no secret actor From is now parsed per RFC 5322 (nodemailer/lib/addressparser) instead of taking the first <…>. A display name like "" can't borrow the attacker domain's DMARC pass, and a header listing several mailboxes is never attributed to one of them Migration 0459: additive boolean NOT NULL DEFAULT false. The deployed app's inserts keep working, and tasks still queued at deploy run as external (fail closed) Type of Change Bug fix Testing New sender-authentication.integration.ts against real Postgres through the signed webhook and the real executor. It covers no verdict, failed verdicts, a DKIM signature from another domain, a DKIM signature from a public suffix, an address-shaped display name, a multi-mailbox From, an admit case for each mechanism, an authenticated member running with their own authority, and an unauthenticated allow-listed member address running as external read. On the pre-fix code 9 of 10 original cases fail. Against a first-< parser, the display-name and multi-mailbox cases fail thread-scope.integration.ts (owner mail now carries a passing verdict), executor.test.ts, and route.test.ts pass check:migrations, drizzle generate is a no-op, check:schema-mock, check:api-validation:strict, check:boundaries, check:utils, check:file-names, check:comment-hygiene, check:test-patterns, check:source-conventions, check:explicit-any, and biome pass. Full type-check and audits run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary An inbox email's From header is written by the sender, but the webhook allow-gate and the executor both treated a From matching a workspace member as that member: their write permissio...

X Description: Summary An inbox email&#39;s From header is written by the sender, but the webhook allow-gate and the executor both treated a From matching a workspace member as that member: their write permi...

Opengraph URL: https://github.com/simstudioai/sim/pull/10059

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1af1b5fb-8f8c-15b2-941a-96fedd6a6044
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC9C:487EF:F39886:14F89E7:6AFB647D
html-safe-nonceb0a5b2954c047f58174694a246840c4284aaab19df053ccd1c35ddb583b04c53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzlDOjQ4N0VGOkYzOTg4NjoxNEY4OUU3OjZBRkI2NDdEIiwidmlzaXRvcl9pZCI6IjYwOTYzNzk5Nzg3Nzk5NDQwNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfe378500845cf215c491bb218d34f114986150b991e33afab36cab4adddd74b2
hovercard-subject-tagpull_request:5316726323
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10059/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary An inbox email's From header is written by the sender, but the webhook allow-gate and the executor both treated a From matching a workspace member as that member: their write permissio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10059/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10059%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10059%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10059/files
Reloadhttps://github.com/simstudioai/sim/pull/10059/files
Reloadhttps://github.com/simstudioai/sim/pull/10059/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/inbox-sender-authenticationhttps://github.com/simstudioai/sim/tree/fix/inbox-sender-authentication
Conversation 8 https://github.com/simstudioai/sim/pull/10059
Commits 2 https://github.com/simstudioai/sim/pull/10059/commits
Checks 81 https://github.com/simstudioai/sim/pull/10059/checks
Files changed https://github.com/simstudioai/sim/pull/10059/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10059/files
fix(inbox): require an authenticated sender before an email acts as a workspace member https://github.com/simstudioai/sim/pull/10059/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/10059/files
2d9b51b fix(inbox): require an authenticated sender before an email acts as a… waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10059/commits/2d9b51be8dc8152b3ad7879d5a96913c949ed908
d3870d0 fix(inbox): attribute a multi-mailbox From to no one waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10059/commits/d3870d0d684343881e535b4d86b4611aacc0a26c
Clear filters https://github.com/simstudioai/sim/pull/10059/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10059/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10059/files
route.ts https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
sender-authentication.integration.ts https://github.com/simstudioai/sim/pull/10059/files#diff-a0359c1a2cd5f96862ec3c7406c80f4382b04f292b91d6c6b0fd9e915f379e97
thread-scope.integration.ts https://github.com/simstudioai/sim/pull/10059/files#diff-f480094ae4f5f1afdc4223527bf24bbffbcaa8338891dead4307fc135890c9b6
webhooks.ts https://github.com/simstudioai/sim/pull/10059/files#diff-85a769472781e1337ee35f1d71242aee81da3073fb5dced3f1813ef425ddb29d
executor.test.ts https://github.com/simstudioai/sim/pull/10059/files#diff-ca635d219f2ef2635aca720ecb4f22d6fc67c54abac092c8fb213f080e687d31
executor.ts https://github.com/simstudioai/sim/pull/10059/files#diff-c33f60778aa0c14a73019c4f39d873ee087fec05114374d21a5914e5376ac91b
types.ts https://github.com/simstudioai/sim/pull/10059/files#diff-2038e7ebb34fd3ff3bd1c8ca2fe6e55c84cdeb3e0baffa4d8819d89fe8bce393
0459_inbox_task_sender_authenticated.sql https://github.com/simstudioai/sim/pull/10059/files#diff-4a698ff2ca9cc836f0c3faaecc07f5f91a938a9a542e6e62dbe509ac894e4a9d
0459_snapshot.json https://github.com/simstudioai/sim/pull/10059/files#diff-40cee7ecdda963172ac584324526c55c96ef2af06207183fd94b3f027b242eb4
_journal.json https://github.com/simstudioai/sim/pull/10059/files#diff-37150cc65ad16ee6fbc5fa318fc096be7730e16d63eaf863e3df5521b7030649
schema.ts https://github.com/simstudioai/sim/pull/10059/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
schema-tables.generated.ts https://github.com/simstudioai/sim/pull/10059/files#diff-e0edf0f56682cbbb36446389d81ccd7516f377568a0c09cd8e9c1c87b0b1850e
apps/sim/app/api/webhooks/agentmail/route.tshttps://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
View file https://github.com/simstudioai/sim/blob/d3870d0d684343881e535b4d86b4611aacc0a26c/apps/sim/app/api/webhooks/agentmail/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10059/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
https://github.com/simstudioai/sim/pull/10059/files#diff-2271289680dd55d063cf43550f6cd30953011725a053ee486cf77b598181181e
Please reload this pagehttps://github.com/simstudioai/sim/pull/10059/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.