René's URL Explorer Experiment


Title: fix(workspaces): stop workspace admins from moving the billed account by waleedlatif1 · Pull Request #10058 · simstudioai/sim · GitHub

Open Graph Title: fix(workspaces): stop workspace admins from moving the billed account by waleedlatif1 · Pull Request #10058 · simstudioai/sim

X Title: fix(workspaces): stop workspace admins from moving the billed account by waleedlatif1 · Pull Request #10058 · simstudioai/sim

Description: Summary `PATCH /api/workspaces/[id]` accepted `billedAccountUserId` from any workspace admin, checking only that the new payer was also an admin. The caller never needed billing authority (`canUserManageWorkspaceBilling`) and the new payer never agreed, so on a shared non-org workspace a co-admin could move all model spend and storage onto another admin's personal plan No client has sent the field since the settings hook dropped it as dead code, so remove it from the general settings patch (contract, `applyWorkspaceUpdate`, audit projection) instead of gating a dead write path. Gating alone would still let the payer dump charges on a co-admin without consent `applyWorkspaceUpdate` loses its now-unused transaction branch and storage-transfer call; system-driven payer moves (org ownership transfer, org attach/detach, admin move, account deletion) are untouched Type of Change Bug fix Testing `update-workspace.integration.ts` against real Postgres: new cases for a non-payer co-admin and for the payer moving the bill onto an admin who never agreed. Red on the pre-fix source (200, payer row changed), green on the fix (14/14) Neighbor unit tests importing the changed contract (19 passing), `check:api-validation:strict`, biome on changed files; full type-check and audits run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the `test-audit` authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary `PATCH /api/workspaces/[id]` accepted `billedAccountUserId` from any workspace admin, checking only that the new payer was also an admin. The caller never needed billing authority (`canUse...

X Description: Summary `PATCH /api/workspaces/[id]` accepted `billedAccountUserId` from any workspace admin, checking only that the new payer was also an admin. The caller never needed billing authority (`canUse...

Opengraph URL: https://github.com/simstudioai/sim/pull/10058

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6db4f3c6-e450-2e6b-5eec-3a053ca9a4ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDBA:9D91A:5FA372:8744D4:6AFB64B9
html-safe-nonce65ed0b8d3c3b0fc45ec577c69950193325bcefe04e0d38d68b1f0f5b21cf703e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREJBOjlEOTFBOjVGQTM3Mjo4NzQ0RDQ6NkFGQjY0QjkiLCJ2aXNpdG9yX2lkIjoiNTQ5MDg3MzU4MjQyNDM4NDY5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb946a61c81e8f74fbd17e1ee80300bfdb22a5fb31831f4660541c6e6fa521933
hovercard-subject-tagpull_request:5316719612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10058/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary `PATCH /api/workspaces/[id]` accepted `billedAccountUserId` from any workspace admin, checking only that the new payer was also an admin. The caller never needed billing authority (`canUse...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10058/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10058%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10058%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10058/files
Reloadhttps://github.com/simstudioai/sim/pull/10058/files
Reloadhttps://github.com/simstudioai/sim/pull/10058/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/workspace-update-billed-accounthttps://github.com/simstudioai/sim/tree/fix/workspace-update-billed-account
Conversation 2 https://github.com/simstudioai/sim/pull/10058
Commits 1 https://github.com/simstudioai/sim/pull/10058/commits
Checks 81 https://github.com/simstudioai/sim/pull/10058/checks
Files changed https://github.com/simstudioai/sim/pull/10058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10058/files
fix(workspaces): stop workspace admins from moving the billed account https://github.com/simstudioai/sim/pull/10058/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10058/files
bc9ac75 fix(workspaces): stop workspace admins from moving the billed account waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10058/commits/bc9ac75f1e4b5a2f796f5a877d3af62991e21702
Clear filters https://github.com/simstudioai/sim/pull/10058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10058/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10058/files
workspaces.ts https://github.com/simstudioai/sim/pull/10058/files#diff-cc809bb2a9762a5e34aa3dead6e253dc3a338a8015828af9cbc7a24bd40c8e1d
operations.ts https://github.com/simstudioai/sim/pull/10058/files#diff-2707028d862024b5ebd5ee5f619ce6a1bf3c8ecec2167b69d81ec60ab734cf94
update-workspace.integration.ts https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
update-workspace.ts https://github.com/simstudioai/sim/pull/10058/files#diff-16883f28178889a5fa0efb64e1efcf29a2bba41e6d507e385019355e16d5e8cc
update.ts https://github.com/simstudioai/sim/pull/10058/files#diff-9dfb20baf06845c7db44a928e2490fb8fc666c1bf48b5d879d8ddc74e2bef923
apps/sim/lib/api/contracts/workspaces.tshttps://github.com/simstudioai/sim/pull/10058/files#diff-cc809bb2a9762a5e34aa3dead6e253dc3a338a8015828af9cbc7a24bd40c8e1d
View file https://github.com/simstudioai/sim/blob/bc9ac75f1e4b5a2f796f5a877d3af62991e21702/apps/sim/lib/api/contracts/workspaces.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10058/files#diff-cc809bb2a9762a5e34aa3dead6e253dc3a338a8015828af9cbc7a24bd40c8e1d
https://github.com/simstudioai/sim/pull/10058/files#diff-cc809bb2a9762a5e34aa3dead6e253dc3a338a8015828af9cbc7a24bd40c8e1d
apps/sim/lib/workspaces/application/operations.tshttps://github.com/simstudioai/sim/pull/10058/files#diff-2707028d862024b5ebd5ee5f619ce6a1bf3c8ecec2167b69d81ec60ab734cf94
View file https://github.com/simstudioai/sim/blob/bc9ac75f1e4b5a2f796f5a877d3af62991e21702/apps/sim/lib/workspaces/application/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10058/files#diff-2707028d862024b5ebd5ee5f619ce6a1bf3c8ecec2167b69d81ec60ab734cf94
https://github.com/simstudioai/sim/pull/10058/files#diff-2707028d862024b5ebd5ee5f619ce6a1bf3c8ecec2167b69d81ec60ab734cf94
apps/sim/lib/workspaces/application/update-workspace.integration.tshttps://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
View file https://github.com/simstudioai/sim/blob/bc9ac75f1e4b5a2f796f5a877d3af62991e21702/apps/sim/lib/workspaces/application/update-workspace.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
https://github.com/simstudioai/sim/pull/10058/files#diff-114ca6da3b4903b486be3b151bb6c5af0c2197687e52d89f9962b9e2b295c403
apps/sim/lib/workspaces/application/update-workspace.tshttps://github.com/simstudioai/sim/pull/10058/files#diff-16883f28178889a5fa0efb64e1efcf29a2bba41e6d507e385019355e16d5e8cc
View file https://github.com/simstudioai/sim/blob/bc9ac75f1e4b5a2f796f5a877d3af62991e21702/apps/sim/lib/workspaces/application/update-workspace.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10058/files#diff-16883f28178889a5fa0efb64e1efcf29a2bba41e6d507e385019355e16d5e8cc
https://github.com/simstudioai/sim/pull/10058/files#diff-16883f28178889a5fa0efb64e1efcf29a2bba41e6d507e385019355e16d5e8cc
https://github.com/simstudioai/sim/pull/10058/files#diff-16883f28178889a5fa0efb64e1efcf29a2bba41e6d507e385019355e16d5e8cc
apps/sim/lib/workspaces/update.tshttps://github.com/simstudioai/sim/pull/10058/files#diff-9dfb20baf06845c7db44a928e2490fb8fc666c1bf48b5d879d8ddc74e2bef923
View file https://github.com/simstudioai/sim/blob/bc9ac75f1e4b5a2f796f5a877d3af62991e21702/apps/sim/lib/workspaces/update.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10058/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10058/files#diff-9dfb20baf06845c7db44a928e2490fb8fc666c1bf48b5d879d8ddc74e2bef923
https://github.com/simstudioai/sim/pull/10058/files#diff-9dfb20baf06845c7db44a928e2490fb8fc666c1bf48b5d879d8ddc74e2bef923
Please reload this pagehttps://github.com/simstudioai/sim/pull/10058/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.