René's URL Explorer Experiment


Title: fix(webhooks): reject auth that reads an unresolved env-var secret by waleedlatif1 · Pull Request #10055 · simstudioai/sim · GitHub

Open Graph Title: fix(webhooks): reject auth that reads an unresolved env-var secret by waleedlatif1 · Pull Request #10055 · simstudioai/sim

X Title: fix(webhooks): reject auth that reads an unresolved env-var secret by waleedlatif1 · Pull Request #10055 · simstudioai/sim

Description: Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env couldn't be read (e.g. the workflow owner left the workspace), became the literal {{VAR}} text as the expected token/HMAC key. Anyone who knew the URL and the variable name could authenticate a forged delivery Env-load failure now returns 500 (retryable) instead of continuing with an empty env A delivery is rejected (401) when the handler's auth decision read a config field whose reference didn't resolve. Unresolved fields are exposed through getters that record reads, so the check is exact without per-provider declarations. Free-text fields auth never reads (generic responseBody, Twilio TwiML) keep working with literal braces Rejecting on any unresolved reference was ruled out: those free-text fields are never env-resolved, so braces in them are legit content. Blanking the unresolved field was also ruled out, because createHmacVerifier and generic auth skip verification when the secret is empty Env is read through resolveBackgroundWebhookEnv, the same owner/billing-account split execution uses, so a departed owner no longer breaks auth. Costs a few uncached queries per delivery only for webhooks whose config uses {{VAR}}. Decrypted secrets are deliberately not cached Type of Change Bug fix Testing New verifyProviderAuth env-referenced secrets tests in processor.test.ts: all 4 fail on staging code; the free-text test also fails against a reject-on-any-unresolved variant lib/webhooks/ + app/api/webhooks/ vitest suites: 79 files / 721 tests passing biome; check:comment-hygiene, check:utils, check:test-patterns, check:explicit-any, check:boundaries, check:source-conventions; test-audit gate on the new tests Full type-check / audits / test suite left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env coul...

X Description: Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env coul...

Opengraph URL: https://github.com/simstudioai/sim/pull/10055

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b5cc1e8-d55e-b007-3199-aa77452bcb98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1D2:2F3575:BB5FDC:10AB2E2:6AFB5DFE
html-safe-nonce4c211007b3ec78613dcba477601762737115f79fde5c3267b0dec39c86235bc1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUQyOjJGMzU3NTpCQjVGREM6MTBBQjJFMjo2QUZCNURGRSIsInZpc2l0b3JfaWQiOiIzODgzMDcxMjcxMTU5NDIyNDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2bcbeea9710a923dd9fb00cbf31fbf40dc73c853eaebf6e4929891ee7257c951
hovercard-subject-tagpull_request:5316685282
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10055/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env coul...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10055/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10055%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10055%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10055/files
Reloadhttps://github.com/simstudioai/sim/pull/10055/files
Reloadhttps://github.com/simstudioai/sim/pull/10055/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/webhook-auth-unresolved-envhttps://github.com/simstudioai/sim/tree/fix/webhook-auth-unresolved-env
Conversation 2 https://github.com/simstudioai/sim/pull/10055
Commits 1 https://github.com/simstudioai/sim/pull/10055/commits
Checks 81 https://github.com/simstudioai/sim/pull/10055/checks
Files changed 2 https://github.com/simstudioai/sim/pull/10055/files
fix(webhooks): reject auth that reads an unresolved env-var secret https://github.com/simstudioai/sim/pull/10055/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10055/files
9d1313d fix(webhooks): reject auth that reads an unresolved env-var secret waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10055/commits/9d1313dc184eb4b42ef50063abc5f0580b9cbc0a
Clear filters https://github.com/simstudioai/sim/pull/10055/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10055/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10055/files
processor.test.ts https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
processor.ts https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
apps/sim/lib/webhooks/processor.test.tshttps://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
View file https://github.com/simstudioai/sim/blob/9d1313dc184eb4b42ef50063abc5f0580b9cbc0a/apps/sim/lib/webhooks/processor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10055/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
https://github.com/simstudioai/sim/pull/10055/files#diff-ba6e1a44cdb94ccfcc4f6c6c96e2f28ad8e08f49903062d74f913a57f657ab94
apps/sim/lib/webhooks/processor.tshttps://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
View file https://github.com/simstudioai/sim/blob/9d1313dc184eb4b42ef50063abc5f0580b9cbc0a/apps/sim/lib/webhooks/processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10055/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
https://github.com/simstudioai/sim/pull/10055/files#diff-d1f09ac3bd1aabe69708139bcf5137c047ada2dc058c916925187e924c12de4c
Please reload this pagehttps://github.com/simstudioai/sim/pull/10055/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.