Title: fix(webhooks): reject auth that reads an unresolved env-var secret by waleedlatif1 · Pull Request #10055 · simstudioai/sim · GitHub
Open Graph Title: fix(webhooks): reject auth that reads an unresolved env-var secret by waleedlatif1 · Pull Request #10055 · simstudioai/sim
X Title: fix(webhooks): reject auth that reads an unresolved env-var secret by waleedlatif1 · Pull Request #10055 · simstudioai/sim
Description: Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env couldn't be read (e.g. the workflow owner left the workspace), became the literal {{VAR}} text as the expected token/HMAC key. Anyone who knew the URL and the variable name could authenticate a forged delivery Env-load failure now returns 500 (retryable) instead of continuing with an empty env A delivery is rejected (401) when the handler's auth decision read a config field whose reference didn't resolve. Unresolved fields are exposed through getters that record reads, so the check is exact without per-provider declarations. Free-text fields auth never reads (generic responseBody, Twilio TwiML) keep working with literal braces Rejecting on any unresolved reference was ruled out: those free-text fields are never env-resolved, so braces in them are legit content. Blanking the unresolved field was also ruled out, because createHmacVerifier and generic auth skip verification when the secret is empty Env is read through resolveBackgroundWebhookEnv, the same owner/billing-account split execution uses, so a departed owner no longer breaks auth. Costs a few uncached queries per delivery only for webhooks whose config uses {{VAR}}. Decrypted secrets are deliberately not cached Type of Change Bug fix Testing New verifyProviderAuth env-referenced secrets tests in processor.test.ts: all 4 fail on staging code; the free-text test also fails against a reject-on-any-unresolved variant lib/webhooks/ + app/api/webhooks/ vitest suites: 79 files / 721 tests passing biome; check:comment-hygiene, check:utils, check:test-patterns, check:explicit-any, check:boundaries, check:source-conventions; test-audit gate on the new tests Full type-check / audits / test suite left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env coul...
X Description: Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env coul...
Opengraph URL: https://github.com/simstudioai/sim/pull/10055
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3b5cc1e8-d55e-b007-3199-aa77452bcb98 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1D2:2F3575:BB5FDC:10AB2E2:6AFB5DFE |
| html-safe-nonce | 4c211007b3ec78613dcba477601762737115f79fde5c3267b0dec39c86235bc1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUQyOjJGMzU3NTpCQjVGREM6MTBBQjJFMjo2QUZCNURGRSIsInZpc2l0b3JfaWQiOiIzODgzMDcxMjcxMTU5NDIyNDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2bcbeea9710a923dd9fb00cbf31fbf40dc73c853eaebf6e4929891ee7257c951 |
| hovercard-subject-tag | pull_request:5316685282 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10055/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary verifyProviderAuth resolved {{VAR}} references in the provider config with the keep-literal default and swallowed env-load errors, so a secret whose variable was deleted, or whose env coul... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width