René's URL Explorer Experiment


Title: fix(sso): admit callbacks under the provider id the plugin resolved by waleedlatif1 · Pull Request #10054 · simstudioai/sim · GitHub

Open Graph Title: fix(sso): admit callbacks under the provider id the plugin resolved by waleedlatif1 · Pull Request #10054 · simstudioai/sim

X Title: fix(sso): admit callbacks under the provider id the plugin resolved by waleedlatif1 · Pull Request #10054 · simstudioai/sim

Description: Summary The SSO plugin resolves a callback's provider from the raw route segment (better-call does not percent-decode params), but the admission hook decoded it and rejected separators, so a provider id like acme/idp minted a session that skipped admitSsoUser entirely (no domain check, JIT/seat policy, session clamp, or login audit) resolveSsoCallbackProviderId now returns the exact undecoded value the plugin used for its lookup and account linking The after-hook fails closed: an SSO callback that mints a session without a resolvable provider is denied and its session deleted Provider ids are restricted to ^[a-zA-Z0-9_.:-]{1,128}$ (the pattern the login audit already assumed) on the v1 register route, the v2 save contract, and the repository write; v2 get/delete params stay permissive so any legacy row can still be removed Type of Change Bug fix Testing callback-provider.test.ts, register/route.test.ts, new contracts/v2/sso.test.ts: new cases fail on the pre-fix code (encoded ids decoded/nulled, / ids accepted by v1 and v2) and pass after lib/auth, app/api/auth, app/api/v2/organizations, ee/sso suites pass; check:api-validation:strict, biome, type-check clean; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary The SSO plugin resolves a callback's provider from the raw route segment (better-call does not percent-decode params), but the admission hook decoded it and rejected separators, so a p...

X Description: Summary The SSO plugin resolves a callback's provider from the raw route segment (better-call does not percent-decode params), but the admission hook decoded it and rejected separators, so...

Opengraph URL: https://github.com/simstudioai/sim/pull/10054

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:712be682-f2f3-8ca9-6d70-f3e314b680eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCECE:2F4711:656401:8EA8C7:6AFB64C2
html-safe-noncee0c60ff70bbd34f5d9d71c1931a1887f199e7907a3b676920799964a8e9e5f1a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUNFOjJGNDcxMTo2NTY0MDE6OEVBOEM3OjZBRkI2NEMyIiwidmlzaXRvcl9pZCI6Ijg4MjM3Nzk4ODIxMzY0NjI1MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1cc508371edf74179c9376f7e0b2f4978bf9dae5fb976f2353bf2b9a45ccb55d
hovercard-subject-tagpull_request:5316684240
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10054/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The SSO plugin resolves a callback's provider from the raw route segment (better-call does not percent-decode params), but the admission hook decoded it and rejected separators, so a p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10054/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10054%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10054%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10054/files
Reloadhttps://github.com/simstudioai/sim/pull/10054/files
Reloadhttps://github.com/simstudioai/sim/pull/10054/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sso-callback-raw-provider-idhttps://github.com/simstudioai/sim/tree/fix/sso-callback-raw-provider-id
Conversation 20 https://github.com/simstudioai/sim/pull/10054
Commits 3 https://github.com/simstudioai/sim/pull/10054/commits
Checks 84 https://github.com/simstudioai/sim/pull/10054/checks
Files changed https://github.com/simstudioai/sim/pull/10054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10054/files
fix(sso): admit callbacks under the provider id the plugin resolved https://github.com/simstudioai/sim/pull/10054/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/10054/files
ee745f9 fix(sso): admit callbacks under the provider id the plugin resolved waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10054/commits/ee745f9ebef9997aa1bfc180ad8e0be1b6b7c3b3
0331212 fix(sso): reject dot-segment provider ids and regenerate v2 openapi waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10054/commits/03312122316fb083d10fb62d8b973f8208823906
64f2e89 docs(sso): document the shared provider id schema waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10054/commits/64f2e8964561e5476286d353b3ab0b6e46526489
Clear filters https://github.com/simstudioai/sim/pull/10054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10054/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10054/files
openapi-v2-resources.json https://github.com/simstudioai/sim/pull/10054/files#diff-17e168777a3b67e689dd8b24e28aaa217cb884843dccad31b1dbf22d5307e17f
route.test.ts https://github.com/simstudioai/sim/pull/10054/files#diff-602d449104f41ae830209c664a5903824479c317da461304f5980b61630df01e
sso.test.ts https://github.com/simstudioai/sim/pull/10054/files#diff-79b992c4bdbb2026149ba744658b2a6cc90ed669cf5a5e4bffdd4005e5d15b76
sso.ts https://github.com/simstudioai/sim/pull/10054/files#diff-86e8a6f7385faf07b9680dc672416b4fc4e10474bcb522d3047d929d5326f5e3
auth.ts https://github.com/simstudioai/sim/pull/10054/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
lifecycle-audit.ts https://github.com/simstudioai/sim/pull/10054/files#diff-a73047e5e469ec3654e3e1f26d9806812bf235973f2988473d37069716bef92d
callback-provider.test.ts https://github.com/simstudioai/sim/pull/10054/files#diff-a0c977553767376819d3bf729dd294476399c5bd07f405ee8be78ed801cd674f
callback-provider.ts https://github.com/simstudioai/sim/pull/10054/files#diff-2017c07de4016af2f5b878a7c0c8e35f79fb72a784f9852fa719d99b1ef2eb57
provider-repository.ts https://github.com/simstudioai/sim/pull/10054/files#diff-ea777f7fe74b8d5180d81375af0ff3c792759d28d70ce01e90e6ecb89c919c68
registration-input.ts https://github.com/simstudioai/sim/pull/10054/files#diff-6c8c8809c7a1e5707d187c895b1ad628dbabc403beeaab1c81c12b3291acc687
apps/docs/openapi-v2-resources.jsonhttps://github.com/simstudioai/sim/pull/10054/files#diff-17e168777a3b67e689dd8b24e28aaa217cb884843dccad31b1dbf22d5307e17f
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/docs/openapi-v2-resources.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-17e168777a3b67e689dd8b24e28aaa217cb884843dccad31b1dbf22d5307e17f
https://github.com/simstudioai/sim/pull/10054/files#diff-17e168777a3b67e689dd8b24e28aaa217cb884843dccad31b1dbf22d5307e17f
https://github.com/simstudioai/sim/pull/10054/files#diff-17e168777a3b67e689dd8b24e28aaa217cb884843dccad31b1dbf22d5307e17f
https://github.com/simstudioai/sim/pull/10054/files#diff-17e168777a3b67e689dd8b24e28aaa217cb884843dccad31b1dbf22d5307e17f
apps/sim/app/api/auth/sso/register/route.test.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-602d449104f41ae830209c664a5903824479c317da461304f5980b61630df01e
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/app/api/auth/sso/register/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-602d449104f41ae830209c664a5903824479c317da461304f5980b61630df01e
https://github.com/simstudioai/sim/pull/10054/files#diff-602d449104f41ae830209c664a5903824479c317da461304f5980b61630df01e
apps/sim/lib/api/contracts/v2/sso.test.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-79b992c4bdbb2026149ba744658b2a6cc90ed669cf5a5e4bffdd4005e5d15b76
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/api/contracts/v2/sso.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
apps/sim/lib/api/contracts/v2/sso.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-86e8a6f7385faf07b9680dc672416b4fc4e10474bcb522d3047d929d5326f5e3
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/api/contracts/v2/sso.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-86e8a6f7385faf07b9680dc672416b4fc4e10474bcb522d3047d929d5326f5e3
https://github.com/simstudioai/sim/pull/10054/files#diff-86e8a6f7385faf07b9680dc672416b4fc4e10474bcb522d3047d929d5326f5e3
https://github.com/simstudioai/sim/pull/10054/files#diff-86e8a6f7385faf07b9680dc672416b4fc4e10474bcb522d3047d929d5326f5e3
https://github.com/simstudioai/sim/pull/10054/files#diff-86e8a6f7385faf07b9680dc672416b4fc4e10474bcb522d3047d929d5326f5e3
apps/sim/lib/auth/auth.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/auth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10054/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
https://github.com/simstudioai/sim/pull/10054/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/10054/files
https://github.com/simstudioai/sim/pull/10054/files#diff-1196450729bfda994f3823921eacd28e3200408dbb562d8481108db9abe4a0e2
apps/sim/lib/auth/lifecycle-audit.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-a73047e5e469ec3654e3e1f26d9806812bf235973f2988473d37069716bef92d
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/auth/lifecycle-audit.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-a73047e5e469ec3654e3e1f26d9806812bf235973f2988473d37069716bef92d
https://github.com/simstudioai/sim/pull/10054/files#diff-a73047e5e469ec3654e3e1f26d9806812bf235973f2988473d37069716bef92d
https://github.com/simstudioai/sim/pull/10054/files#diff-a73047e5e469ec3654e3e1f26d9806812bf235973f2988473d37069716bef92d
https://github.com/simstudioai/sim/pull/10054/files#diff-a73047e5e469ec3654e3e1f26d9806812bf235973f2988473d37069716bef92d
apps/sim/lib/auth/sso/callback-provider.test.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-a0c977553767376819d3bf729dd294476399c5bd07f405ee8be78ed801cd674f
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/auth/sso/callback-provider.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-a0c977553767376819d3bf729dd294476399c5bd07f405ee8be78ed801cd674f
apps/sim/lib/auth/sso/callback-provider.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-2017c07de4016af2f5b878a7c0c8e35f79fb72a784f9852fa719d99b1ef2eb57
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/auth/sso/callback-provider.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-2017c07de4016af2f5b878a7c0c8e35f79fb72a784f9852fa719d99b1ef2eb57
https://github.com/simstudioai/sim/pull/10054/files#diff-2017c07de4016af2f5b878a7c0c8e35f79fb72a784f9852fa719d99b1ef2eb57
apps/sim/lib/auth/sso/provider-repository.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-ea777f7fe74b8d5180d81375af0ff3c792759d28d70ce01e90e6ecb89c919c68
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/auth/sso/provider-repository.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10054/files#diff-ea777f7fe74b8d5180d81375af0ff3c792759d28d70ce01e90e6ecb89c919c68
https://github.com/simstudioai/sim/pull/10054/files#diff-ea777f7fe74b8d5180d81375af0ff3c792759d28d70ce01e90e6ecb89c919c68
https://github.com/simstudioai/sim/pull/10054/files#diff-ea777f7fe74b8d5180d81375af0ff3c792759d28d70ce01e90e6ecb89c919c68
https://github.com/simstudioai/sim/pull/10054/files#diff-ea777f7fe74b8d5180d81375af0ff3c792759d28d70ce01e90e6ecb89c919c68
apps/sim/lib/auth/sso/registration-input.tshttps://github.com/simstudioai/sim/pull/10054/files#diff-6c8c8809c7a1e5707d187c895b1ad628dbabc403beeaab1c81c12b3291acc687
View file https://github.com/simstudioai/sim/blob/64f2e8964561e5476286d353b3ab0b6e46526489/apps/sim/lib/auth/sso/registration-input.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10054/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/10054/files
https://github.com/simstudioai/sim/pull/10054/files#diff-6c8c8809c7a1e5707d187c895b1ad628dbabc403beeaab1c81c12b3291acc687
https://github.com/simstudioai/sim/pull/10054/files#diff-6c8c8809c7a1e5707d187c895b1ad628dbabc403beeaab1c81c12b3291acc687
https://github.com/simstudioai/sim/pull/10054/files#diff-6c8c8809c7a1e5707d187c895b1ad628dbabc403beeaab1c81c12b3291acc687
https://github.com/simstudioai/sim/pull/10054/files#diff-6c8c8809c7a1e5707d187c895b1ad628dbabc403beeaab1c81c12b3291acc687
Please reload this pagehttps://github.com/simstudioai/sim/pull/10054/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.