René's URL Explorer Experiment


Title: fix(helm): confine the PII service with its NetworkPolicy whenever pii is enabled by waleedlatif1 · Pull Request #10051 · simstudioai/sim · GitHub

Open Graph Title: fix(helm): confine the PII service with its NetworkPolicy whenever pii is enabled by waleedlatif1 · Pull Request #10051 · simstudioai/sim

X Title: fix(helm): confine the PII service with its NetworkPolicy whenever pii is enabled by waleedlatif1 · Pull Request #10051 · simstudioai/sim

Description: Summary The Presidio PII service has no auth of its own, but its -pii NetworkPolicy only rendered when the global networkPolicy.enabled was on (default false). With pii.enabled=true on a default install, any workload in the cluster could reach port 5001 The -pii policy now renders whenever pii.enabled, independent of the global toggle. Same policy as before: ingress from app pods only, DNS-only egress Leaves the global toggle's default alone, because turning on the app/realtime egress policies chart-wide would break installs with external dependencies No sidecar shared secret: the policy closes the in-cluster gap with no new secret to wire through the chart, image, and app client Documents the behavior on pii in values.yaml; chart 1.11.18 → 1.11.19 Type of Change Bug fix Testing New helm unittest case: with pii.enabled=true and the default networkPolicy.enabled=false, the policy renders with app-only ingress. It fails on the old template and passes on the new one. The full suite passes (113 tests) helm lint --strict with ci/default-values.yaml and ci/full-values.yaml helm template matrix over networkPolicy × pii: the pii policy appears exactly when pii.enabled, and the other policies are unchanged. The ci/full-values.yaml render has the same content as before, only reordered check:cron-parity, images:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The Presidio PII service has no auth of its own, but its -pii NetworkPolicy only rendered when the global networkPolicy.enabled was on (default false). With pii.enabled=true on a default i...

X Description: Summary The Presidio PII service has no auth of its own, but its -pii NetworkPolicy only rendered when the global networkPolicy.enabled was on (default false). With pii.enabled=true on a default i...

Opengraph URL: https://github.com/simstudioai/sim/pull/10051

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:312fdaf2-3c0a-6809-10c4-39a718b709b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF1C:37E613:CF8049:11E5494:6AFB5CD0
html-safe-nonce690d9848e76cb14f0dc6e3e6409f08687c44da568df70b1a2c8424c1f916785d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjFDOjM3RTYxMzpDRjgwNDk6MTFFNTQ5NDo2QUZCNUNEMCIsInZpc2l0b3JfaWQiOiIyOTA3MzgzODMzOTk0OTQzNjk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac19877c9c71e20881bf42558c4d103fea159953969bb3ab567011b2d031a51475
hovercard-subject-tagpull_request:5316638817
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10051/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The Presidio PII service has no auth of its own, but its -pii NetworkPolicy only rendered when the global networkPolicy.enabled was on (default false). With pii.enabled=true on a default i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10051/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10051%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10051%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10051/files
Reloadhttps://github.com/simstudioai/sim/pull/10051/files
Reloadhttps://github.com/simstudioai/sim/pull/10051/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/pii-networkpolicy-alwayshttps://github.com/simstudioai/sim/tree/fix/pii-networkpolicy-always
Conversation 2 https://github.com/simstudioai/sim/pull/10051
Commits 1 https://github.com/simstudioai/sim/pull/10051/commits
Checks 80 https://github.com/simstudioai/sim/pull/10051/checks
Files changed 4 https://github.com/simstudioai/sim/pull/10051/files
fix(helm): confine the PII service with its NetworkPolicy whenever pii is enabled https://github.com/simstudioai/sim/pull/10051/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10051/files
2dd0cbc fix(helm): confine the PII service with its NetworkPolicy whenever pi… waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10051/commits/2dd0cbcc0baaf3570c783dc18256d98cdfd9f185
Clear filters https://github.com/simstudioai/sim/pull/10051/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10051/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10051/files
Chart.yaml https://github.com/simstudioai/sim/pull/10051/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
networkpolicy.yaml https://github.com/simstudioai/sim/pull/10051/files#diff-3948a56b21cebf03407bf1778c7deb7d7bb38f4e97d1ef9ad222ea301bf97d1e
pii_test.yaml https://github.com/simstudioai/sim/pull/10051/files#diff-cfc33b707268cfa11d88d46284224b5a916982a2804a4c1c2198d0d967cb496b
values.yaml https://github.com/simstudioai/sim/pull/10051/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
helm/sim/Chart.yamlhttps://github.com/simstudioai/sim/pull/10051/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
View file https://github.com/simstudioai/sim/blob/2dd0cbcc0baaf3570c783dc18256d98cdfd9f185/helm/sim/Chart.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10051/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10051/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
https://github.com/simstudioai/sim/pull/10051/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
helm/sim/templates/networkpolicy.yamlhttps://github.com/simstudioai/sim/pull/10051/files#diff-3948a56b21cebf03407bf1778c7deb7d7bb38f4e97d1ef9ad222ea301bf97d1e
View file https://github.com/simstudioai/sim/blob/2dd0cbcc0baaf3570c783dc18256d98cdfd9f185/helm/sim/templates/networkpolicy.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10051/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10051/files#diff-3948a56b21cebf03407bf1778c7deb7d7bb38f4e97d1ef9ad222ea301bf97d1e
https://github.com/simstudioai/sim/pull/10051/files#diff-3948a56b21cebf03407bf1778c7deb7d7bb38f4e97d1ef9ad222ea301bf97d1e
https://github.com/simstudioai/sim/pull/10051/files#diff-3948a56b21cebf03407bf1778c7deb7d7bb38f4e97d1ef9ad222ea301bf97d1e
helm/sim/tests/pii_test.yamlhttps://github.com/simstudioai/sim/pull/10051/files#diff-cfc33b707268cfa11d88d46284224b5a916982a2804a4c1c2198d0d967cb496b
View file https://github.com/simstudioai/sim/blob/2dd0cbcc0baaf3570c783dc18256d98cdfd9f185/helm/sim/tests/pii_test.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10051/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10051/files#diff-cfc33b707268cfa11d88d46284224b5a916982a2804a4c1c2198d0d967cb496b
https://github.com/simstudioai/sim/pull/10051/files#diff-cfc33b707268cfa11d88d46284224b5a916982a2804a4c1c2198d0d967cb496b
helm/sim/values.yamlhttps://github.com/simstudioai/sim/pull/10051/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
View file https://github.com/simstudioai/sim/blob/2dd0cbcc0baaf3570c783dc18256d98cdfd9f185/helm/sim/values.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10051/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10051/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
https://github.com/simstudioai/sim/pull/10051/files#diff-5586790157aac5be1a3be674910d22e602e8c840abbf289d0ad31ffb5dac5cb1
Please reload this pagehttps://github.com/simstudioai/sim/pull/10051/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.