René's URL Explorer Experiment


Title: fix(workspaces): hand off a departing member's files without binding every file id by waleedlatif1 · Pull Request #10038 · simstudioai/sim · GitHub

Open Graph Title: fix(workspaces): hand off a departing member's files without binding every file id by waleedlatif1 · Pull Request #10038 · simstudioai/sim

X Title: fix(workspaces): hand off a departing member's files without binding every file id by waleedlatif1 · Pull Request #10038 · simstudioai/sim

Description: Summary Removing a workspace member who owned more files than Postgres's 65,535 bind parameters failed with a 500 and rolled back: the file creator handoff selected every matching file id and then ran update ... where id in () handoffFileCreatorsInTx is now keyed by the caller's scope predicate throughout: rows are locked FOR UPDATE in id order through a subquery (nothing loaded into memory), version heads load through a subquery, and the final update matches the same predicate Covers all three callers: workspace member removal, Project departure, and organization departure Versioned files (workspace/project) still have their implicit history frozen before the creator changes. The update only moves a versioned file whose head is current, so a file committed after the history pass keeps its creator rather than losing its original-upload attribution Extracted the correlated-column qualification from currentWorkspaceFileVersionNumberSql and added workspaceFileVersionHeadCurrentSql (the SQL form of isVersionHeadCurrent) Audited the remaining inArray calls in the removal and handoff paths (workspace, project, and org handoff, workflow reassignment, org membership removal). They bind workspace, project, member, or invitation ids, which don't grow with the number of rows a member owns Type of Change Bug fix Testing New real-Postgres case in shared-resource-handoff.integration.ts: it seeds 66,000 knowledge-base files with generate_series, removes the member through revokeWorkspaceAccessTx, and asserts every file moved to the successor. It fails on the pre-fix code with MAX_PARAMETERS_EXCEEDED on the id-list update and passes with the fix (~9s) bun run test:integration with shared-resource-handoff, file-versions, creator-lifetime, projects foundation, membership-removal-lock-order, managed-membership, and owners: 189 passed Unit tests for file-manager, file-manager-page, file-query, and file-versions: 23 passed biome on the changed files; full type-check and audits are left to CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Removing a workspace member who owned more files than Postgres's 65,535 bind parameters failed with a 500 and rolled back: the file creator handoff selected every matching file id and ...

X Description: Summary Removing a workspace member who owned more files than Postgres's 65,535 bind parameters failed with a 500 and rolled back: the file creator handoff selected every matching file id ...

Opengraph URL: https://github.com/simstudioai/sim/pull/10038

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2448e1fc-2995-267a-a705-55cc4ead51ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD084:AE1F3:51820E:724C1D:6AFB5E7A
html-safe-nonceb89c8f064aed21536ab26d05548cca2c047bfee3c484edbb71df5bfd6cde26aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDg0OkFFMUYzOjUxODIwRTo3MjRDMUQ6NkFGQjVFN0EiLCJ2aXNpdG9yX2lkIjoiMzE5MTQ5NTU5NzQ3NjY1NTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac340ea4e86dc01aecd63beb6a232929d0100c2eb31059a928b3c712ede8a3d969
hovercard-subject-tagpull_request:5307177246
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10038/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Removing a workspace member who owned more files than Postgres's 65,535 bind parameters failed with a 500 and rolled back: the file creator handoff selected every matching file id and ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10038/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10038%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10038%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10038/files
Reloadhttps://github.com/simstudioai/sim/pull/10038/files
Reloadhttps://github.com/simstudioai/sim/pull/10038/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/handoff-bulk-set-basedhttps://github.com/simstudioai/sim/tree/fix/handoff-bulk-set-based
Conversation 2 https://github.com/simstudioai/sim/pull/10038
Commits 1 https://github.com/simstudioai/sim/pull/10038/commits
Checks 80 https://github.com/simstudioai/sim/pull/10038/checks
Files changed https://github.com/simstudioai/sim/pull/10038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10038/files
fix(workspaces): hand off a departing member's files without binding every file id https://github.com/simstudioai/sim/pull/10038/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10038/files
0c8f5d4 fix(workspaces): hand off a departing member's files without binding … waleedlatif1 Nov 14, 2026 https://github.com/simstudioai/sim/pull/10038/commits/0c8f5d40d004d501692bb1e60c0ef2b3691fcf53
Clear filters https://github.com/simstudioai/sim/pull/10038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10038/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10038/files
creator-handoff.ts https://github.com/simstudioai/sim/pull/10038/files#diff-e800d726a90d19ea8a5a9b15d239cbb40733c7cd2952165b40b789c2e189c416
file-version-store.ts https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
shared-resource-handoff.integration.ts https://github.com/simstudioai/sim/pull/10038/files#diff-8f87f61877abc391f81dcfd3ad6d69c5bce3e09d48600edbe8373531ab196ea5
apps/sim/lib/uploads/contexts/workspace/creator-handoff.tshttps://github.com/simstudioai/sim/pull/10038/files#diff-e800d726a90d19ea8a5a9b15d239cbb40733c7cd2952165b40b789c2e189c416
View file https://github.com/simstudioai/sim/blob/0c8f5d40d004d501692bb1e60c0ef2b3691fcf53/apps/sim/lib/uploads/contexts/workspace/creator-handoff.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10038/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10038/files#diff-e800d726a90d19ea8a5a9b15d239cbb40733c7cd2952165b40b789c2e189c416
apps/sim/lib/uploads/contexts/workspace/file-version-store.tshttps://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
View file https://github.com/simstudioai/sim/blob/0c8f5d40d004d501692bb1e60c0ef2b3691fcf53/apps/sim/lib/uploads/contexts/workspace/file-version-store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10038/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
https://github.com/simstudioai/sim/pull/10038/files#diff-2161f31e7b2e5b8bd65b9908d436524e16ab74f342846a79c3a2214ed17d018a
apps/sim/lib/workspaces/access/shared-resource-handoff.integration.tshttps://github.com/simstudioai/sim/pull/10038/files#diff-8f87f61877abc391f81dcfd3ad6d69c5bce3e09d48600edbe8373531ab196ea5
View file https://github.com/simstudioai/sim/blob/0c8f5d40d004d501692bb1e60c0ef2b3691fcf53/apps/sim/lib/workspaces/access/shared-resource-handoff.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10038/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10038/files#diff-8f87f61877abc391f81dcfd3ad6d69c5bce3e09d48600edbe8373531ab196ea5
https://github.com/simstudioai/sim/pull/10038/files#diff-8f87f61877abc391f81dcfd3ad6d69c5bce3e09d48600edbe8373531ab196ea5
Please reload this pagehttps://github.com/simstudioai/sim/pull/10038/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.