René's URL Explorer Experiment


Title: fix(credentials): cap the Databricks identity check with a deadline and report no hold for an unheld reconnect subject by waleedlatif1 · Pull Request #10021 · simstudioai/sim · GitHub

Open Graph Title: fix(credentials): cap the Databricks identity check with a deadline and report no hold for an unheld reconnect subject by waleedlatif1 · Pull Request #10021 · simstudioai/sim

X Title: fix(credentials): cap the Databricks identity check with a deadline and report no hold for an unheld reconnect subject by waleedlatif1 · Pull Request #10021 · simstudioai/sim

Description: Summary Follow-ups from release review on the held keyless subjects change (#10011). Databricks identity check gets a hard deadline. The SCIM /Me verification moved to the egress-guarded fetch, whose timeout only resets on inactivity. It now also passes signal: AbortSignal.timeout(15s), so a slow or dribbling workspace can't hold a save open, and DNS validation is capped too. This restores the absolute deadline the old fetch call had, matching the other Databricks calls in the file. An unheld reconnect subject reports no hold. A reconnect that keeps its subject mints a subject Sim never holds. The internal response used to report the proof's 24-hour expiry as subjectHeldUntil. Now subjectIssuedAt, subjectHeldUntil and subjectReused are absent on that path: optional on the internal contract and the use-case result only. The v2 contract still requires them, and its adapter asserts them, since it only issues or renews held subjects. The connect dialog's hint narrows on the optional field. Nothing displayed the unheld values before, so there's no visible change. Docs baseline: the two keyless-subject usage fences record their new size (bytes 54). The use case's TSDoc moves back onto prepareWorkloadIdentity. Type of Change Bug fix Testing New unit test: a reconnect subject Sim doesn't hold reports no hold. It fails on the previous code, which invented the fields. Not covered by a test: the deadline. Asserting the call argument would only restate the code, and fake timers don't drive AbortSignal.timeout. Unit runs: 81 tests pass across prepare-workload-identity, the v2 subjects route and the Databricks server tests. Integration: workload-identity-pending-subject.integration.ts (10) and workload-identity-subject-reuse.integration.ts (9) pass against Postgres provisioned through migrations. Lint and audits: bun run lint, check:audits (all), check:test-types and the docs compatibility check pass. The generated artifacts are unchanged. Type-check and the full suite run in CI. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups from release review on the held keyless subjects change (#10011). Databricks identity check gets a hard deadline. The SCIM /Me verification moved to the egress-guarded fetch, wh...

X Description: Summary Follow-ups from release review on the held keyless subjects change (#10011). Databricks identity check gets a hard deadline. The SCIM /Me verification moved to the egress-guarded fetch, wh...

Opengraph URL: https://github.com/simstudioai/sim/pull/10021

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:87d4653d-28ff-bcb6-0d3e-0a380789cbaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5AA:24A2CB:92680:D803E:6AFB12AF
html-safe-nonce39bbb60a89d063131289cc35642de87513a7d0d09cecc21f7d3a46330c813149
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUFBOjI0QTJDQjo5MjY4MDpEODAzRTo2QUZCMTJBRiIsInZpc2l0b3JfaWQiOiIzNjAzMzg5MjE1NjYxNTYwNDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9d204f60e65f92109d62b6f281c0ce23205b775d708016ecd13b4447b3132aca
hovercard-subject-tagpull_request:5304011948
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10021/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups from release review on the held keyless subjects change (#10011). Databricks identity check gets a hard deadline. The SCIM /Me verification moved to the egress-guarded fetch, wh...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4275ec98d19a530a209480d02854be81de24ad5a05b648333242fc516bfb573c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseba13208acc32a4e7a4a3b54cb2f0dea6001ba5f8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10021/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10021%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10021%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10021/files
Reloadhttps://github.com/simstudioai/sim/pull/10021/files
Reloadhttps://github.com/simstudioai/sim/pull/10021/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/keyless-release-reviewhttps://github.com/simstudioai/sim/tree/fix/keyless-release-review
Conversation 2 https://github.com/simstudioai/sim/pull/10021
Commits 1 https://github.com/simstudioai/sim/pull/10021/commits
Checks 83 https://github.com/simstudioai/sim/pull/10021/checks
Files changed https://github.com/simstudioai/sim/pull/10021/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10021/files
fix(credentials): cap the Databricks identity check with a deadline and report no hold for an unheld reconnect subject https://github.com/simstudioai/sim/pull/10021/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/10021/files
d5694db fix(credentials): cap the Databricks identity check with a deadline a… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10021/commits/d5694db8597c47fc9b6c03dadc59be364ad3df38
Clear filters https://github.com/simstudioai/sim/pull/10021/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10021/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10021/files
content-baseline.json https://github.com/simstudioai/sim/pull/10021/files#diff-8a79568adeca4b6c3a8ae004368a55c4ea49373eb4c4b03523616634ee135dc6
route.ts https://github.com/simstudioai/sim/pull/10021/files#diff-0a38bbaeb6a3737d28bf0e5b9b4ae94295b0c8fe38514524412cc8c0188440cd
keyless-connection.tsx https://github.com/simstudioai/sim/pull/10021/files#diff-a0125a77eb522d51614454e051638aa1cbe43250842b44f35f5e89d221b38ca3
credentials.ts https://github.com/simstudioai/sim/pull/10021/files#diff-e20031e06ae36740789df42928e1b5c9ef18f4c8d600c332cedf178914269e52
workload-identity-pending-subject.integration.ts https://github.com/simstudioai/sim/pull/10021/files#diff-645e3006b5fdb7183cb351cb34a3fb6032b874465fc7268b4790ef91d99bc50b
prepare-workload-identity.test.ts https://github.com/simstudioai/sim/pull/10021/files#diff-f041faea0f4c8fcf38a003336689e7d05ffdcb44887b510c10baad65b227a39a
prepare-workload-identity.ts https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
databricks-service-account.server.ts https://github.com/simstudioai/sim/pull/10021/files#diff-8909dbe9b2c1ddbb8efe6a6faccb9ef95aaa351e027f697cf7a6a3f57f02249c
apps/docs/scripts/fixtures/content-baseline.jsonhttps://github.com/simstudioai/sim/pull/10021/files#diff-8a79568adeca4b6c3a8ae004368a55c4ea49373eb4c4b03523616634ee135dc6
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/docs/scripts/fixtures/content-baseline.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-8a79568adeca4b6c3a8ae004368a55c4ea49373eb4c4b03523616634ee135dc6
https://github.com/simstudioai/sim/pull/10021/files#diff-8a79568adeca4b6c3a8ae004368a55c4ea49373eb4c4b03523616634ee135dc6
https://github.com/simstudioai/sim/pull/10021/files#diff-8a79568adeca4b6c3a8ae004368a55c4ea49373eb4c4b03523616634ee135dc6
https://github.com/simstudioai/sim/pull/10021/files#diff-8a79568adeca4b6c3a8ae004368a55c4ea49373eb4c4b03523616634ee135dc6
apps/sim/app/api/v2/credentials/workload-identity/subjects/route.tshttps://github.com/simstudioai/sim/pull/10021/files#diff-0a38bbaeb6a3737d28bf0e5b9b4ae94295b0c8fe38514524412cc8c0188440cd
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/app/api/v2/credentials/workload-identity/subjects/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-0a38bbaeb6a3737d28bf0e5b9b4ae94295b0c8fe38514524412cc8c0188440cd
https://github.com/simstudioai/sim/pull/10021/files#diff-0a38bbaeb6a3737d28bf0e5b9b4ae94295b0c8fe38514524412cc8c0188440cd
https://github.com/simstudioai/sim/pull/10021/files#diff-0a38bbaeb6a3737d28bf0e5b9b4ae94295b0c8fe38514524412cc8c0188440cd
...workspaceId]/integrations/components/connect-service-account-modal/keyless-connection.tsxhttps://github.com/simstudioai/sim/pull/10021/files#diff-a0125a77eb522d51614454e051638aa1cbe43250842b44f35f5e89d221b38ca3
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/app/workspace/%5BworkspaceId%5D/integrations/components/connect-service-account-modal/keyless-connection.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-a0125a77eb522d51614454e051638aa1cbe43250842b44f35f5e89d221b38ca3
https://github.com/simstudioai/sim/pull/10021/files#diff-a0125a77eb522d51614454e051638aa1cbe43250842b44f35f5e89d221b38ca3
apps/sim/lib/api/contracts/credentials.tshttps://github.com/simstudioai/sim/pull/10021/files#diff-e20031e06ae36740789df42928e1b5c9ef18f4c8d600c332cedf178914269e52
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/lib/api/contracts/credentials.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-e20031e06ae36740789df42928e1b5c9ef18f4c8d600c332cedf178914269e52
https://github.com/simstudioai/sim/pull/10021/files#diff-e20031e06ae36740789df42928e1b5c9ef18f4c8d600c332cedf178914269e52
apps/sim/lib/credentials/__integration__/workload-identity-pending-subject.integration.tshttps://github.com/simstudioai/sim/pull/10021/files#diff-645e3006b5fdb7183cb351cb34a3fb6032b874465fc7268b4790ef91d99bc50b
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/lib/credentials/__integration__/workload-identity-pending-subject.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-645e3006b5fdb7183cb351cb34a3fb6032b874465fc7268b4790ef91d99bc50b
https://github.com/simstudioai/sim/pull/10021/files#diff-645e3006b5fdb7183cb351cb34a3fb6032b874465fc7268b4790ef91d99bc50b
apps/sim/lib/credentials/application/prepare-workload-identity.test.tshttps://github.com/simstudioai/sim/pull/10021/files#diff-f041faea0f4c8fcf38a003336689e7d05ffdcb44887b510c10baad65b227a39a
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/lib/credentials/application/prepare-workload-identity.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-f041faea0f4c8fcf38a003336689e7d05ffdcb44887b510c10baad65b227a39a
https://github.com/simstudioai/sim/pull/10021/files#diff-f041faea0f4c8fcf38a003336689e7d05ffdcb44887b510c10baad65b227a39a
apps/sim/lib/credentials/application/prepare-workload-identity.tshttps://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/lib/credentials/application/prepare-workload-identity.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
https://github.com/simstudioai/sim/pull/10021/files#diff-8c66235e92f17563a5c9684c570fa6d9c248cc91b187c29fe4755143f6310a7e
apps/sim/lib/credentials/databricks-service-account.server.tshttps://github.com/simstudioai/sim/pull/10021/files#diff-8909dbe9b2c1ddbb8efe6a6faccb9ef95aaa351e027f697cf7a6a3f57f02249c
View file https://github.com/simstudioai/sim/blob/d5694db8597c47fc9b6c03dadc59be364ad3df38/apps/sim/lib/credentials/databricks-service-account.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10021/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10021/files#diff-8909dbe9b2c1ddbb8efe6a6faccb9ef95aaa351e027f697cf7a6a3f57f02249c
https://github.com/simstudioai/sim/pull/10021/files#diff-8909dbe9b2c1ddbb8efe6a6faccb9ef95aaa351e027f697cf7a6a3f57f02249c
Please reload this pagehttps://github.com/simstudioai/sim/pull/10021/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.