René's URL Explorer Experiment


Title: fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim

X Title: fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim

Description: Summary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built from a plain backdrop + panel, no role="dialog"/aria-modal). A full-screen fixed app shell that also holds the field still types Refuses when every sampled point hits nothing, instead of treating empty hits as a non-modal cover The field's ancestor chain is computed once and sampled hits are deduped, so the check costs one walk per distinct cover The never-settling settle test now asserts the 2s cap (from the first probe) instead of only that a snapshot happened Type of Change Bug fix Testing New tests: refuses behind an unmarked full-screen layer, refuses when no point lands, still types under a fixed bar, still types inside a full-screen app shell. The two refusal tests fail with the fix reverted apps/desktop/src/main/browser-agent/ vitest: 557 passed lint, type-check, generators, test:scripts clean Paired browser-agent benchmark (REAL v2, WebGames, capbench) against staging, results in a comment below Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built fr...

X Description: Summary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built fr...

Opengraph URL: https://github.com/simstudioai/sim/pull/10013

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:950c9e3d-d127-683b-6cd6-9b784c158b5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7DC:2DBF5F:93A24:D2E22:6AFB1C04
html-safe-noncede628aee207d9aa08436596522b59bfa5d9450f762d1d734548342188ac7df77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0RDOjJEQkY1Rjo5M0EyNDpEMkUyMjo2QUZCMUMwNCIsInZpc2l0b3JfaWQiOiI2OTgyNzIwNzg3NTM4NzEzNjA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac753bf1e8c803947a78e6d6d25a923ab2d422c1300aa1a3cbd7d5c0a3b168f53f
hovercard-subject-tagpull_request:5303052080
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10013/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built fr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10013/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10013%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10013%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10013/files
Reloadhttps://github.com/simstudioai/sim/pull/10013/files
Reloadhttps://github.com/simstudioai/sim/pull/10013/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-browser-covered-field-typinghttps://github.com/simstudioai/sim/tree/fix/desktop-browser-covered-field-typing
Conversation 29 https://github.com/simstudioai/sim/pull/10013
Commits 9 https://github.com/simstudioai/sim/pull/10013/commits
Checks 50 https://github.com/simstudioai/sim/pull/10013/checks
Files changed https://github.com/simstudioai/sim/pull/10013/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10013/files
fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands https://github.com/simstudioai/sim/pull/10013/files#top
Show all changes 9 commits https://github.com/simstudioai/sim/pull/10013/files
675a558 fix(desktop-browser): refuse typing behind an unmarked full-screen mo… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/675a558593343eb626e14b93181a6117c6e12a97
54e6697 refactor(desktop-browser): compute the field's ancestors once, dedupe… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/54e669739451eb459931c62a09a7fdbd4a713220
f716d61 test(desktop-browser): pass only the element to visible() from map waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/f716d615b8ef12a2bbe4d938164c90f2035b87fd
27f916a test(desktop-browser): drop a typing assertion that cannot fail and b… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/27f916a6a117a7295e9cf5028cd990d0234210d9
6a28b98 fix(desktop-browser): count a full-screen fixed layer as a modal only… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/6a28b9810bd1f7fd128657b819c8e3445f72d16b
285e4f0 fix(desktop-browser): detect an unmarked modal by probing the viewpor… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/285e4f0279441926620731966263d3e0de9f3360
b038c1b fix(desktop-browser): treat an element painted above the field and un… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/b038c1b64154358dd82d31598c032bb15841c201
e26a85a test(desktop-browser): cover a field painted below its own full-scree… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/e26a85a0935831f00e8f0fbf56cc36a6449fd35b
2c82449 test(desktop-browser): type the corner stacks as Element arrays waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10013/commits/2c8244969ce06cecf9f4dfe13674e02357fcfac3
Clear filters https://github.com/simstudioai/sim/pull/10013/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10013/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10013/files
driver.test.ts https://github.com/simstudioai/sim/pull/10013/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
page-functions.test.ts https://github.com/simstudioai/sim/pull/10013/files#diff-60e6378e2242fc028ded8738e8dc487275f038bb52677bca97a4ae86983f95e5
page-functions.ts https://github.com/simstudioai/sim/pull/10013/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
apps/desktop/src/main/browser-agent/driver.test.tshttps://github.com/simstudioai/sim/pull/10013/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
View file https://github.com/simstudioai/sim/blob/2c8244969ce06cecf9f4dfe13674e02357fcfac3/apps/desktop/src/main/browser-agent/driver.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10013/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10013/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/10013/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/10013/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
apps/desktop/src/main/browser-agent/page-functions.test.tshttps://github.com/simstudioai/sim/pull/10013/files#diff-60e6378e2242fc028ded8738e8dc487275f038bb52677bca97a4ae86983f95e5
View file https://github.com/simstudioai/sim/blob/2c8244969ce06cecf9f4dfe13674e02357fcfac3/apps/desktop/src/main/browser-agent/page-functions.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10013/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10013/files#diff-60e6378e2242fc028ded8738e8dc487275f038bb52677bca97a4ae86983f95e5
https://github.com/simstudioai/sim/pull/10013/files#diff-60e6378e2242fc028ded8738e8dc487275f038bb52677bca97a4ae86983f95e5
apps/desktop/src/main/browser-agent/page-functions.tshttps://github.com/simstudioai/sim/pull/10013/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
View file https://github.com/simstudioai/sim/blob/2c8244969ce06cecf9f4dfe13674e02357fcfac3/apps/desktop/src/main/browser-agent/page-functions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10013/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10013/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
https://github.com/simstudioai/sim/pull/10013/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
https://github.com/simstudioai/sim/pull/10013/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
Please reload this pagehttps://github.com/simstudioai/sim/pull/10013/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.