René's URL Explorer Experiment


Title: fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim

X Title: fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point lands by waleedlatif1 · Pull Request #10013 · simstudioai/sim

Open Graph Description: Summary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built fr...

X Description: Summary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built fr...

Opengraph URL: https://github.com/simstudioai/sim/pull/10013

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:89e1b63e-1b6e-1064-f0a5-f9d3a835ee21
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD4C:20A655:E5A1C:153708:6AFB1A54
html-safe-noncef1cf84a3e7ce1dc2cda04b3764d893ae7b0f89adbe726696da1b8cdf6c9bf302
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDRDOjIwQTY1NTpFNUExQzoxNTM3MDg6NkFGQjFBNTQiLCJ2aXNpdG9yX2lkIjoiNTE4NzI3MzM2MDg2MTIzOTg5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5c3538c17d2d70898ad2fb6f56e862cb4f4d7b788079ea2fc46e68d806e4f6be
hovercard-subject-tagpull_request:5303052080
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10013/commits
twitter:imagehttps://opengraph.githubassets.com/3dfbdc962c412c3e28504f0d713df280cc84246b4781419ffb40f5e7cc93c849/simstudioai/sim/pull/10013
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3dfbdc962c412c3e28504f0d713df280cc84246b4781419ffb40f5e7cc93c849/simstudioai/sim/pull/10013
og:image:altSummary Typing into a top-page field that something covers still goes through keyboard focus, but now refuses when the cover sits in an unmarked fixed layer spanning the viewport (a modal built fr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10013/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10013%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10013%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10013/commits
Reloadhttps://github.com/simstudioai/sim/pull/10013/commits
Reloadhttps://github.com/simstudioai/sim/pull/10013/commits
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-browser-covered-field-typinghttps://github.com/simstudioai/sim/tree/fix/desktop-browser-covered-field-typing
Conversationhttps://github.com/simstudioai/sim/pull/10013
Commits9 (9)https://github.com/simstudioai/sim/pull/10013/commits
Checkshttps://github.com/simstudioai/sim/pull/10013/checks
Files changedhttps://github.com/simstudioai/sim/pull/10013/files
fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point landshttps://github.com/simstudioai/sim/pull/10013/commits#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-browser-covered-field-typinghttps://github.com/simstudioai/sim/tree/fix/desktop-browser-covered-field-typing
fix(desktop-browser): refuse typing behind an unmarked full-screen modal or when no sampled point landshttps://github.com/simstudioai/sim/pull/10013/commits/675a558593343eb626e14b93181a6117c6e12a97
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
675a558https://github.com/simstudioai/sim/pull/10013/commits/675a558593343eb626e14b93181a6117c6e12a97
https://github.com/simstudioai/sim/tree/675a558593343eb626e14b93181a6117c6e12a97
refactor(desktop-browser): compute the field's ancestors once, dedupe sampled hits, and time the settle cap from its first probehttps://github.com/simstudioai/sim/pull/10013/commits/54e669739451eb459931c62a09a7fdbd4a713220
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
54e6697https://github.com/simstudioai/sim/pull/10013/commits/54e669739451eb459931c62a09a7fdbd4a713220
https://github.com/simstudioai/sim/tree/54e669739451eb459931c62a09a7fdbd4a713220
test(desktop-browser): pass only the element to visible() from maphttps://github.com/simstudioai/sim/pull/10013/commits/f716d615b8ef12a2bbe4d938164c90f2035b87fd
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
f716d61https://github.com/simstudioai/sim/pull/10013/commits/f716d615b8ef12a2bbe4d938164c90f2035b87fd
https://github.com/simstudioai/sim/tree/f716d615b8ef12a2bbe4d938164c90f2035b87fd
test(desktop-browser): drop a typing assertion that cannot fail and bound the settle cap from belowhttps://github.com/simstudioai/sim/pull/10013/commits/27f916a6a117a7295e9cf5028cd990d0234210d9
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
27f916ahttps://github.com/simstudioai/sim/pull/10013/commits/27f916a6a117a7295e9cf5028cd990d0234210d9
https://github.com/simstudioai/sim/tree/27f916a6a117a7295e9cf5028cd990d0234210d9
fix(desktop-browser): count a full-screen fixed layer as a modal only when it catches the pointerhttps://github.com/simstudioai/sim/pull/10013/commits/6a28b9810bd1f7fd128657b819c8e3445f72d16b
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
6a28b98https://github.com/simstudioai/sim/pull/10013/commits/6a28b9810bd1f7fd128657b819c8e3445f72d16b
https://github.com/simstudioai/sim/tree/6a28b9810bd1f7fd128657b819c8e3445f72d16b
fix(desktop-browser): detect an unmarked modal by probing the viewport for the layer that covers the fieldhttps://github.com/simstudioai/sim/pull/10013/commits/285e4f0279441926620731966263d3e0de9f3360
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
285e4f0https://github.com/simstudioai/sim/pull/10013/commits/285e4f0279441926620731966263d3e0de9f3360
https://github.com/simstudioai/sim/tree/285e4f0279441926620731966263d3e0de9f3360
fix(desktop-browser): treat an element painted above the field and under every viewport corner as a modal backdrophttps://github.com/simstudioai/sim/pull/10013/commits/b038c1b64154358dd82d31598c032bb15841c201
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b038c1bhttps://github.com/simstudioai/sim/pull/10013/commits/b038c1b64154358dd82d31598c032bb15841c201
https://github.com/simstudioai/sim/tree/b038c1b64154358dd82d31598c032bb15841c201
test(desktop-browser): cover a field painted below its own full-screen containerhttps://github.com/simstudioai/sim/pull/10013/commits/e26a85a0935831f00e8f0fbf56cc36a6449fd35b
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
e26a85ahttps://github.com/simstudioai/sim/pull/10013/commits/e26a85a0935831f00e8f0fbf56cc36a6449fd35b
https://github.com/simstudioai/sim/tree/e26a85a0935831f00e8f0fbf56cc36a6449fd35b
test(desktop-browser): type the corner stacks as Element arrayshttps://github.com/simstudioai/sim/pull/10013/commits/2c8244969ce06cecf9f4dfe13674e02357fcfac3
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
2c82449https://github.com/simstudioai/sim/pull/10013/commits/2c8244969ce06cecf9f4dfe13674e02357fcfac3
https://github.com/simstudioai/sim/tree/2c8244969ce06cecf9f4dfe13674e02357fcfac3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.