René's URL Explorer Experiment


Title: improvement(search-mcp): log rejected tool-call fields and batched read errors by waleedlatif1 · Pull Request #10003 · simstudioai/sim · GitHub

Open Graph Title: improvement(search-mcp): log rejected tool-call fields and batched read errors by waleedlatif1 · Pull Request #10003 · simstudioai/sim

X Title: improvement(search-mcp): log rejected tool-call fields and batched read errors by waleedlatif1 · Pull Request #10003 · simstudioai/sim

Description: Summary When a search MCP call's arguments fail the schema with unrecognized_keys, the rejection log now names the unknown fields (at most 5, each cut to 64 characters), not just the path and code When a batched read_document returns an error entry for a document (a stale or altered ID, a scope change, a provider failure), the server now logs the caller-facing reason; before, only unexpected failures were logged, so a call that returned errors for every document looked like a success Lets us tell a repeated client mistake apart from a new one and decide whether the existing argument repair should cover it; values are still never logged Type of Change Improvement Testing server.test.ts and server.protocol.test.ts pass New tool-arguments.test.ts: fails on the old code (no keys), passes on the new route-handler.test.ts passes; biome clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary When a search MCP call's arguments fail the schema with unrecognized_keys, the rejection log now names the unknown fields (at most 5, each cut to 64 characters), not just the path and ...

X Description: Summary When a search MCP call's arguments fail the schema with unrecognized_keys, the rejection log now names the unknown fields (at most 5, each cut to 64 characters), not just the path ...

Opengraph URL: https://github.com/simstudioai/sim/pull/10003

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7518851c-7a89-2552-c026-0b973e4a85c3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBF0A:2F516B:1AAEDC:275605:6AFB1DB1
html-safe-nonce5348c6d01733f1ccf91bf4cb945cb1242dfdf4115ddb57c35b2d863c574a0644
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjBBOjJGNTE2QjoxQUFFREM6Mjc1NjA1OjZBRkIxREIxIiwidmlzaXRvcl9pZCI6IjQwNDIzMjc1MDMxNDg4ODMzNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac104054674b8dc62a20dfbe712569baea192672e4b5fb4680fe81870ed7c236f3
hovercard-subject-tagpull_request:5300449657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/10003/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary When a search MCP call's arguments fail the schema with unrecognized_keys, the rejection log now names the unknown fields (at most 5, each cut to 64 characters), not just the path and ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd3b60f1fd9c5f10a3dcde41ae35682f53e85cee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/10003/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10003%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F10003%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/10003/files
Reloadhttps://github.com/simstudioai/sim/pull/10003/files
Reloadhttps://github.com/simstudioai/sim/pull/10003/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/search-mcp-rejected-keyshttps://github.com/simstudioai/sim/tree/improvement/search-mcp-rejected-keys
Conversation 11 https://github.com/simstudioai/sim/pull/10003
Commits 2 https://github.com/simstudioai/sim/pull/10003/commits
Checks 81 https://github.com/simstudioai/sim/pull/10003/checks
Files changed https://github.com/simstudioai/sim/pull/10003/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10003/files
improvement(search-mcp): log rejected tool-call fields and batched read errors https://github.com/simstudioai/sim/pull/10003/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/10003/files
3049529 improvement(search-mcp): log the field names a rejected tool call's a… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10003/commits/304952972b84405f495f00d40acef3d39f284c8d
dc3bbd8 improvement(search-mcp): say the logged-key cap applies per schema issue waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/10003/commits/dc3bbd8258dd3b65cef8cfb7d7bf1a1ccea7fe66
Clear filters https://github.com/simstudioai/sim/pull/10003/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10003/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10003/files
tool-arguments.test.ts https://github.com/simstudioai/sim/pull/10003/files#diff-bc5763210216ed411d7703c94ff7688d100b864159075bb8759bdb6883b5f6ce
tool-arguments.ts https://github.com/simstudioai/sim/pull/10003/files#diff-b4b8e6dc2d5649622aed478088aeb6bb6881ef39a747f0eab3e65d489918999f
apps/sim/lib/knowledge/mcp/tool-arguments.test.tshttps://github.com/simstudioai/sim/pull/10003/files#diff-bc5763210216ed411d7703c94ff7688d100b864159075bb8759bdb6883b5f6ce
View file https://github.com/simstudioai/sim/blob/dc3bbd8258dd3b65cef8cfb7d7bf1a1ccea7fe66/apps/sim/lib/knowledge/mcp/tool-arguments.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10003/{{ revealButtonHref }}
apps/sim/lib/knowledge/mcp/tool-arguments.tshttps://github.com/simstudioai/sim/pull/10003/files#diff-b4b8e6dc2d5649622aed478088aeb6bb6881ef39a747f0eab3e65d489918999f
View file https://github.com/simstudioai/sim/blob/dc3bbd8258dd3b65cef8cfb7d7bf1a1ccea7fe66/apps/sim/lib/knowledge/mcp/tool-arguments.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/10003/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/10003/files#diff-b4b8e6dc2d5649622aed478088aeb6bb6881ef39a747f0eab3e65d489918999f
https://github.com/simstudioai/sim/pull/10003/files#diff-b4b8e6dc2d5649622aed478088aeb6bb6881ef39a747f0eab3e65d489918999f
Please reload this pagehttps://github.com/simstudioai/sim/pull/10003/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/10003/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.