René's URL Explorer Experiment


Title: mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas · Issue #6755 · simstudioai/sim · GitHub

Open Graph Title: mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas · Issue #6755 · simstudioai/sim

X Title: mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas · Issue #6755 · simstudioai/sim

Description: Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / rm schemas, so the checked-in files carry...

Open Graph Description: Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / r...

X Description: Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / r...

Opengraph URL: https://github.com/simstudioai/sim/issues/6755

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas","articleBody":"## Summary\n\n`bun run mship-tools:check` fails on `staging` today, independent of any open PR. Regenerating the copilot tool catalog **strips** `maxLength: 4096` and `maxItems: 100` from the VFS `cp` / `mkdir` / `mv` / `rm` schemas, so the checked-in files carry bounds the generator cannot reproduce.\n\n```\n$ bun run mship-tools:check\nerror: Generated tool catalog is stale. Run: bun run mship-tools:generate\n```\n\nAffected entries in `apps/sim/lib/copilot/generated/tool-catalog-v1.ts` and `tool-schemas-v1.ts`:\n\n| Tool | Property | Constraint lost on regenerate |\n|---|---|---|\n| `Cp`, `Mv` | `destination` | `maxLength: 4096` |\n| `Cp`, `Mv` | `sources` | `maxItems: 100`, `items.maxLength: 4096` |\n| `Mkdir`, `Rm` | `paths` | `maxItems: 100`, `items.maxLength: 4096` |\n\n## Root cause\n\nThe constraints were **hand-edited into the generated files** and never added to the generator's actual input.\n\n`scripts/sync-tool-catalog.ts:8` reads its source of truth from a **sibling repository**:\n\n```ts\nconst DEFAULT_CATALOG_PATH = resolve(ROOT, '../copilot/copilot/contracts/tool-catalog-v1.json')\n```\n\nThat contract contains **zero** occurrences of `maxItems` on any branch of the copilot repo (`main`, `master`, `staging` all check out at 0). The bounds exist only in this repo's generated output, which is stamped:\n\n```\n// AUTO-GENERATED FILE. DO NOT EDIT.\n// Generated from copilot/contracts/tool-catalog-v1.json\n```\n\nThey were introduced by #5273 (`improvement(external-endpoints): v2 versions with clean signatures`), which touched only the two generated files:\n\n```\n$ git log -S \"maxItems: 100\" --oneline -- apps/sim/lib/copilot/generated/tool-catalog-v1.ts\n263e3ca67e improvement(external-endpoints): v2 versions with clean signatures ... (#5273)\n\n$ git show 263e3ca67e --stat -- apps/sim/lib/copilot/generated/\n apps/sim/lib/copilot/generated/tool-catalog-v1.ts | 14 ++++++++++----\n apps/sim/lib/copilot/generated/tool-schemas-v1.ts | 10 ++++++++++\n```\n\nSo this is not a generator defect — the generator is faithfully reproducing its input. The bounds are a good change that was applied to the wrong artifact, leaving them unreproducible and permanently divergent.\n\n## Why it has gone unnoticed\n\n`mship-tools:check` is **not wired into CI or `check:audits`**:\n\n```\n$ grep -rn \"mship-tools:check\" .github/ scripts/run-audits.ts\n(no matches)\n```\n\n`check:audits` runs 27 audits and passes; this is not one of them. Nothing fails when the catalog drifts.\n\n## Suggested fix\n\n1. Add the `maxLength` / `maxItems` bounds to `copilot/contracts/tool-catalog-v1.json` in the **copilot** repo, so `mship-tools:generate` emits them.\n2. Regenerate here and confirm the diff is empty.\n3. Decide whether `mship-tools:check` should join `check:audits`. It reads from a sibling repo that is not present in CI, which is likely why it was left out — if so, the check may only be meaningful locally, and that is worth stating explicitly so the next person does not \"fix\" the drift by regenerating and silently dropping the bounds.\n\n⚠️ Until (1) lands, **do not** run `bun run mship-tools:generate` to resolve the failing check — it removes the bounds. The checked-in file is the better of the two.\n\nFound during the post-merge audit in #6751; unrelated to that PR and deliberately left untouched there.\n","author":{"url":"https://github.com/waleedlatif1","@type":"Person","name":"waleedlatif1"},"datePublished":"2026-08-16T00:19:44Z","url":"https://github.com/simstudioai/sim/issues/6755"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ce657a6b-9336-59b1-121d-7d67be8a420b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE412:14A871:56C8CC:7BFB83:6AFB3E0C
html-safe-nonce97c3aaf1c64a01ae45637c880492ded1a2e2eb149ae7aec47039db2d0e41e2fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDEyOjE0QTg3MTo1NkM4Q0M6N0JGQjgzOjZBRkIzRTBDIiwidmlzaXRvcl9pZCI6Ijg1ODk3NjM3OTU4MzAzOTAyODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacff0c6b3d26426525c2477389d69df598ccbfb96f4c3fc0ac154206f89f95e947
hovercard-subject-tagissue:5161953226
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/simstudioai/sim/6755/issue_layout
twitter:imagehttps://opengraph.githubassets.com/55b2d92135a4be86cde6cf13749cb9b84eb421e21175229b7719a1910cc02edc/simstudioai/sim/issues/6755
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55b2d92135a4be86cde6cf13749cb9b84eb421e21175229b7719a1910cc02edc/simstudioai/sim/issues/6755
og:image:altSummary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/simstudioai/sim/issues/6755#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fissues%2F6755
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fissues%2F6755
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/issues/6755
Reloadhttps://github.com/simstudioai/sim/issues/6755
Reloadhttps://github.com/simstudioai/sim/issues/6755
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
New issuehttps://github.com/login?return_to=https://github.com/simstudioai/sim/issues/6755
New issuehttps://github.com/login?return_to=https://github.com/simstudioai/sim/issues/6755
mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemashttps://github.com/simstudioai/sim/issues/6755#top
https://github.com/waleedlatif1
waleedlatif1https://github.com/waleedlatif1
on Aug 16, 2026https://github.com/simstudioai/sim/issues/6755#issue-5161953226
#5273https://github.com/simstudioai/sim/pull/5273
#6751https://github.com/simstudioai/sim/pull/6751
waleedlatif1https://github.com/waleedlatif1
completedhttps://github.com/simstudioai/sim/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 16, 2026https://github.com/simstudioai/sim/issues/6755#event-29518240793
Sign up for freehttps://github.com/signup?return_to=https://github.com/simstudioai/sim/issues/6755
Sign in to commenthttps://github.com/login?return_to=https://github.com/simstudioai/sim/issues/6755
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.