Title: mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas · Issue #6755 · simstudioai/sim · GitHub
Open Graph Title: mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas · Issue #6755 · simstudioai/sim
X Title: mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas · Issue #6755 · simstudioai/sim
Description: Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / rm schemas, so the checked-in files carry...
Open Graph Description: Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / r...
X Description: Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / r...
Opengraph URL: https://github.com/simstudioai/sim/issues/6755
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mship-tools:check is stale on staging: regenerating strips maxLength/maxItems from the VFS cp/mkdir/mv/rm schemas","articleBody":"## Summary\n\n`bun run mship-tools:check` fails on `staging` today, independent of any open PR. Regenerating the copilot tool catalog **strips** `maxLength: 4096` and `maxItems: 100` from the VFS `cp` / `mkdir` / `mv` / `rm` schemas, so the checked-in files carry bounds the generator cannot reproduce.\n\n```\n$ bun run mship-tools:check\nerror: Generated tool catalog is stale. Run: bun run mship-tools:generate\n```\n\nAffected entries in `apps/sim/lib/copilot/generated/tool-catalog-v1.ts` and `tool-schemas-v1.ts`:\n\n| Tool | Property | Constraint lost on regenerate |\n|---|---|---|\n| `Cp`, `Mv` | `destination` | `maxLength: 4096` |\n| `Cp`, `Mv` | `sources` | `maxItems: 100`, `items.maxLength: 4096` |\n| `Mkdir`, `Rm` | `paths` | `maxItems: 100`, `items.maxLength: 4096` |\n\n## Root cause\n\nThe constraints were **hand-edited into the generated files** and never added to the generator's actual input.\n\n`scripts/sync-tool-catalog.ts:8` reads its source of truth from a **sibling repository**:\n\n```ts\nconst DEFAULT_CATALOG_PATH = resolve(ROOT, '../copilot/copilot/contracts/tool-catalog-v1.json')\n```\n\nThat contract contains **zero** occurrences of `maxItems` on any branch of the copilot repo (`main`, `master`, `staging` all check out at 0). The bounds exist only in this repo's generated output, which is stamped:\n\n```\n// AUTO-GENERATED FILE. DO NOT EDIT.\n// Generated from copilot/contracts/tool-catalog-v1.json\n```\n\nThey were introduced by #5273 (`improvement(external-endpoints): v2 versions with clean signatures`), which touched only the two generated files:\n\n```\n$ git log -S \"maxItems: 100\" --oneline -- apps/sim/lib/copilot/generated/tool-catalog-v1.ts\n263e3ca67e improvement(external-endpoints): v2 versions with clean signatures ... (#5273)\n\n$ git show 263e3ca67e --stat -- apps/sim/lib/copilot/generated/\n apps/sim/lib/copilot/generated/tool-catalog-v1.ts | 14 ++++++++++----\n apps/sim/lib/copilot/generated/tool-schemas-v1.ts | 10 ++++++++++\n```\n\nSo this is not a generator defect — the generator is faithfully reproducing its input. The bounds are a good change that was applied to the wrong artifact, leaving them unreproducible and permanently divergent.\n\n## Why it has gone unnoticed\n\n`mship-tools:check` is **not wired into CI or `check:audits`**:\n\n```\n$ grep -rn \"mship-tools:check\" .github/ scripts/run-audits.ts\n(no matches)\n```\n\n`check:audits` runs 27 audits and passes; this is not one of them. Nothing fails when the catalog drifts.\n\n## Suggested fix\n\n1. Add the `maxLength` / `maxItems` bounds to `copilot/contracts/tool-catalog-v1.json` in the **copilot** repo, so `mship-tools:generate` emits them.\n2. Regenerate here and confirm the diff is empty.\n3. Decide whether `mship-tools:check` should join `check:audits`. It reads from a sibling repo that is not present in CI, which is likely why it was left out — if so, the check may only be meaningful locally, and that is worth stating explicitly so the next person does not \"fix\" the drift by regenerating and silently dropping the bounds.\n\n⚠️ Until (1) lands, **do not** run `bun run mship-tools:generate` to resolve the failing check — it removes the bounds. The checked-in file is the better of the two.\n\nFound during the post-merge audit in #6751; unrelated to that PR and deliberately left untouched there.\n","author":{"url":"https://github.com/waleedlatif1","@type":"Person","name":"waleedlatif1"},"datePublished":"2026-08-16T00:19:44Z","url":"https://github.com/simstudioai/sim/issues/6755"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ce657a6b-9336-59b1-121d-7d67be8a420b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E412:14A871:56C8CC:7BFB83:6AFB3E0C |
| html-safe-nonce | 97c3aaf1c64a01ae45637c880492ded1a2e2eb149ae7aec47039db2d0e41e2fd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDEyOjE0QTg3MTo1NkM4Q0M6N0JGQjgzOjZBRkIzRTBDIiwidmlzaXRvcl9pZCI6Ijg1ODk3NjM3OTU4MzAzOTAyODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ff0c6b3d26426525c2477389d69df598ccbfb96f4c3fc0ac154206f89f95e947 |
| hovercard-subject-tag | issue:5161953226 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/simstudioai/sim/6755/issue_layout |
| twitter:image | https://opengraph.githubassets.com/55b2d92135a4be86cde6cf13749cb9b84eb421e21175229b7719a1910cc02edc/simstudioai/sim/issues/6755 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55b2d92135a4be86cde6cf13749cb9b84eb421e21175229b7719a1910cc02edc/simstudioai/sim/issues/6755 |
| og:image:alt | Summary bun run mship-tools:check fails on staging today, independent of any open PR. Regenerating the copilot tool catalog strips maxLength: 4096 and maxItems: 100 from the VFS cp / mkdir / mv / r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | waleedlatif1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-preview |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width