René's URL Explorer Experiment


Title: Fix flaky upload tests. by NorberMV · Pull Request #313 · shotgunsoftware/python-api · GitHub

Open Graph Title: Fix flaky upload tests. by NorberMV · Pull Request #313 · shotgunsoftware/python-api

X Title: Fix flaky upload tests. by NorberMV · Pull Request #313 · shotgunsoftware/python-api

Description: This PR fixes flaky tests that contain the following errors: - AssertionError: 'image/png' != 'image/jpeg' - AssertionError: '304' != '200' Allows upload requests with status '304' in the thumbnail upload tests, because sometimes when the response hasn't been modified, this status informs the client that the response has not changed, so the client can continue using the same cached version. Also supports transient placeholder PNG file content types in the response payload, since sometimes it takes longer for the previously uploaded image requested to be available from media storage, and we have previously tested that the image was successfully uploaded.

Open Graph Description: This PR fixes flaky tests that contain the following errors: - AssertionError: 'image/png' != 'image/jpeg' - AssertionError: '304' != '200' Allows upload requests w...

X Description: This PR fixes flaky tests that contain the following errors: - AssertionError: 'image/png' != 'image/jpeg' - AssertionError: '304' != '200&am...

Opengraph URL: https://github.com/shotgunsoftware/python-api/pull/313

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:16429c8b-8ed3-5952-d52a-f3d23f17dd60
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC57C:73CFA:3AE64B:51816A:6A511C52
html-safe-nonced0bc17439db009b0220d4743d3bfa86f424ed258e4e5476695111d2309afff78
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTdDOjczQ0ZBOjNBRTY0Qjo1MTgxNkE6NkE1MTFDNTIiLCJ2aXNpdG9yX2lkIjoiODM2MjY3NTkwNzI0Njg4OTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc8c8ebd2d58a06a9b671a31cb344905032ab77fbb3397464ea0adde779e7ac65
hovercard-subject-tagpull_request:1573859619
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/shotgunsoftware/python-api/pull/313/files
twitter:imagehttps://avatars.githubusercontent.com/u/42726133?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/42726133?s=400&v=4
og:image:altThis PR fixes flaky tests that contain the following errors: - AssertionError: 'image/png' != 'image/jpeg' - AssertionError: '304' != '200' Allows upload requests w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef0f0f3a40c5b69803a8255a8e44323880bf9c4db54d5c076f2130bedf2a1dde5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/shotgunsoftware/python-api git https://github.com/shotgunsoftware/python-api.git
octolytics-dimension-user_id317894
octolytics-dimension-user_loginshotgunsoftware
octolytics-dimension-repository_id748742
octolytics-dimension-repository_nwoshotgunsoftware/python-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id748742
octolytics-dimension-repository_network_root_nwoshotgunsoftware/python-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44909533816f7f99ff04e7a0fe692733af67ed84
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/shotgunsoftware/python-api/pull/313/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fshotgunsoftware%2Fpython-api%2Fpull%2F313%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fshotgunsoftware%2Fpython-api%2Fpull%2F313%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=shotgunsoftware%2Fpython-api
Reloadhttps://github.com/shotgunsoftware/python-api/pull/313/files
Reloadhttps://github.com/shotgunsoftware/python-api/pull/313/files
Reloadhttps://github.com/shotgunsoftware/python-api/pull/313/files
Please reload this pagehttps://github.com/shotgunsoftware/python-api/pull/313/files
shotgunsoftware https://github.com/shotgunsoftware
python-apihttps://github.com/shotgunsoftware/python-api
Notifications https://github.com/login?return_to=%2Fshotgunsoftware%2Fpython-api
Fork 203 https://github.com/login?return_to=%2Fshotgunsoftware%2Fpython-api
Star 319 https://github.com/login?return_to=%2Fshotgunsoftware%2Fpython-api
Code https://github.com/shotgunsoftware/python-api
Issues 39 https://github.com/shotgunsoftware/python-api/issues
Pull requests 14 https://github.com/shotgunsoftware/python-api/pulls
Actions https://github.com/shotgunsoftware/python-api/actions
Projects https://github.com/shotgunsoftware/python-api/projects
Models https://github.com/shotgunsoftware/python-api/models
Wiki https://github.com/shotgunsoftware/python-api/wiki
Security and quality 0 https://github.com/shotgunsoftware/python-api/security
Insights https://github.com/shotgunsoftware/python-api/pulse
Code https://github.com/shotgunsoftware/python-api
Issues https://github.com/shotgunsoftware/python-api/issues
Pull requests https://github.com/shotgunsoftware/python-api/pulls
Actions https://github.com/shotgunsoftware/python-api/actions
Projects https://github.com/shotgunsoftware/python-api/projects
Models https://github.com/shotgunsoftware/python-api/models
Wiki https://github.com/shotgunsoftware/python-api/wiki
Security and quality https://github.com/shotgunsoftware/python-api/security
Insights https://github.com/shotgunsoftware/python-api/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fshotgunsoftware%2Fpython-api%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fshotgunsoftware%2Fpython-api%2Fissues%2Fnew%2Fchoose
NorberMVhttps://github.com/NorberMV
masterhttps://github.com/shotgunsoftware/python-api/tree/master
SG-30485_Flaky_Thumbnail_Related_Tests_On_Python_Apihttps://github.com/shotgunsoftware/python-api/tree/SG-30485_Flaky_Thumbnail_Related_Tests_On_Python_Api
Conversation 1 https://github.com/shotgunsoftware/python-api/pull/313
Commits 1 https://github.com/shotgunsoftware/python-api/pull/313/commits
Checks 0 https://github.com/shotgunsoftware/python-api/pull/313/checks
Files changed https://github.com/shotgunsoftware/python-api/pull/313/files
Please reload this pagehttps://github.com/shotgunsoftware/python-api/pull/313/files
Fix flaky upload tests. https://github.com/shotgunsoftware/python-api/pull/313/files#top
Show all changes 1 commit https://github.com/shotgunsoftware/python-api/pull/313/files
b9a110d Fix flaky upload tests. NorberMV Oct 25, 2023 https://github.com/shotgunsoftware/python-api/pull/313/commits/b9a110d974f66baa003c6d3a69ee717a800bc333
Clear filters https://github.com/shotgunsoftware/python-api/pull/313/files
Please reload this pagehttps://github.com/shotgunsoftware/python-api/pull/313/files
Please reload this pagehttps://github.com/shotgunsoftware/python-api/pull/313/files
tests/test_api.pyhttps://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
View file https://github.com/shotgunsoftware/python-api/blob/b9a110d974f66baa003c6d3a69ee717a800bc333/tests/test_api.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/shotgunsoftware/python-api/pull/313/{{ revealButtonHref }}
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/shotgunsoftware/python-api/pull/313/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.