René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Uploading files that share the same base filename to S3 can overwrite each other","articleBody":"When performing an upload via the SG API, we have multiple files that share a common filename but are in completely different paths. If we try to upload both of those simultaneously, the AWS upload URL is the same for both.\r\n\r\nIn `_upload_to_storage()`, `os.path.basename(path)` is passed to the `_get_attachment_upload_info` call. On the AWS side, that means that no matter the parent directory, any file that shares the base name will get a duplicate upload URL.\r\n\r\nThis only occurs if the `_upload_to_storage()` call happens concurrently : I'm guessing that the SG backend uses a timestamp to differentiate calls, because currently we do this about 30 times, but only when multiple get called at the same time do we get a duplicate upload URL.\r\n\r\n[The culprit line is here](https://github.com/shotgunsoftware/python-api/blob/b3ebbb5664c01b3e98bfd8ee5ffa32da0e3e5c0c/shotgun_api3/shotgun.py#L2483C19-L2483C19).\r\n\r\nRecommend changing:\r\n`filename = os.path.basename(path)`\r\nto something like:\r\n`filename = os.path.abspath(path)`","author":{"url":"https://github.com/briansmith-epic","@type":"Person","name":"briansmith-epic"},"datePublished":"2023-08-14T08:53:45.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/294/python-api/issues/294"}