René's URL Explorer Experiment


Title: docs: fix asynchronous_mail_send by Taywee · Pull Request #953 · sendgrid/sendgrid-python · GitHub

Open Graph Title: docs: fix asynchronous_mail_send by Taywee · Pull Request #953 · sendgrid/sendgrid-python

X Title: docs: fix asynchronous_mail_send by Taywee · Pull Request #953 · sendgrid/sendgrid-python

Description: Fixes The previous solution was not properly asynchronous despite using an event loop and async functions (as mentioned in this comment on #363 and a few comments in #296). It had an async function that didn't actually await a future, meaning it would still block the entire event loop on every send. This uses the event loop executor to background it onto an executor thread, which will still at least let IO properly parallelize while the GIL is released. Checklist I acknowledge that all my contributions will be made under the project's license I have made a material change to the repo (functionality, testing, spelling, grammar) I have read the Contribution Guidelines and my PR follows them I have titled the PR appropriately I have updated my branch with the main branch [N/A] I have added tests that prove my fix is effective or that my feature works I have added the necessary documentation about the functionality in the appropriate .md file [N/A] I have added inline documentation to the code I modified

Open Graph Description: Fixes The previous solution was not properly asynchronous despite using an event loop and async functions (as mentioned in this comment on #363 and a few comments in #296). It had an async functio...

X Description: Fixes The previous solution was not properly asynchronous despite using an event loop and async functions (as mentioned in this comment on #363 and a few comments in #296). It had an async functio...

Opengraph URL: https://github.com/sendgrid/sendgrid-python/pull/953

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4bcd1c07-f69e-ccff-a8ec-9363e845df1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EF0:CE438:81C0B9:AE2DEA:6B01BDD3
html-safe-nonce344f7e498f657452047ff9338ec1eb7a3bd6ec7a020ffe1a1b6ccbb8bc66adcb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUYwOkNFNDM4OjgxQzBCOTpBRTJERUE6NkIwMUJERDMiLCJ2aXNpdG9yX2lkIjoiNzA3NDg5MDQ4NTA2MzU5NzUyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4293c4988e9d15edf4ee0560e5a106b02c93ebf2a81587fe2290af5fff5b79a7
hovercard-subject-tagpull_request:524953089
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sendgrid/sendgrid-python/pull/953/files
twitter:imagehttps://avatars.githubusercontent.com/u/1069915?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1069915?s=400&v=4
og:image:altFixes The previous solution was not properly asynchronous despite using an event loop and async functions (as mentioned in this comment on #363 and a few comments in #296). It had an async functio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sendgrid/sendgrid-python git https://github.com/sendgrid/sendgrid-python.git
octolytics-dimension-user_id181234
octolytics-dimension-user_loginsendgrid
octolytics-dimension-repository_id3546794
octolytics-dimension-repository_nwosendgrid/sendgrid-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3546794
octolytics-dimension-repository_network_root_nwosendgrid/sendgrid-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sendgrid/sendgrid-python/pull/953/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsendgrid%2Fsendgrid-python%2Fpull%2F953%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsendgrid%2Fsendgrid-python%2Fpull%2F953%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sendgrid%2Fsendgrid-python
Reloadhttps://github.com/sendgrid/sendgrid-python/pull/953/files
Reloadhttps://github.com/sendgrid/sendgrid-python/pull/953/files
Reloadhttps://github.com/sendgrid/sendgrid-python/pull/953/files
sendgridhttps://github.com/sendgrid
sendgrid-pythonhttps://github.com/sendgrid/sendgrid-python
Codehttps://github.com/sendgrid/sendgrid-python
Issues50 (50)https://github.com/sendgrid/sendgrid-python/issues
Pull requests17 (17)https://github.com/sendgrid/sendgrid-python/pulls
Actionshttps://github.com/sendgrid/sendgrid-python/actions
Security and qualityhttps://github.com/sendgrid/sendgrid-python/security
Insightshttps://github.com/sendgrid/sendgrid-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fsendgrid%2Fsendgrid-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsendgrid%2Fsendgrid-python%2Fissues%2Fnew%2Fchoose
Tayweehttps://github.com/Taywee
sendgrid:mainhttps://github.com/sendgrid/sendgrid-python/tree/main
TaylorRichberger:mainhttps://github.com/TaylorRichberger/sendgrid-python/tree/main
Conversation 10 https://github.com/sendgrid/sendgrid-python/pull/953
Commits 3 https://github.com/sendgrid/sendgrid-python/pull/953/commits
Checks 0 https://github.com/sendgrid/sendgrid-python/pull/953/checks
Files changed https://github.com/sendgrid/sendgrid-python/pull/953/files
Please reload this pagehttps://github.com/sendgrid/sendgrid-python/pull/953/files
docs: fix asynchronous_mail_send https://github.com/sendgrid/sendgrid-python/pull/953/files#top
Show all changes 3 commits https://github.com/sendgrid/sendgrid-python/pull/953/files
b462782 fix asynchronous_mail_send Nov 20, 2020 https://github.com/sendgrid/sendgrid-python/pull/953/commits/b4627820a2e9ca2e5fe054dcbdaee177e7afdf38
a51f4a3 remove callback Nov 20, 2020 https://github.com/sendgrid/sendgrid-python/pull/953/commits/a51f4a30cd513943dc8fa06ccc3527ee04892b24
356d27a Merge branch 'main' into main thinkingserious Dec 1, 2020 https://github.com/sendgrid/sendgrid-python/pull/953/commits/356d27a04013f121d2b82e6c492797a893fdce30
Clear filters https://github.com/sendgrid/sendgrid-python/pull/953/files
Please reload this pagehttps://github.com/sendgrid/sendgrid-python/pull/953/files
Please reload this pagehttps://github.com/sendgrid/sendgrid-python/pull/953/files
use_cases/asynchronous_mail_send.mdhttps://github.com/sendgrid/sendgrid-python/pull/953/files#diff-4df1d53f61b8f64980169ca5c91a7f38ea3cc77f3dcd00d6f54315a4918c9ac3
View file https://github.com/TaylorRichberger/sendgrid-python/blob/356d27a04013f121d2b82e6c492797a893fdce30/use_cases/asynchronous_mail_send.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sendgrid/sendgrid-python/pull/953/{{ revealButtonHref }}
eshanholtzhttps://github.com/eshanholtz
Nov 25, 2020https://github.com/sendgrid/sendgrid-python/pull/953/files#r530047983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sendgrid/sendgrid-python/pull/953/files
Tayweehttps://github.com/Taywee
Nov 27, 2020https://github.com/sendgrid/sendgrid-python/pull/953/files#r531776541
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sendgrid/sendgrid-python/pull/953/files
https://github.com/sendgrid/sendgrid-python/pull/953/files#diff-4df1d53f61b8f64980169ca5c91a7f38ea3cc77f3dcd00d6f54315a4918c9ac3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.