René's URL Explorer Experiment


Title: Add ability to configure affinity and tolerations for scans and hooks by malexmave · Pull Request #806 · secureCodeBox/secureCodeBox · GitHub

Open Graph Title: Add ability to configure affinity and tolerations for scans and hooks by malexmave · Pull Request #806 · secureCodeBox/secureCodeBox

X Title: Add ability to configure affinity and tolerations for scans and hooks by malexmave · Pull Request #806 · secureCodeBox/secureCodeBox

Description: Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Supercedes #804 to avoid having an ugly history. Currently in draft state. Tasks: Add to ScanSpec and ScanCompletionHookSpec CRDs and re-generate them Add to controller (pull information from CRD and put it into the pod) Check if / how the parsers can also be informed about affinity / tolerations Have the hooks inherit their affinity and tolerations from the scans triggering them Check if the JS CRDs need to be updated (hooks, SDKs) Add new inheritX labels? Or should it simply be inherited by cascading scans without asking? Add test cases for cascading hooks Test everything Support configuration via values.yaml file Double-check if the docs need to be updated anywhere or if everything is done automatically anyway

Open Graph Description: Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Supercedes #804 to avoid having an ugly history. Currently in draft state. Tasks: ...

X Description: Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Supercedes #804 to avoid having an ugly history. Currently in draft state. Tasks: ...

Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/806

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7f6d99a8-86c0-17b3-c373-6d879820c30c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE782:1074E3:62E279:7FECC4:69904BE6
html-safe-nonce78ad17cac490d911c452d8384b810c1c0889d54aa37569d8e797b91e550c3525
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzgyOjEwNzRFMzo2MkUyNzk6N0ZFQ0M0OjY5OTA0QkU2IiwidmlzaXRvcl9pZCI6IjM1ODM3MDM3MDkwMTk2NDU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac649812ed53a42c8d5ad3b1c178eb2c0aa5ef6152db63bc602bc89ee27e00a48b
hovercard-subject-tagpull_request:778314786
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/806/files
twitter:imagehttps://avatars.githubusercontent.com/u/1688580?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1688580?s=400&v=4
og:image:altDescription This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Supercedes #804 to avoid having an ugly history. Currently in draft state. Tasks: ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git
octolytics-dimension-user_id34573705
octolytics-dimension-user_loginsecureCodeBox
octolytics-dimension-repository_id80711933
octolytics-dimension-repository_nwosecureCodeBox/secureCodeBox
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id80711933
octolytics-dimension-repository_network_root_nwosecureCodeBox/secureCodeBox
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/secureCodeBox/secureCodeBox/pull/806/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FsecureCodeBox%2FsecureCodeBox%2Fpull%2F806%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FsecureCodeBox%2FsecureCodeBox%2Fpull%2F806%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=secureCodeBox%2FsecureCodeBox
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
secureCodeBox https://github.com/secureCodeBox
secureCodeBoxhttps://github.com/secureCodeBox/secureCodeBox
Notifications https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Fork 179 https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Star 955 https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Code https://github.com/secureCodeBox/secureCodeBox
Issues 71 https://github.com/secureCodeBox/secureCodeBox/issues
Pull requests 4 https://github.com/secureCodeBox/secureCodeBox/pulls
Discussions https://github.com/secureCodeBox/secureCodeBox/discussions
Actions https://github.com/secureCodeBox/secureCodeBox/actions
Projects 1 https://github.com/secureCodeBox/secureCodeBox/projects
Security 1 https://github.com/secureCodeBox/secureCodeBox/security
Insights https://github.com/secureCodeBox/secureCodeBox/pulse
Code https://github.com/secureCodeBox/secureCodeBox
Issues https://github.com/secureCodeBox/secureCodeBox/issues
Pull requests https://github.com/secureCodeBox/secureCodeBox/pulls
Discussions https://github.com/secureCodeBox/secureCodeBox/discussions
Actions https://github.com/secureCodeBox/secureCodeBox/actions
Projects https://github.com/secureCodeBox/secureCodeBox/projects
Security https://github.com/secureCodeBox/secureCodeBox/security
Insights https://github.com/secureCodeBox/secureCodeBox/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FsecureCodeBox%2FsecureCodeBox%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox%2Fissues%2Fnew%2Fchoose
malexmavehttps://github.com/malexmave
mainhttps://github.com/secureCodeBox/secureCodeBox/tree/main
feature/affinity-and-tolerationshttps://github.com/secureCodeBox/secureCodeBox/tree/feature/affinity-and-tolerations
Conversation 13 https://github.com/secureCodeBox/secureCodeBox/pull/806
Commits 13 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits
Checks 0 https://github.com/secureCodeBox/secureCodeBox/pull/806/checks
Files changed https://github.com/secureCodeBox/secureCodeBox/pull/806/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
Add ability to configure affinity and tolerations for scans and hooks https://github.com/secureCodeBox/secureCodeBox/pull/806/files#top
Show all changes 13 commits https://github.com/secureCodeBox/secureCodeBox/pull/806/files
f75d323 Update CRDs with affinity and tolerations malexmave Nov 11, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/f75d323d5492517590f3b0548c4bae27ead4d5ce
fb7723a Update reconcilers with new CRD fields malexmave Nov 11, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/fb7723a0907e60699a34e024c0dc00d5ffb45380
29aad2e Updating Helm Docs malexmave Nov 11, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/29aad2e68857148fd75f8dbc7e9ef6bb562c4012
6b88aee Correct access to affinity malexmave Nov 11, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/6b88aeea80046e707965e65e443ec70777870080
76e221b Also set affinity and tolerations for parsers malexmave Nov 11, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/76e221b4e0e87d135111845f7e0bc6817103cd60
6c770ef Remove affinity and tolerations from hook CRD malexmave Nov 16, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/6c770ef016bbd2d11e60bdd4ffd4597842f18c0a
ecc66b0 Set hook affinity and tolerations from scan malexmave Nov 16, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/ecc66b022426a2c201f00de0c545e83cb808d95e
19775b8 Affinity and Toleration support for cascading scan malexmave Nov 16, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/19775b8807326df6028755958ad6cf3898c35a92
a840ed6 Add inheritAffinity and inheritTolerations options malexmave Nov 16, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/a840ed6c79f188ca4657f6e2d9b4ed532fc9d64f
877f83d Respect affinity and tolerations from helm values malexmave Nov 17, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/877f83dc2be1a736f396acdbba8dc0ceec5328ba
ecd5169 Hook affinity and tolerations from helm values malexmave Nov 18, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/ecd5169a2aed077eeea85101c5b7f7af907b4dc2
7b6efa1 Remove debug print statements malexmave Nov 18, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/7b6efa12c09f17491fe18d099a9dcd71fa9d9165
74d40e3 Add ADR for affinity and toleration inheritance malexmave Nov 22, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/806/commits/74d40e375f2cfdca67d409d69cd815ccc6c1f80e
Clear filters https://github.com/secureCodeBox/secureCodeBox/pull/806/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
adr_0010.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-1503e0d379ae82cf4173f8d89986394c8f5cf3e27b8eecc14d8679aeb99cef0e
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-8dedb3caec13a0c326454cf9354c56e2143026caca1cbdc66f76d903bf13c84f
hook.test.js https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-d6ded739603654441dbbe4da5d54022d49c70665f1ca86ca20b7b16ec2f6c824
hook.ts https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-37fa5acf6fd9b9f023797844a0e95355a2606dbe2cf960ed4908f205cc9e5993
scan-helpers.ts https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-0f0d23f851644e5bf553f3fc75b8a4aaae080d087f2004105d384ad784bb08e8
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-0104c48eec35a107c14f5a4109704e917f4a067e0fed16bfd0122d7d2f40548f
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-8485ac8bd253b04273d586d0e8301d7556bbccb3b70558409dacc6eef5778345
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-ee525d19c7d2eee59468474ff2f0efab750fb532edc10cbb4ba6377f4c7ba420
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-9676b044e383e61d02481c25fbd889b065e9890a3bd465532908cc4e55ce77f5
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-fc1679d70e04f7f0499115f47fa4cafc12eb36db1400b3cd8ce36491ddae050d
README.md https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-2a308930b3a9844fe54693383f15438e1c4804497f8d1dec682d1e10253eedaf
parsedefinition_types.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-1b86aeddeb3f563fcfc8d270bd9cfc31b7c52a430349d921e1d585499f015a6b
scan_types.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-7bd70c1a539e53393c9a4f5001447889dffcad04de11abefb3676dc8808897c0
scancompletionhook_types.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-1c58e1189952c3a6a6032ae2269064b567bdf5209614059b6d13f8849d833dd7
zz_generated.deepcopy.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-152f1b1e419193bf7d3b24d9afb56e056c0bde8133c7ac82d72363ba724fdd1d
cascading.securecodebox.io_cascadingrules.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-cae954cc61d44a1aed469d52e06038d2d9603e77a7b8a5e2c4adede662c8975a
execution.securecodebox.io_parsedefinitions.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-757f704015ebb0c9a77fdc3575e08e060c157053595d65e81d0e194c199bbcad
execution.securecodebox.io_scancompletionhooks.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-733c6e91930dedff47d444e74b661742342cfc45496a19013a2294a5f4059b76
execution.securecodebox.io_scans.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-45034fed31dc57722a159d07d3e4e40b67370396468aaa7a03aa4bc42efdb950
execution.securecodebox.io_scheduledscans.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-c71483d8357da2397574455ba10512d6fce690dfc7634c220d697a7c52251a67
hook_reconciler.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
parse_reconciler.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-5c2e6520d65f675219f107c7ae56e26d0be0d74725c3614567691b02fe5c6134
scan_reconciler.go https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-0b03d4f75fc6e125c9eb5fb0591a44316922c7a2857a11629a5060cf3597421c
cascading.securecodebox.io_cascadingrules.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-b5b2c75480cbd4675fa2eaf691acfb404be84dd4fc30f9a206f469e7a9c2648c
execution.securecodebox.io_parsedefinitions.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-90456a1bb52a4c95f7e782ec33121c17c6f7f2345a0e3e195038f0aa90a014ec
execution.securecodebox.io_scancompletionhooks.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-a8ac06106f132867be8d52f43c347f0ee7c84c6163a38d4a7ff1871135a52eed
execution.securecodebox.io_scans.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-8b8bc653ee4556f3834c4bc8f3da9a18257f073c1a248cd36dbffe1ddcdf09cc
execution.securecodebox.io_scheduledscans.yaml https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-27938938794a03cd18ad61acd19690d684101f8b41eb0690e9bc846dd06eabaf
docs/adr/adr_0010.mdhttps://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-1503e0d379ae82cf4173f8d89986394c8f5cf3e27b8eecc14d8679aeb99cef0e
View file https://github.com/secureCodeBox/secureCodeBox/blob/74d40e375f2cfdca67d409d69cd815ccc6c1f80e/docs/adr/adr_0010.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/806/{{ revealButtonHref }}
hooks/cascading-scans/README.mdhttps://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-8dedb3caec13a0c326454cf9354c56e2143026caca1cbdc66f76d903bf13c84f
View file https://github.com/secureCodeBox/secureCodeBox/blob/74d40e375f2cfdca67d409d69cd815ccc6c1f80e/hooks/cascading-scans/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/806/{{ revealButtonHref }}
https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-8dedb3caec13a0c326454cf9354c56e2143026caca1cbdc66f76d903bf13c84f
https://github.com/secureCodeBox/secureCodeBox/pull/806/files#diff-8dedb3caec13a0c326454cf9354c56e2143026caca1cbdc66f76d903bf13c84f
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/806/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.