Title: Add ability to configure affinity and tolerations for scans and hooks by malexmave · Pull Request #804 · secureCodeBox/secureCodeBox · GitHub
Open Graph Title: Add ability to configure affinity and tolerations for scans and hooks by malexmave · Pull Request #804 · secureCodeBox/secureCodeBox
X Title: Add ability to configure affinity and tolerations for scans and hooks by malexmave · Pull Request #804 · secureCodeBox/secureCodeBox
Description: Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Currently in draft state. Tasks: Add to ScanSpec and ScanCompletionHookSpec CRDs and re-generate them Add to controller (pull information from CRD and put it into the pod) Check if the JS definitions need to be updated (hooks, SDKs) Add new inheritX labels Add test cases for cascading hooks Test everything Double-check if the docs need to be updated anywhere or if everything is done automatically anyway @J12934: Is this something that would be useful to also add to the values.yaml for the different scanners? That way, you could have specific scan types always run with a specific toleration / affinity and would not need to specify it every single time. I will try to wrap this up later today so we can release it as part of 3.4 - that way the inconvenience of having to manually update CRDs can be lessened, as a CRD update is necessary anyway because of the new hook features. (Not looking forward to the merge conflicts - perhaps we should merge the other two PRs so I can quickly rebase on that branch to avoid that pain down the road?)
Open Graph Description: Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Currently in draft state. Tasks: Add to ScanSpec and ScanCompletionHookSpec CRDs a...
X Description: Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Currently in draft state. Tasks: Add to ScanSpec and ScanCompletionHookSpec CRDs a...
Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/804
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f7c1644b-0cc6-05c7-31cd-ecaca0cdd9cf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E12:B7C55:471B36:59B09A:698FFB6A |
| html-safe-nonce | 819f8abefcef3f99510ac2cf9a37947a25d956c515d34f7adef323d5f810026b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTEyOkI3QzU1OjQ3MUIzNjo1OUIwOUE6Njk4RkZCNkEiLCJ2aXNpdG9yX2lkIjoiMTIwNzU3ODg4NjUyNDYzMTkxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2f5c1a56347d82601576096bf3eb32276bb3c1c98fdbadc594ce55ad71280009 |
| hovercard-subject-tag | pull_request:777316557 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/804/files |
| twitter:image | https://avatars.githubusercontent.com/u/1688580?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1688580?s=400&v=4 |
| og:image:alt | Description This PR resolves #803 by adding affinity and tolerations to the ScanSpec and ScanCompletionHookSpec. Currently in draft state. Tasks: Add to ScanSpec and ScanCompletionHookSpec CRDs a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git |
| octolytics-dimension-user_id | 34573705 |
| octolytics-dimension-user_login | secureCodeBox |
| octolytics-dimension-repository_id | 80711933 |
| octolytics-dimension-repository_nwo | secureCodeBox/secureCodeBox |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 80711933 |
| octolytics-dimension-repository_network_root_nwo | secureCodeBox/secureCodeBox |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width