René's URL Explorer Experiment


Title: Ensure Findings are validated in Integration Tests (closes #546) by JohannesZahn · Pull Request #603 · secureCodeBox/secureCodeBox · GitHub

Open Graph Title: Ensure Findings are validated in Integration Tests (closes #546) by JohannesZahn · Pull Request #603 · secureCodeBox/secureCodeBox

X Title: Ensure Findings are validated in Integration Tests (closes #546) by JohannesZahn · Pull Request #603 · secureCodeBox/secureCodeBox

Description: Description The recently introduced Finding Validation should also be applied in the integration tests. This can simply be implemented by setting an environment variable which is evaluated in the parser sdk and makes the scanner crash if the findings are invalid. Checklist Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests. Make sure npm test runs for the whole project. Make codeclimate checks happy

Open Graph Description: Description The recently introduced Finding Validation should also be applied in the integration tests. This can simply be implemented by setting an environment variable which is evaluated in the ...

X Description: Description The recently introduced Finding Validation should also be applied in the integration tests. This can simply be implemented by setting an environment variable which is evaluated in the ...

Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/603

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:89f3da3d-0b49-b4dd-9889-627aa97c04d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7FC:1E0AAF:4DA83CA:6A23C07:69780DD6
html-safe-noncec90f0af394a09445e667d7e4bbd5081d42abf6c49f60b215e2ee37550fd59af6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0ZDOjFFMEFBRjo0REE4M0NBOjZBMjNDMDc6Njk3ODBERDYiLCJ2aXNpdG9yX2lkIjoiMzA5NjE1NjA4NjIzOTQ5NzY4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd708b5c875ec49045c08e13279f17785798cfe6927fd5029ea1981cd972d3da2
hovercard-subject-tagpull_request:716513225
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/603/files
twitter:imagehttps://avatars.githubusercontent.com/u/28805778?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/28805778?s=400&v=4
og:image:altDescription The recently introduced Finding Validation should also be applied in the integration tests. This can simply be implemented by setting an environment variable which is evaluated in the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee71ed39771d00f42ce2fc9320895c8c608c164191e118eae487fc3bd0af6886d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git
octolytics-dimension-user_id34573705
octolytics-dimension-user_loginsecureCodeBox
octolytics-dimension-repository_id80711933
octolytics-dimension-repository_nwosecureCodeBox/secureCodeBox
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id80711933
octolytics-dimension-repository_network_root_nwosecureCodeBox/secureCodeBox
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4919f24054c1e9bf76d7b543cb2ac018075b18ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/secureCodeBox/secureCodeBox/pull/603/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FsecureCodeBox%2FsecureCodeBox%2Fpull%2F603%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FsecureCodeBox%2FsecureCodeBox%2Fpull%2F603%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=secureCodeBox%2FsecureCodeBox
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/603/files
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/603/files
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/603/files
secureCodeBox https://github.com/secureCodeBox
secureCodeBoxhttps://github.com/secureCodeBox/secureCodeBox
Notifications https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Fork 177 https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Star 949 https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Code https://github.com/secureCodeBox/secureCodeBox
Issues 72 https://github.com/secureCodeBox/secureCodeBox/issues
Pull requests 3 https://github.com/secureCodeBox/secureCodeBox/pulls
Discussions https://github.com/secureCodeBox/secureCodeBox/discussions
Actions https://github.com/secureCodeBox/secureCodeBox/actions
Projects 1 https://github.com/secureCodeBox/secureCodeBox/projects
Security 1 https://github.com/secureCodeBox/secureCodeBox/security
Insights https://github.com/secureCodeBox/secureCodeBox/pulse
Code https://github.com/secureCodeBox/secureCodeBox
Issues https://github.com/secureCodeBox/secureCodeBox/issues
Pull requests https://github.com/secureCodeBox/secureCodeBox/pulls
Discussions https://github.com/secureCodeBox/secureCodeBox/discussions
Actions https://github.com/secureCodeBox/secureCodeBox/actions
Projects https://github.com/secureCodeBox/secureCodeBox/projects
Security https://github.com/secureCodeBox/secureCodeBox/security
Insights https://github.com/secureCodeBox/secureCodeBox/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FsecureCodeBox%2FsecureCodeBox%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox%2Fissues%2Fnew%2Fchoose
Weltraumschafhttps://github.com/Weltraumschaf
mainhttps://github.com/secureCodeBox/secureCodeBox/tree/main
feature/validate-findings-integration-testshttps://github.com/secureCodeBox/secureCodeBox/tree/feature/validate-findings-integration-tests
Conversation 1 https://github.com/secureCodeBox/secureCodeBox/pull/603
Commits 12 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits
Checks 0 https://github.com/secureCodeBox/secureCodeBox/pull/603/checks
Files changed https://github.com/secureCodeBox/secureCodeBox/pull/603/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/603/files
Ensure Findings are validated in Integration Tests (closes #546) https://github.com/secureCodeBox/secureCodeBox/pull/603/files#top
Show all changes 12 commits https://github.com/secureCodeBox/secureCodeBox/pull/603/files
c946711 add env variable to crash on failed validation JohannesZahn Aug 20, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/c9467115e66b8ed6fe8bd34227ed92c4f3c0750a
d703be1 log crash on failed validation envb variable JohannesZahn Aug 20, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/d703be1489d20332c33f8c72752a44c8093b7a51
d0b54ab Revert "add env variable to crash on failed validation" JohannesZahn Aug 20, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/d0b54abecfa9530344cc434f97a64efe79a40f2d
cf2d130 add crash on failed validation to parse definition in CI JohannesZahn Aug 20, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/cf2d130539afebeb731f1db31741c5f820c0b622
6145e05 use test scan to make sure invalid findings make tests fail JohannesZahn Aug 23, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/6145e05d2c9396168dcc529fd50e2e50ee69eb4c
0d67530 fix code climate issues JohannesZahn Aug 23, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/0d67530ba4d66932b121bc2192a00b5bca6a9e04
ea448d2 copy findings schema to docker container JohannesZahn Aug 23, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/ea448d24b23d74d8de670a05650c6a3d6b0f079d
858d89c validate the findings with ids and dates JohannesZahn Aug 24, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/858d89c835a0cd452b2fc28b88b354660335c662
0722646 validate findings in all tests where scans are involved JohannesZahn Aug 24, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/072264608bac564725b3430500a79d20d8a52d3c
33e0047 fix string formatting issues JohannesZahn Aug 24, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/33e0047c744a7dcc0a3acb90ffc617a2d1279ae6
56ab4c8 fix bug with invalid findings in test-scann JohannesZahn Aug 24, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/56ab4c800a655898ac1fe0429ef95094a0bef12d
cb1d9ce fix bug due to naming error JohannesZahn Aug 24, 2021 https://github.com/secureCodeBox/secureCodeBox/pull/603/commits/cb1d9ce910916e618a5ebd45897f1008296db41b
Clear filters https://github.com/secureCodeBox/secureCodeBox/pull/603/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/603/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/603/files
ci.yaml https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
Dockerfile https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-6b88c8dd242731b6e344459c64495e72f1a52cd0238d59cb355eecfe1af8e813
parser-wrapper.js https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-ac4cbbd2ef0f80d527d27930e625b0f27876efef146f4c480031b9bd2e0f4df5
parser.js https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-7e6ab9edebc858e029403fb073dcfdc7a2bf943a16464349ed5ac5ee288cd163
findings-validation.test.js https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-1592de90aad8b510073ddfb85ac05d0f41a4d4a66b197733059495c233b77f3d
.github/workflows/ci.yamlhttps://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
View file https://github.com/secureCodeBox/secureCodeBox/blob/cb1d9ce910916e618a5ebd45897f1008296db41b/.github/workflows/ci.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/603/{{ revealButtonHref }}
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
parser-sdk/nodejs/Dockerfilehttps://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-6b88c8dd242731b6e344459c64495e72f1a52cd0238d59cb355eecfe1af8e813
View file https://github.com/secureCodeBox/secureCodeBox/blob/cb1d9ce910916e618a5ebd45897f1008296db41b/parser-sdk/nodejs/Dockerfile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/603/{{ revealButtonHref }}
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-6b88c8dd242731b6e344459c64495e72f1a52cd0238d59cb355eecfe1af8e813
parser-sdk/nodejs/parser-wrapper.jshttps://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-ac4cbbd2ef0f80d527d27930e625b0f27876efef146f4c480031b9bd2e0f4df5
View file https://github.com/secureCodeBox/secureCodeBox/blob/cb1d9ce910916e618a5ebd45897f1008296db41b/parser-sdk/nodejs/parser-wrapper.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/603/{{ revealButtonHref }}
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-ac4cbbd2ef0f80d527d27930e625b0f27876efef146f4c480031b9bd2e0f4df5
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-ac4cbbd2ef0f80d527d27930e625b0f27876efef146f4c480031b9bd2e0f4df5
scanners/test-scan/parser/parser.jshttps://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-7e6ab9edebc858e029403fb073dcfdc7a2bf943a16464349ed5ac5ee288cd163
View file https://github.com/secureCodeBox/secureCodeBox/blob/cb1d9ce910916e618a5ebd45897f1008296db41b/scanners/test-scan/parser/parser.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/603/{{ revealButtonHref }}
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-7e6ab9edebc858e029403fb073dcfdc7a2bf943a16464349ed5ac5ee288cd163
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-7e6ab9edebc858e029403fb073dcfdc7a2bf943a16464349ed5ac5ee288cd163
https://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-7e6ab9edebc858e029403fb073dcfdc7a2bf943a16464349ed5ac5ee288cd163
tests/integration/generic/findings-validation.test.jshttps://github.com/secureCodeBox/secureCodeBox/pull/603/files#diff-1592de90aad8b510073ddfb85ac05d0f41a4d4a66b197733059495c233b77f3d
View file https://github.com/secureCodeBox/secureCodeBox/blob/cb1d9ce910916e618a5ebd45897f1008296db41b/tests/integration/generic/findings-validation.test.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/603/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.