Title: Introduce Makefile For All Scanners by EndPositive · Pull Request #601 · secureCodeBox/secureCodeBox · GitHub
Open Graph Title: Introduce Makefile For All Scanners by EndPositive · Pull Request #601 · secureCodeBox/secureCodeBox
X Title: Introduce Makefile For All Scanners by EndPositive · Pull Request #601 · secureCodeBox/secureCodeBox
Description: Description This PR continues @fuhrmeistery 's work on the scanner Makefiles. I have moved the Makefile for Amass into the project's root directory. From each scanner, we include the root Makefile and override configuration variables (such as scanner name) or whether a scanner container needs to be built. Each scanner can specify what demo target dependencies it has. https://github.com/EndPositive/secureCodeBox/blob/eec9b75edb70b347af1e47dcdbc7cb7e14562e2b/scanners/zap/Makefile#L8-L13 Finally, in this manner, we can also completely override the root makefile's behaviour. Zap-advanced's Makefile, for example, redirects the parser-related targets to zap's makefile. Kubeaudit overrides the helm deploy target such that it can set extra helm values. Checklist Reduce the amount of duplicated code in the makefiles by using 'some sort of inheritence' Adapt Makefile to add make targets for building custom/third party scanners Add unit tests for scanners (detect java/python) Replace CI amass job by Github Matrix / run them one by one in a single job (open for discussion; I believe kind cluster create is pretty expensive in the pipeline and a matrix job might explode that time..; on the other hand matrix would reduce oveall pipeline duration if the pipeline has enough resources) Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests. Make sure npm test runs for the whole project. Make codeclimate checks happy
Open Graph Description: Description This PR continues @fuhrmeistery 's work on the scanner Makefiles. I have moved the Makefile for Amass into the project's root directory. From each scanner, we include the root M...
X Description: Description This PR continues @fuhrmeistery 's work on the scanner Makefiles. I have moved the Makefile for Amass into the project's root directory. From each scanner, we include th...
Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/601
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:f10dc055-99b8-ec64-a716-600f18c15a46 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A3DE:383949:2F823AD:419F3C1:6977BEC5 |
| html-safe-nonce | 2137f7db27744179e2d82aa8ee9db5954925a2c832a16255e403a053703b8e8f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0RFOjM4Mzk0OToyRjgyM0FEOjQxOUYzQzE6Njk3N0JFQzUiLCJ2aXNpdG9yX2lkIjoiNjMyNTY3NTE0ODY3Nzk4ODAzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4bec51eda37b5e5e916617f25615dd5ad151d26f92c4899a4292b89c119c0f5e |
| hovercard-subject-tag | pull_request:715144164 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/601/checks |
| twitter:image | https://avatars.githubusercontent.com/u/25148195?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/25148195?s=400&v=4 |
| og:image:alt | Description This PR continues @fuhrmeistery 's work on the scanner Makefiles. I have moved the Makefile for Amass into the project's root directory. From each scanner, we include the root M... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | dd7783bd9901db88bac6bc215af7f020bc205a04ebc67e6c7def882ef2859ecd |
| turbo-cache-control | no-preview |
| go-import | github.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git |
| octolytics-dimension-user_id | 34573705 |
| octolytics-dimension-user_login | secureCodeBox |
| octolytics-dimension-repository_id | 80711933 |
| octolytics-dimension-repository_nwo | secureCodeBox/secureCodeBox |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 80711933 |
| octolytics-dimension-repository_network_root_nwo | secureCodeBox/secureCodeBox |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5d30081a77a5d66860584073cb38fd98fd7f9388 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width