René's URL Explorer Experiment


Title: Fix Duplicate Env Vars Added To Hook Kubernetes Job by J12934 · Pull Request #2779 · secureCodeBox/secureCodeBox · GitHub

Open Graph Title: Fix Duplicate Env Vars Added To Hook Kubernetes Job by J12934 · Pull Request #2779 · secureCodeBox/secureCodeBox

X Title: Fix Duplicate Env Vars Added To Hook Kubernetes Job by J12934 · Pull Request #2779 · secureCodeBox/secureCodeBox

Description: Description Encountered an issue while using kueue, which considers duplicate env vars to be a error in the job definition, even though kubernetes can handle it (this is why we haven't noticed it yet) Checklist Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests. Make sure that all your commits are signed-off and that you are added to the Contributors file. Make sure that all CI finish successfully. Optional (but appreciated): Make sure that all commits are Verified.

Open Graph Description: Description Encountered an issue while using kueue, which considers duplicate env vars to be a error in the job definition, even though kubernetes can handle it (this is why we haven't noticed ...

X Description: Description Encountered an issue while using kueue, which considers duplicate env vars to be a error in the job definition, even though kubernetes can handle it (this is why we haven't noti...

Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/2779

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3659518d-9fdd-3169-2edd-4c2f81f56330
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB570:128FE7:1239137:1749859:6990CFD1
html-safe-nonce2cada7a097e925546d8b107fdbbce29f5e6e068b8ea1db2b53286329134c5148
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTcwOjEyOEZFNzoxMjM5MTM3OjE3NDk4NTk6Njk5MENGRDEiLCJ2aXNpdG9yX2lkIjoiODQ5MjQwMDMwMTcwNTMxODM1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfa709c239c44f3935e71b69102ed2ec9e5dcd1b7818037627655009dca20919b
hovercard-subject-tagpull_request:2194999234
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/2779/files
twitter:imagehttps://avatars.githubusercontent.com/u/13718901?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13718901?s=400&v=4
og:image:altDescription Encountered an issue while using kueue, which considers duplicate env vars to be a error in the job definition, even though kubernetes can handle it (this is why we haven't noticed ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git
octolytics-dimension-user_id34573705
octolytics-dimension-user_loginsecureCodeBox
octolytics-dimension-repository_id80711933
octolytics-dimension-repository_nwosecureCodeBox/secureCodeBox
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id80711933
octolytics-dimension-repository_network_root_nwosecureCodeBox/secureCodeBox
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FsecureCodeBox%2FsecureCodeBox%2Fpull%2F2779%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FsecureCodeBox%2FsecureCodeBox%2Fpull%2F2779%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=secureCodeBox%2FsecureCodeBox
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files
Reloadhttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files
secureCodeBox https://github.com/secureCodeBox
secureCodeBoxhttps://github.com/secureCodeBox/secureCodeBox
Notifications https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Fork 179 https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Star 955 https://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox
Code https://github.com/secureCodeBox/secureCodeBox
Issues 71 https://github.com/secureCodeBox/secureCodeBox/issues
Pull requests 5 https://github.com/secureCodeBox/secureCodeBox/pulls
Discussions https://github.com/secureCodeBox/secureCodeBox/discussions
Actions https://github.com/secureCodeBox/secureCodeBox/actions
Projects 1 https://github.com/secureCodeBox/secureCodeBox/projects
Security 1 https://github.com/secureCodeBox/secureCodeBox/security
Insights https://github.com/secureCodeBox/secureCodeBox/pulse
Code https://github.com/secureCodeBox/secureCodeBox
Issues https://github.com/secureCodeBox/secureCodeBox/issues
Pull requests https://github.com/secureCodeBox/secureCodeBox/pulls
Discussions https://github.com/secureCodeBox/secureCodeBox/discussions
Actions https://github.com/secureCodeBox/secureCodeBox/actions
Projects https://github.com/secureCodeBox/secureCodeBox/projects
Security https://github.com/secureCodeBox/secureCodeBox/security
Insights https://github.com/secureCodeBox/secureCodeBox/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FsecureCodeBox%2FsecureCodeBox%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FsecureCodeBox%2FsecureCodeBox%2Fissues%2Fnew%2Fchoose
Ilyesbdlalahttps://github.com/Ilyesbdlala
secureCodeBox:mainhttps://github.com/secureCodeBox/secureCodeBox/tree/main
J12934:bugfix/fix-duplicate-env-vars-for-hookshttps://github.com/J12934/secureCodeBox/tree/bugfix/fix-duplicate-env-vars-for-hooks
Conversation 3 https://github.com/secureCodeBox/secureCodeBox/pull/2779
Commits 5 https://github.com/secureCodeBox/secureCodeBox/pull/2779/commits
Checks 0 https://github.com/secureCodeBox/secureCodeBox/pull/2779/checks
Files changed https://github.com/secureCodeBox/secureCodeBox/pull/2779/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files
Fix Duplicate Env Vars Added To Hook Kubernetes Job https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#top
Show all changes 5 commits https://github.com/secureCodeBox/secureCodeBox/pull/2779/files
cab3ec3 Split job generation to be better testable J12934 Nov 22, 2024 https://github.com/secureCodeBox/secureCodeBox/pull/2779/commits/cab3ec308b1682cd2f74ce188c9717cd6c3335b0
0a89f0f Add (failing) test for env var generation J12934 Nov 22, 2024 https://github.com/secureCodeBox/secureCodeBox/pull/2779/commits/0a89f0f5375daa504be70e8fe3cf99cd422ed413
090ebe9 Remove default env vars from tests J12934 Nov 22, 2024 https://github.com/secureCodeBox/secureCodeBox/pull/2779/commits/090ebe99dcfedd1899f2a8dce692c5e5182d3bd8
28e4aa5 Remove duplicated env var addition J12934 Nov 22, 2024 https://github.com/secureCodeBox/secureCodeBox/pull/2779/commits/28e4aa560e2e0c84f90f7c5e80b52a8c2bc3b745
9284f38 Add stupid copy right header J12934 Nov 22, 2024 https://github.com/secureCodeBox/secureCodeBox/pull/2779/commits/9284f38f9b01ffb2515f37800e94767203601d44
Clear filters https://github.com/secureCodeBox/secureCodeBox/pull/2779/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files
Please reload this pagehttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files
hook_reconciler.go https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
hook_reconciler_test.go https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-70184f11298586ea5870a60cd2b048f29f7aa04e6d5d001b9c51828883d72016
operator/controllers/execution/scans/hook_reconciler.gohttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
View file https://github.com/J12934/secureCodeBox/blob/9284f38f9b01ffb2515f37800e94767203601d44/operator/controllers/execution/scans/hook_reconciler.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/2779/{{ revealButtonHref }}
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
https://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-f43dff3789e31c71131d682c7a51510834f86c8f968296bd8408928f4b41fbbd
operator/controllers/execution/scans/hook_reconciler_test.gohttps://github.com/secureCodeBox/secureCodeBox/pull/2779/files#diff-70184f11298586ea5870a60cd2b048f29f7aa04e6d5d001b9c51828883d72016
View file https://github.com/J12934/secureCodeBox/blob/9284f38f9b01ffb2515f37800e94767203601d44/operator/controllers/execution/scans/hook_reconciler_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/secureCodeBox/secureCodeBox/pull/2779/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.