Title: Create zap config map even when config is empty by the-simmon · Pull Request #1289 · secureCodeBox/secureCodeBox · GitHub
Open Graph Title: Create zap config map even when config is empty by the-simmon · Pull Request #1289 · secureCodeBox/secureCodeBox
X Title: Create zap config map even when config is empty by the-simmon · Pull Request #1289 · secureCodeBox/secureCodeBox
Description: Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap though. secureCodeBox/scanners/zap-advanced/templates/zap-advanced-scan-type.yaml Lines 6 to 16 in bfd6c45 {{- if not (empty .Values.zapConfiguration) }} kind: ConfigMap apiVersion: v1 metadata: name: zap-advanced-scantype-config labels: {{- include "zap.labels" . | nindent 4 }} data: 1-zap-advanced-scantype.yaml: | {{- .Values.zapConfiguration | toYaml | nindent 4 -}} {{- end }} secureCodeBox/scanners/zap-advanced/values.yaml Lines 68 to 84 in bfd6c45 extraVolumes: - name: zap-advanced-scantype-config configMap: name: zap-advanced-scantype-config - name: zap-scripts-authentication configMap: name: zap-scripts-authentication - name: zap-scripts-session configMap: name: zap-scripts-session # scanner.extraVolumeMounts -- Optional VolumeMounts mapped into each scanJob (see: https://kubernetes.io/docs/concepts/storage/volumes/) extraVolumeMounts: - name: zap-advanced-scantype-config mountPath: /home/securecodebox/configs/1-zap-advanced-scantype.yaml subPath: 1-zap-advanced-scantype.yaml readOnly: true This mean that the tutorial on our website does not work, as it does not create the zap-advanced-scantype-config configmap manually. It fails with the following error: MountVolume.SetUp failed for volume "zap-advanced-scantype-config" : configmap "zap-advanced-scantype-config" not found. This PR will change this behavior. Zap-advanded will create an empty zap-advanced-scantype-config configmap if no zapConfiguration is provided to ensure that the mounting of the volume works.
Open Graph Description: Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap...
X Description: Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap...
Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/1289
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d7ceb7da-d631-e2c3-623e-160ec5f1c824 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A990:1205A7:16658D:1EC866:698F4189 |
| html-safe-nonce | 57ab5fc6fefe36b8e99ea86803fec5c29f108396bce252233e5db39c94134210 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTkwOjEyMDVBNzoxNjY1OEQ6MUVDODY2OjY5OEY0MTg5IiwidmlzaXRvcl9pZCI6IjYzMjU2MzA2Nzg1ODgxNDYwNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4b8fb10ea65eb83c25606fd6635d4219679aaaa306f74fa0c04c6d4e4de80dd6 |
| hovercard-subject-tag | pull_request:1009707447 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/1289/files |
| twitter:image | https://avatars.githubusercontent.com/u/41528189?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/41528189?s=400&v=4 |
| og:image:alt | Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6102991c714c1a6a27d05fb4f96ea6ca87a6750b4f093b95cc57ed1b84b145a1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git |
| octolytics-dimension-user_id | 34573705 |
| octolytics-dimension-user_login | secureCodeBox |
| octolytics-dimension-repository_id | 80711933 |
| octolytics-dimension-repository_nwo | secureCodeBox/secureCodeBox |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 80711933 |
| octolytics-dimension-repository_network_root_nwo | secureCodeBox/secureCodeBox |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d6ba6f2bfbf6399a7c07495a912727369e95bfe8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width