Title: Create zap config map even when config is empty by the-simmon · Pull Request #1289 · secureCodeBox/secureCodeBox · GitHub
Open Graph Title: Create zap config map even when config is empty by the-simmon · Pull Request #1289 · secureCodeBox/secureCodeBox
X Title: Create zap config map even when config is empty by the-simmon · Pull Request #1289 · secureCodeBox/secureCodeBox
Description: Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap though. secureCodeBox/scanners/zap-advanced/templates/zap-advanced-scan-type.yaml Lines 6 to 16 in bfd6c45 {{- if not (empty .Values.zapConfiguration) }} kind: ConfigMap apiVersion: v1 metadata: name: zap-advanced-scantype-config labels: {{- include "zap.labels" . | nindent 4 }} data: 1-zap-advanced-scantype.yaml: | {{- .Values.zapConfiguration | toYaml | nindent 4 -}} {{- end }} secureCodeBox/scanners/zap-advanced/values.yaml Lines 68 to 84 in bfd6c45 extraVolumes: - name: zap-advanced-scantype-config configMap: name: zap-advanced-scantype-config - name: zap-scripts-authentication configMap: name: zap-scripts-authentication - name: zap-scripts-session configMap: name: zap-scripts-session # scanner.extraVolumeMounts -- Optional VolumeMounts mapped into each scanJob (see: https://kubernetes.io/docs/concepts/storage/volumes/) extraVolumeMounts: - name: zap-advanced-scantype-config mountPath: /home/securecodebox/configs/1-zap-advanced-scantype.yaml subPath: 1-zap-advanced-scantype.yaml readOnly: true This mean that the tutorial on our website does not work, as it does not create the zap-advanced-scantype-config configmap manually. It fails with the following error: MountVolume.SetUp failed for volume "zap-advanced-scantype-config" : configmap "zap-advanced-scantype-config" not found. This PR will change this behavior. Zap-advanded will create an empty zap-advanced-scantype-config configmap if no zapConfiguration is provided to ensure that the mounting of the volume works.
Open Graph Description: Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap...
X Description: Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap...
Opengraph URL: https://github.com/secureCodeBox/secureCodeBox/pull/1289
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:243beb8e-6377-ff89-973e-2989bbacfe74 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B4BE:6E28C:119F78D:17AC716:698F8414 |
| html-safe-nonce | 0c1b6816a44d01e54e205eb709690bdfafc365910f4d96d1530df0d74a08fd61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEJFOjZFMjhDOjExOUY3OEQ6MTdBQzcxNjo2OThGODQxNCIsInZpc2l0b3JfaWQiOiI4ODQwOTA4NTc2NzYxMjgzNjA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4db3da41eccc3c6f02be796886a1741f26d4645b5e49d18e75096e67c253dd0c |
| hovercard-subject-tag | pull_request:1009707447 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/secureCodeBox/secureCodeBox/pull/1289/checks |
| twitter:image | https://avatars.githubusercontent.com/u/41528189?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/41528189?s=400&v=4 |
| og:image:alt | Zap-advanced does not create the zap-advanced-scantype-config configmap when it is installed with default values (zapConfiguration is not set). Per default zap-advaned tries to mount this configmap... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4763146d672e989a41c6c0bd715790c0c59341d9f855508c8a3196e1e480b8f7 |
| turbo-cache-control | no-preview |
| go-import | github.com/secureCodeBox/secureCodeBox git https://github.com/secureCodeBox/secureCodeBox.git |
| octolytics-dimension-user_id | 34573705 |
| octolytics-dimension-user_login | secureCodeBox |
| octolytics-dimension-repository_id | 80711933 |
| octolytics-dimension-repository_nwo | secureCodeBox/secureCodeBox |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 80711933 |
| octolytics-dimension-repository_network_root_nwo | secureCodeBox/secureCodeBox |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 38243223a284e53debe5a0f476578cf4a0521de7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width