René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Make Inheritlabels apply to scans and not only pods","articleBody":"## 🐞 Bug report\r\n\u003c!--\r\nThank you for reporting an issue in our project 🙌\r\n\r\nBefore opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.\r\n--\u003e\r\n### Describe the bug\r\n\u003c!-- A clear and concise description of what the bug is. --\u003e\r\nDespite setting inheritLabels = false, the cascading Scans still include the parent scan's labels\r\nI'm using Grafana Tanka which relies on injecting a label \"tanka.dev/environment: \u003chash\u003e\"  in order to \"prune\" objects within an environment, if the scans inherit this label it will force an unwanted deletion of the cascading scans\r\n\r\n### Steps To Reproduce\r\nExecute any cascading scan with inheritlabels: false, I launched an nmap scan:\r\n```yaml\r\nspec:\r\n  cascades:\r\n    inheritLabels: false\r\n    matchExpressions:\r\n    - key: securecodebox.io/intensive\r\n      operator: In\r\n      values:\r\n      - light\r\n      - medium\r\n      - high\r\n    - key: securecodebox.io/invasive\r\n      operator: In\r\n      values:\r\n      - non-invasive\r\n      - invasive\r\n  parameters:\r\n  - scan.me\r\n  scanType: nmap\r\n\r\n```\r\nThe Scan objects that get created through cascades, include the original scan's  labels\r\n```yaml\r\napiVersion: execution.securecodebox.io/v1\r\nkind: Scan\r\nmetadata:\r\n  annotations:\r\n    cascading.securecodebox.io/chain: securecodebox-scanners-zap-https\r\n    cascading.securecodebox.io/matched-finding: 99652536-76a7-471e-afef-a5da7d79c62f\r\n    cascading.securecodebox.io/parent-scan: securecodebox-scanners-network\r\n    securecodebox.io/hook: cascading-scans\r\n  creationTimestamp: \"2021-09-29T00:18:17Z\"\r\n  finalizers:\r\n  - s3.storage.securecodebox.io\r\n  generateName: securecodebox-scanners-network-securecodebox-scanners-zap-https-\r\n  generation: 2\r\n  labels:\r\n    tanka.dev/environment: 6a2b816247aad89622120ae34db00790e8b0e49713341819\r\n  name: securecodebox-scanners-network-securecodebox-scanners-zap-6dmpw\r\n  namespace: nonprod-alldevopsservices\r\n  ownerReferences:\r\n  - apiVersion: execution.securecodebox.io/v1\r\n    blockOwnerDeletion: true\r\n    controller: true\r\n    kind: Scan\r\n    name: securecodebox-scanners-network\r\n    uid: 6069b242-e596-48a4-8e61-b52c38f8a02c\r\n  resourceVersion: \"497099\"\r\n  uid: 10d779f7-2fda-4bd7-ae49-0802af0e655e\r\nspec:\r\n  cascades:\r\n    matchExpressions:\r\n    - key: securecodebox.io/intensive\r\n      operator: In\r\n      values:\r\n      - light\r\n      - medium\r\n      - high\r\n    - key: securecodebox.io/invasive\r\n      operator: In\r\n      values:\r\n      - non-invasive\r\n      - invasive\r\n  parameters:\r\n  - -t\r\n  - https://scan.me\r\n  scanType: zap-advanced-scan\r\nstatus:\r\n  findingDownloadLink: ...\r\n  findings:\r\n    severities: {}\r\n  rawResultDownloadLink: ...\r\n  rawResultFile: zap-results.xml\r\n  rawResultType: zap-advanced-xml\r\n  state: Scanning\r\n```\r\n### Expected behavior\r\n\u003c!-- A clear and concise description of what you expected to happen. --\u003e\r\nNot the Scan nor the backing pod should inherit the parent scan's labels when inheritLabels: false. This isnt true for the Scan\r\n\r\n### System (please complete the following information):\r\n - secureCodeBox image: latest\r\n - helm chart: 3.1.1\r\n","author":{"url":"https://github.com/RixTmobilender","@type":"Person","name":"RixTmobilender"},"datePublished":"2021-09-29T00:37:26.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/683/secureCodeBox/issues/683"}