René's URL Explorer Experiment


Title: made FileWatcher threadsafe by adamralph · Pull Request #886 · scriptcs/scriptcs · GitHub

Open Graph Title: made FileWatcher threadsafe by adamralph · Pull Request #886 · scriptcs/scriptcs

X Title: made FileWatcher threadsafe by adamralph · Pull Request #886 · scriptcs/scriptcs

Description: The defect https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240428&defectInstanceId=1396798&mergedDefectId=96018 found by Coverity is actually a false positive since the locking was not in place to give public thread safety but only to guarantee correct implementation, given the internal timer thread, but reading the code, it was difficult to tell. I considered suppressing the warning but then I realised making the type threadsafe was actually a trivial change and removes ambiguity for the reader so I thought to go down that route instead.

Open Graph Description: The defect https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240428&defectInstanceId=1396798&mergedDefectId=96018 found by Coverity is actually a false positive sinc...

X Description: The defect https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240428&defectInstanceId=1396798&mergedDefectId=96018 found by Coverity is actually a false posit...

Opengraph URL: https://github.com/scriptcs/scriptcs/pull/886

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:85c4ad62-8bea-a7a2-f42e-8e2718d215a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC44:5537E:23EC72F:2F96AEB:6B004E26
html-safe-nonced39b09291b4391cef56410f1b253577993be6ad438ee46e4880d624a4091d32d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzQ0OjU1MzdFOjIzRUM3MkY6MkY5NkFFQjo2QjAwNEUyNiIsInZpc2l0b3JfaWQiOiIyNDc4OTM1OTg2OTQ4NTU4Mzc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc32ad60bc4349f28c0c8308cdc29bb0c135a75ccb366edf08cf01d028be4ec2d
hovercard-subject-tagpull_request:26785305
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/scriptcs/scriptcs/pull/886/files
twitter:imagehttps://avatars.githubusercontent.com/u/677704?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/677704?s=400&v=4
og:image:altThe defect https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240428&defectInstanceId=1396798&mergedDefectId=96018 found by Coverity is actually a false positive sinc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/scriptcs/scriptcs git https://github.com/scriptcs/scriptcs.git
octolytics-dimension-user_id3758046
octolytics-dimension-user_loginscriptcs
octolytics-dimension-repository_id8473240
octolytics-dimension-repository_nwoscriptcs/scriptcs
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8473240
octolytics-dimension-repository_network_root_nwoscriptcs/scriptcs
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/scriptcs/scriptcs/pull/886/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscriptcs%2Fscriptcs%2Fpull%2F886%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscriptcs%2Fscriptcs%2Fpull%2F886%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=scriptcs%2Fscriptcs
Reloadhttps://github.com/scriptcs/scriptcs/pull/886/files
Reloadhttps://github.com/scriptcs/scriptcs/pull/886/files
Reloadhttps://github.com/scriptcs/scriptcs/pull/886/files
scriptcshttps://github.com/scriptcs
scriptcshttps://github.com/scriptcs/scriptcs
Codehttps://github.com/scriptcs/scriptcs
Issues167 (167)https://github.com/scriptcs/scriptcs/issues
Pull requests2 (2)https://github.com/scriptcs/scriptcs/pulls
Actionshttps://github.com/scriptcs/scriptcs/actions
Projectshttps://github.com/scriptcs/scriptcs/projects
Wikihttps://github.com/scriptcs/scriptcs/wiki
Security and qualityhttps://github.com/scriptcs/scriptcs/security
Insightshttps://github.com/scriptcs/scriptcs/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fscriptcs%2Fscriptcs%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fscriptcs%2Fscriptcs%2Fissues%2Fnew%2Fchoose
khellanghttps://github.com/khellang
scriptcs:devhttps://github.com/scriptcs/scriptcs/tree/dev
Conversation 0 https://github.com/scriptcs/scriptcs/pull/886
Commits 2 https://github.com/scriptcs/scriptcs/pull/886/commits
Checks 0 https://github.com/scriptcs/scriptcs/pull/886/checks
Files changed https://github.com/scriptcs/scriptcs/pull/886/files
Please reload this pagehttps://github.com/scriptcs/scriptcs/pull/886/files
made FileWatcher threadsafe https://github.com/scriptcs/scriptcs/pull/886/files#top
Show all changes 2 commits https://github.com/scriptcs/scriptcs/pull/886/files
9627965 refactor: remove redundant initializer, make _timerLock readonly, mak… adamralph Jan 3, 2015 https://github.com/scriptcs/scriptcs/pull/886/commits/96279657701bc8bd414125ec90c4b28b3af5a499
86ec5fc refactor: made FileWatcher threadsafe adamralph Jan 3, 2015 https://github.com/scriptcs/scriptcs/pull/886/commits/86ec5fcbcbfc4d00e08456f42a2930bbb09e6137
Clear filters https://github.com/scriptcs/scriptcs/pull/886/files
Please reload this pagehttps://github.com/scriptcs/scriptcs/pull/886/files
Please reload this pagehttps://github.com/scriptcs/scriptcs/pull/886/files
src/ScriptCs/Command/FileWatcher.cshttps://github.com/scriptcs/scriptcs/pull/886/files#diff-918cd79e535ee4f27a997893cbaf36718124e0ede468080883ef9af7623df749
View file https://github.com/scriptcs/scriptcs/blob/86ec5fcbcbfc4d00e08456f42a2930bbb09e6137/src/ScriptCs/Command/FileWatcher.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scriptcs/scriptcs/pull/886/{{ revealButtonHref }}
https://github.com/scriptcs/scriptcs/pull/886/files#diff-918cd79e535ee4f27a997893cbaf36718124e0ede468080883ef9af7623df749
https://github.com/scriptcs/scriptcs/pull/886/files#diff-918cd79e535ee4f27a997893cbaf36718124e0ede468080883ef9af7623df749
https://github.com/scriptcs/scriptcs/pull/886/files#diff-918cd79e535ee4f27a997893cbaf36718124e0ede468080883ef9af7623df749
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.