Title: CommandFactory refactoring · Issue #939 · scriptcs/scriptcs · GitHub
Open Graph Title: CommandFactory refactoring · Issue #939 · scriptcs/scriptcs
X Title: CommandFactory refactoring · Issue #939 · scriptcs/scriptcs
Description: The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, in other cases not. This should be refact...
Open Graph Description: The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, i...
X Description: The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, i...
Opengraph URL: https://github.com/scriptcs/scriptcs/issues/939
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CommandFactory refactoring","articleBody":"The current implementation of the `CommandFactory` is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places `CompositeCommand` is returned, in other cases not.\n\nThis should be refactored such that there is an array of commands that each option can add to. Then if the array is one item, then only that item is returned, otherwise a `CompositeCommand` is returned with whatever commands were added.\n\nThis will make it easy to add new commands. \n\nIf there are issues with certain combinations, then those checks can happen against the final collection in a single place. \n","author":{"url":"https://github.com/glennblock","@type":"Person","name":"glennblock"},"datePublished":"2015-02-25T05:15:38Z","url":"https://github.com/scriptcs/scriptcs/issues/939"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ac5d3fd3-a422-0887-1e17-0e0ec1f8fde0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A390:22FAD4:C0AA23:1013FA9:6B004D8B |
| html-safe-nonce | f5d0044ecf96f058b9f7af6b13b801f3b63fecf3b59edf8d2e604123bc9a632b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzkwOjIyRkFENDpDMEFBMjM6MTAxM0ZBOTo2QjAwNEQ4QiIsInZpc2l0b3JfaWQiOiI1NjYxMjcyNTgzMDc3NjQ1NzA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8f8bf4b0bc41283fe394d133e5e033fa490c64cc291f9ebb22ee30ee0a8a7aac |
| hovercard-subject-tag | issue:58851799 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/scriptcs/scriptcs/939/issue_layout |
| twitter:image | https://opengraph.githubassets.com/85fbf40290ed74b2a0a0e3da39454a94bd9f27cbee67ddd267f55004554b974d/scriptcs/scriptcs/issues/939 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/85fbf40290ed74b2a0a0e3da39454a94bd9f27cbee67ddd267f55004554b974d/scriptcs/scriptcs/issues/939 |
| og:image:alt | The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | glennblock |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-preview |
| go-import | github.com/scriptcs/scriptcs git https://github.com/scriptcs/scriptcs.git |
| octolytics-dimension-user_id | 3758046 |
| octolytics-dimension-user_login | scriptcs |
| octolytics-dimension-repository_id | 8473240 |
| octolytics-dimension-repository_nwo | scriptcs/scriptcs |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 8473240 |
| octolytics-dimension-repository_network_root_nwo | scriptcs/scriptcs |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width