René's URL Explorer Experiment


Title: CommandFactory refactoring · Issue #939 · scriptcs/scriptcs · GitHub

Open Graph Title: CommandFactory refactoring · Issue #939 · scriptcs/scriptcs

X Title: CommandFactory refactoring · Issue #939 · scriptcs/scriptcs

Description: The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, in other cases not. This should be refact...

Open Graph Description: The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, i...

X Description: The current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, i...

Opengraph URL: https://github.com/scriptcs/scriptcs/issues/939

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CommandFactory refactoring","articleBody":"The current implementation of the `CommandFactory` is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places `CompositeCommand` is returned, in other cases not.\n\nThis should be refactored such that there is an array of commands that each option can add to. Then if the array is one item, then only that item is returned, otherwise a `CompositeCommand` is returned with whatever commands were added.\n\nThis will make it easy to add new commands. \n\nIf there are issues with certain combinations, then those checks can happen against the final collection in a single place. \n","author":{"url":"https://github.com/glennblock","@type":"Person","name":"glennblock"},"datePublished":"2015-02-25T05:15:38Z","url":"https://github.com/scriptcs/scriptcs/issues/939"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ac5d3fd3-a422-0887-1e17-0e0ec1f8fde0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA390:22FAD4:C0AA23:1013FA9:6B004D8B
html-safe-noncef5d0044ecf96f058b9f7af6b13b801f3b63fecf3b59edf8d2e604123bc9a632b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzkwOjIyRkFENDpDMEFBMjM6MTAxM0ZBOTo2QjAwNEQ4QiIsInZpc2l0b3JfaWQiOiI1NjYxMjcyNTgzMDc3NjQ1NzA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8f8bf4b0bc41283fe394d133e5e033fa490c64cc291f9ebb22ee30ee0a8a7aac
hovercard-subject-tagissue:58851799
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/scriptcs/scriptcs/939/issue_layout
twitter:imagehttps://opengraph.githubassets.com/85fbf40290ed74b2a0a0e3da39454a94bd9f27cbee67ddd267f55004554b974d/scriptcs/scriptcs/issues/939
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/85fbf40290ed74b2a0a0e3da39454a94bd9f27cbee67ddd267f55004554b974d/scriptcs/scriptcs/issues/939
og:image:altThe current implementation of the CommandFactory is hard to maintain / add new options. The logic is hard code to check for only certain combinations. In some places CompositeCommand is returned, i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameglennblock
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/scriptcs/scriptcs git https://github.com/scriptcs/scriptcs.git
octolytics-dimension-user_id3758046
octolytics-dimension-user_loginscriptcs
octolytics-dimension-repository_id8473240
octolytics-dimension-repository_nwoscriptcs/scriptcs
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id8473240
octolytics-dimension-repository_network_root_nwoscriptcs/scriptcs
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/scriptcs/scriptcs/issues/939#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscriptcs%2Fscriptcs%2Fissues%2F939
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscriptcs%2Fscriptcs%2Fissues%2F939
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=scriptcs%2Fscriptcs
Reloadhttps://github.com/scriptcs/scriptcs/issues/939
Reloadhttps://github.com/scriptcs/scriptcs/issues/939
Reloadhttps://github.com/scriptcs/scriptcs/issues/939
scriptcshttps://github.com/scriptcs
scriptcshttps://github.com/scriptcs/scriptcs
Codehttps://github.com/scriptcs/scriptcs
Issues167 (167)https://github.com/scriptcs/scriptcs/issues
Pull requests2 (2)https://github.com/scriptcs/scriptcs/pulls
Actionshttps://github.com/scriptcs/scriptcs/actions
Projectshttps://github.com/scriptcs/scriptcs/projects
Wikihttps://github.com/scriptcs/scriptcs/wiki
Security and qualityhttps://github.com/scriptcs/scriptcs/security
Insightshttps://github.com/scriptcs/scriptcs/insights
https://github.com/scriptcs/scriptcs
New issuehttps://github.com/login?return_to=https://github.com/scriptcs/scriptcs/issues/939
New issuehttps://github.com/login?return_to=https://github.com/scriptcs/scriptcs/issues/939
CommandFactory refactoringhttps://github.com/scriptcs/scriptcs/issues/939#top
https://github.com/glennblock
refactoringhttps://github.com/scriptcs/scriptcs/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com/glennblock
glennblockhttps://github.com/glennblock
on Feb 25, 2015https://github.com/scriptcs/scriptcs/issues/939#issue-58851799
glennblockhttps://github.com/glennblock
refactoringhttps://github.com/scriptcs/scriptcs/issues?q=state%3Aopen%20label%3A%22refactoring%22
on Feb 25, 2015https://github.com/scriptcs/scriptcs/issues/939#event-241481214
glennblockhttps://github.com/glennblock
on Feb 25, 2015https://github.com/scriptcs/scriptcs/issues/939#event-241481273
https://github.com/adamralph
adamralphhttps://github.com/adamralph
on Feb 25, 2015https://github.com/scriptcs/scriptcs/issues/939#issuecomment-76032690
#897https://github.com/scriptcs/scriptcs/issues/897
https://github.com/adamralph
adamralphhttps://github.com/adamralph
on Mar 5, 2015https://github.com/scriptcs/scriptcs/issues/939#issuecomment-77358574
#944https://github.com/scriptcs/scriptcs/pull/944
#897https://github.com/scriptcs/scriptcs/issues/897
Sign up for freehttps://github.com/signup?return_to=https://github.com/scriptcs/scriptcs/issues/939
Sign in to commenthttps://github.com/login?return_to=https://github.com/scriptcs/scriptcs/issues/939
glennblockhttps://github.com/glennblock
refactoringhttps://github.com/scriptcs/scriptcs/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.