Title: Bug in beta tokenizer · Issue #178 · scriptcoded/sql-highlight · GitHub
Open Graph Title: Bug in beta tokenizer · Issue #178 · scriptcoded/sql-highlight
X Title: Bug in beta tokenizer · Issue #178 · scriptcoded/sql-highlight
Description: Just looking at the code I think there is a bug here: https://github.com/scriptcoded/sql-highlight/blob/909c361424255f5af2a5e87b96dcd9e93e61123d/lib/index.js#L42C21-L42C21 This only matches litteral periods .. I assume that you meant to ...
Open Graph Description: Just looking at the code I think there is a bug here: https://github.com/scriptcoded/sql-highlight/blob/909c361424255f5af2a5e87b96dcd9e93e61123d/lib/index.js#L42C21-L42C21 This only matches littera...
X Description: Just looking at the code I think there is a bug here: https://github.com/scriptcoded/sql-highlight/blob/909c361424255f5af2a5e87b96dcd9e93e61123d/lib/index.js#L42C21-L42C21 This only matches littera...
Opengraph URL: https://github.com/scriptcoded/sql-highlight/issues/178
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug in beta tokenizer","articleBody":"Just looking at the code I think there is a bug here:\r\n\r\nhttps://github.com/scriptcoded/sql-highlight/blob/909c361424255f5af2a5e87b96dcd9e93e61123d/lib/index.js#L42C21-L42C21\r\n\r\nThis only matches litteral periods `.`. I assume that you meant to match any character `/(?\u003cunknown\u003e.+?)/`.\r\n\r\nWithout this change (now that it's using `.matchAll()`) anything in the input SQL string that does not match the regex will be removed from the results and not visible to the user. I assume that is undesired.\r\n\r\n(Also of note that this approach will at most match a single character in every `unknown` group match.)\r\n\r\nAnd a bit off topic, but I'm using this highlighter with a non-standard SQL flavor, which uses several additional keywords. These keywords will now be highlighted as identifiers. I hope the highlighting for those is not too disturbing. 😅","author":{"url":"https://github.com/Qtax","@type":"Person","name":"Qtax"},"datePublished":"2024-01-08T16:44:28.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/178/sql-highlight/issues/178"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e08de611-0d31-6a14-3340-a34ff711eba6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B8C0:2C85F2:167C63D:1DA859F:69815638 |
| html-safe-nonce | 855b0281ee98aef40ba1d94be187a95371a94c3dec09a44f25e5d32a05d63f27 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEMwOjJDODVGMjoxNjdDNjNEOjFEQTg1OUY6Njk4MTU2MzgiLCJ2aXNpdG9yX2lkIjoiODIzNTE4MDE5NTAyMDEwMTE3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6c653fe42eaa089867bd7b4f8727ca82494a53d83b54df893504c799323c40de |
| hovercard-subject-tag | issue:2070847689 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/scriptcoded/sql-highlight/178/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9154f595acc3ae0367368bbfe757548a2c53e3b2a7a5aa9d1dbed9fb174df04f/scriptcoded/sql-highlight/issues/178 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9154f595acc3ae0367368bbfe757548a2c53e3b2a7a5aa9d1dbed9fb174df04f/scriptcoded/sql-highlight/issues/178 |
| og:image:alt | Just looking at the code I think there is a bug here: https://github.com/scriptcoded/sql-highlight/blob/909c361424255f5af2a5e87b96dcd9e93e61123d/lib/index.js#L42C21-L42C21 This only matches littera... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Qtax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4950337b1ba782ed2a56c7fce41be1e928a0fe0880cbdec4c091dcf98c412664 |
| turbo-cache-control | no-preview |
| go-import | github.com/scriptcoded/sql-highlight git https://github.com/scriptcoded/sql-highlight.git |
| octolytics-dimension-user_id | 6452991 |
| octolytics-dimension-user_login | scriptcoded |
| octolytics-dimension-repository_id | 147309066 |
| octolytics-dimension-repository_nwo | scriptcoded/sql-highlight |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 147309066 |
| octolytics-dimension-repository_network_root_nwo | scriptcoded/sql-highlight |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a06489e04583bd8257bde76b6e0d20f2d10ca68d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width