Title: Added support for https oauth request using custom keystore file by athodis · Pull Request #333 · scribejava/scribejava · GitHub
Open Graph Title: Added support for https oauth request using custom keystore file by athodis · Pull Request #333 · scribejava/scribejava
X Title: Added support for https oauth request using custom keystore file by athodis · Pull Request #333 · scribejava/scribejava
Description: I figured it would be useful to have a subclass of the OAuthRequest (which I called HttpsOAuthRequest) that uses a connection of type HttpsURLConnection. The keystore file path of the trusted certificates that this connection instance will use, is specified in the constructor of the HttpsOAuthRequest. This way there is no need to import the trusted certificates in the default keystore of the JVM ({JRE_HOME/lib/cacerts}) in order to make the https connections. Just create a keyStore file with the trusted certificates needed (for instance using the keytool -import command), and pass the path of that file to the HttpsOAuthRequest constructor. Also, I have added a boolean to the constructor that controls if a new SSLSocketFactory will be created with the new HttpsOAuthRequest or not. If set to false, the new https connection will reuse a previously created SSLSocketFactory, if it exists (if it doesn't exist, a new one will be created). If set to true, a new SSLSocketFactory will be created for the new https connection.
Open Graph Description: I figured it would be useful to have a subclass of the OAuthRequest (which I called HttpsOAuthRequest) that uses a connection of type HttpsURLConnection. The keystore file path of the trusted cert...
X Description: I figured it would be useful to have a subclass of the OAuthRequest (which I called HttpsOAuthRequest) that uses a connection of type HttpsURLConnection. The keystore file path of the trusted cert...
Opengraph URL: https://github.com/scribejava/scribejava/pull/333
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:417f0abb-5321-ce1c-b4f1-b89093c7d16f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9214:172993:10E2386:16ABC35:6A5AA88C |
| html-safe-nonce | b40b838b6099121a2dd7f9f16579075d79f23cfbc718900f0162717f1dd86cb1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjE0OjE3Mjk5MzoxMEUyMzg2OjE2QUJDMzU6NkE1QUE4OEMiLCJ2aXNpdG9yX2lkIjoiMTQwNzY2MjIxNDM1NDc0MTM4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36bf90e8549f141dab9c7242fd6a8224f46ff73bdfca6afded9a955765b26be9 |
| hovercard-subject-tag | pull_request:3245395 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/scribejava/scribejava/pull/333/files |
| twitter:image | https://avatars.githubusercontent.com/u/2931200?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2931200?s=400&v=4 |
| og:image:alt | I figured it would be useful to have a subclass of the OAuthRequest (which I called HttpsOAuthRequest) that uses a connection of type HttpsURLConnection. The keystore file path of the trusted cert... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 17a57ee6ab03686731c491fccb57e6a97c066a29d7cdf1a7d83c46f5c56684fc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/scribejava/scribejava git https://github.com/scribejava/scribejava.git |
| octolytics-dimension-user_id | 15140551 |
| octolytics-dimension-user_login | scribejava |
| octolytics-dimension-repository_id | 889932 |
| octolytics-dimension-repository_nwo | scribejava/scribejava |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 889932 |
| octolytics-dimension-repository_network_root_nwo | scribejava/scribejava |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5cb870aa6b86b87be75e23ca7caec54726a25af9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width