René's URL Explorer Experiment


Title: Apache HttpClient 5 integration by davidkron · Pull Request #1017 · scribejava/scribejava · GitHub

Open Graph Title: Apache HttpClient 5 integration by davidkron · Pull Request #1017 · scribejava/scribejava

X Title: Apache HttpClient 5 integration by davidkron · Pull Request #1017 · scribejava/scribejava

Description: Based on the ticket I created: #1016 I implemented this integration of Apache HttpClient 5.1 for Scribe. My code is more or less a copy of the existing HttpClient 4.x implementation (https://github.com/scribejava/scribejava/tree/master/scribejava-httpclient-apache) with the necessary modifications to dependencies and the package structure that changed with httpclient5. What I am not 100% sure about, is the whole asynchronous stuff from HttpClient as I primarily have experience with the synchronous API. The whole asynchronous API in HttpClient 5 doesn't seem to be using the same approach anymore as before with the HttpResponse containing also the HttpEntity/InputStream. But there are some compatibilty classes available, so that's why I choose to stay as close to the previous implementation as possible, especially since the Scribe API primarily is using InputStream. I used and tested the same implementation also in our project, but as I just implemented it, I don't yet have any experience over a longer period of usage.

Open Graph Description: Based on the ticket I created: #1016 I implemented this integration of Apache HttpClient 5.1 for Scribe. My code is more or less a copy of the existing HttpClient 4.x implementation (https://github...

X Description: Based on the ticket I created: #1016 I implemented this integration of Apache HttpClient 5.1 for Scribe. My code is more or less a copy of the existing HttpClient 4.x implementation (https://github...

Opengraph URL: https://github.com/scribejava/scribejava/pull/1017

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8794a077-54a9-7e34-c564-79f6066bf42b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC474:1B95DF:6593E9:8BAAC6:6AFCBAD9
html-safe-nonce66a9d2620a8ad043f9d143e7b2594575d3235674241864752b8e24aafb60a90a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDc0OjFCOTVERjo2NTkzRTk6OEJBQUM2OjZBRkNCQUQ5IiwidmlzaXRvcl9pZCI6Ijg3MjE4MzI3NzMxNjcxMzU0NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2f39cf74f14a242e3a3c390a6c7f2474cfaca12e3591dc7c63c6e087a0d366e2
hovercard-subject-tagpull_request:693771165
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/scribejava/scribejava/pull/1017/files
twitter:imagehttps://avatars.githubusercontent.com/u/3026417?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3026417?s=400&v=4
og:image:altBased on the ticket I created: #1016 I implemented this integration of Apache HttpClient 5.1 for Scribe. My code is more or less a copy of the existing HttpClient 4.x implementation (https://github...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee3084aead77cbcb4f4904fba53851fa1a0546b0dec3619bd250815e72588dc6d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/scribejava/scribejava git https://github.com/scribejava/scribejava.git
octolytics-dimension-user_id15140551
octolytics-dimension-user_loginscribejava
octolytics-dimension-repository_id889932
octolytics-dimension-repository_nwoscribejava/scribejava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id889932
octolytics-dimension-repository_network_root_nwoscribejava/scribejava
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5410e4bebd3e45b138c853ecef3992279d86d5af
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/scribejava/scribejava/pull/1017/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fpull%2F1017%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fpull%2F1017%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=scribejava%2Fscribejava
Reloadhttps://github.com/scribejava/scribejava/pull/1017/files
Reloadhttps://github.com/scribejava/scribejava/pull/1017/files
Reloadhttps://github.com/scribejava/scribejava/pull/1017/files
scribejavahttps://github.com/scribejava
scribejavahttps://github.com/scribejava/scribejava
Codehttps://github.com/scribejava/scribejava
Issues44 (44)https://github.com/scribejava/scribejava/issues
Pull requests32 (32)https://github.com/scribejava/scribejava/pulls
Actionshttps://github.com/scribejava/scribejava/actions
Projectshttps://github.com/scribejava/scribejava/projects
Wikihttps://github.com/scribejava/scribejava/wiki
Security and qualityhttps://github.com/scribejava/scribejava/security
Insightshttps://github.com/scribejava/scribejava/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fscribejava%2Fscribejava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fscribejava%2Fscribejava%2Fissues%2Fnew%2Fchoose
davidkronhttps://github.com/davidkron
scribejava:masterhttps://github.com/scribejava/scribejava/tree/master
davidkron:apache-httpclient5https://github.com/davidkron/scribejava/tree/apache-httpclient5
Conversation 4 https://github.com/scribejava/scribejava/pull/1017
Commits 1 https://github.com/scribejava/scribejava/pull/1017/commits
Checks 0 https://github.com/scribejava/scribejava/pull/1017/checks
Files changed https://github.com/scribejava/scribejava/pull/1017/files
Please reload this pagehttps://github.com/scribejava/scribejava/pull/1017/files
Apache HttpClient 5 integration https://github.com/scribejava/scribejava/pull/1017/files#top
Show all changes 1 commit https://github.com/scribejava/scribejava/pull/1017/files
a21d18f Apache HttpClient 5 integration davidkron Jul 20, 2021 https://github.com/scribejava/scribejava/pull/1017/commits/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3
Clear filters https://github.com/scribejava/scribejava/pull/1017/files
Please reload this pagehttps://github.com/scribejava/scribejava/pull/1017/files
Please reload this pagehttps://github.com/scribejava/scribejava/pull/1017/files
pom.xml https://github.com/scribejava/scribejava/pull/1017/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
pom.xml https://github.com/scribejava/scribejava/pull/1017/files#diff-ac44ade4114f909f8d74f05f26d656444aea95f06ae352116a81ef00c540817a
ApacheHttpClient5.java https://github.com/scribejava/scribejava/pull/1017/files#diff-124af1f4540891b1dbd14c8e1c4113c183994f6833011ba7f50dc74e116dae9d
ApacheHttpClient5Config.java https://github.com/scribejava/scribejava/pull/1017/files#diff-40735138d0561deae9551682e8922f25dfd20e7ca887593d6b63d36fa4566660
ApacheHttpClient5Provider.java https://github.com/scribejava/scribejava/pull/1017/files#diff-82658d22aacfb2ed2123ecb11ee0e1dcb372ba01fdbcdb08ceb832fe25e663ab
ApacheHttpFuture.java https://github.com/scribejava/scribejava/pull/1017/files#diff-7f462d50c4a384afd433d8768dee83dd77a898ac160a13d361259667b7ffaa56
AsyncHttpEntityConsumer.java https://github.com/scribejava/scribejava/pull/1017/files#diff-86fe1f30d4f7def225355802b379ac9b51c2e1e193470191fc6356d2c233a67d
OAuthAsyncCompletionHandler.java https://github.com/scribejava/scribejava/pull/1017/files#diff-10d834841498a03246b9c8fb4a9dc5c14c14e37b4fcc9d7c1b4bbcd8d9ad21e6
ResponseWithEntity.java https://github.com/scribejava/scribejava/pull/1017/files#diff-4a7280d96a09af9d353e35f9888120c7edf9340aeed589183dc1b3e836d6ab69
ResponseWithEntityConsumer.java https://github.com/scribejava/scribejava/pull/1017/files#diff-abe284399cdba37843a264426a33c36f3735c4aa149302b0f78f44541babbfac
com.github.scribejava.core.httpclient.HttpClientProvider https://github.com/scribejava/scribejava/pull/1017/files#diff-f810757e3089d49615c094a80360e2f47c13bbe9140018039d05a9b6fe3f79be
ApacheHttpClient5Test.java https://github.com/scribejava/scribejava/pull/1017/files#diff-298f4a3b03feb481e0d6a15197f91324ced04b87f6bc3f27c138a92d032d6d82
OAuthAsyncCompletionHandlerTest.java https://github.com/scribejava/scribejava/pull/1017/files#diff-a31c218b646339d9ec8ba86a5ad895729c149f5e6b736bfac0a7692ca3127d0d
pom.xmlhttps://github.com/scribejava/scribejava/pull/1017/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/pom.xml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
https://github.com/scribejava/scribejava/pull/1017/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
https://github.com/scribejava/scribejava/pull/1017/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
scribejava-httpclient-apache5/pom.xmlhttps://github.com/scribejava/scribejava/pull/1017/files#diff-ac44ade4114f909f8d74f05f26d656444aea95f06ae352116a81ef00c540817a
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/scribejava-httpclient-apache5/pom.xml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
...ent-apache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpClient5.javahttps://github.com/scribejava/scribejava/pull/1017/files#diff-124af1f4540891b1dbd14c8e1c4113c183994f6833011ba7f50dc74e116dae9d
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/scribejava-httpclient-apache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpClient5.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
...ache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpClient5Config.javahttps://github.com/scribejava/scribejava/pull/1017/files#diff-40735138d0561deae9551682e8922f25dfd20e7ca887593d6b63d36fa4566660
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/scribejava-httpclient-apache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpClient5Config.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
...he5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpClient5Provider.javahttps://github.com/scribejava/scribejava/pull/1017/files#diff-82658d22aacfb2ed2123ecb11ee0e1dcb372ba01fdbcdb08ceb832fe25e663ab
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/scribejava-httpclient-apache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpClient5Provider.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
...ient-apache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpFuture.javahttps://github.com/scribejava/scribejava/pull/1017/files#diff-7f462d50c4a384afd433d8768dee83dd77a898ac160a13d361259667b7ffaa56
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/scribejava-httpclient-apache5/src/main/java/com/github/scribejava/httpclient/apache5/ApacheHttpFuture.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
...ache5/src/main/java/com/github/scribejava/httpclient/apache5/AsyncHttpEntityConsumer.javahttps://github.com/scribejava/scribejava/pull/1017/files#diff-86fe1f30d4f7def225355802b379ac9b51c2e1e193470191fc6356d2c233a67d
View file https://github.com/scribejava/scribejava/blob/a21d18f1192c8a3f1a6439f2ec1b4230f1c34ce3/scribejava-httpclient-apache5/src/main/java/com/github/scribejava/httpclient/apache5/AsyncHttpEntityConsumer.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scribejava/scribejava/pull/1017/{{ revealButtonHref }}
Please reload this pagehttps://github.com/scribejava/scribejava/pull/1017/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.