René's URL Explorer Experiment


Title: Use better default Accept-header for JDKHttpClient · Issue #1042 · scribejava/scribejava · GitHub

Open Graph Title: Use better default Accept-header for JDKHttpClient · Issue #1042 · scribejava/scribejava

X Title: Use better default Accept-header for JDKHttpClient · Issue #1042 · scribejava/scribejava

Description: Currently the JDKHttpClient uses the following Accept header, if none is specified by the calling code: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2 As described in a JDK issue [1], this causes problems with several server side l...

Open Graph Description: Currently the JDKHttpClient uses the following Accept header, if none is specified by the calling code: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2 As described in a JDK issue [1], this ca...

X Description: Currently the JDKHttpClient uses the following Accept header, if none is specified by the calling code: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2 As described in a JDK issue [1], this ca...

Opengraph URL: https://github.com/scribejava/scribejava/issues/1042

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use better default Accept-header for JDKHttpClient","articleBody":"Currently the JDKHttpClient uses the following Accept header, if none is specified by the calling code: `text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2`\r\n\r\nAs described in a JDK issue [1], this causes problems with several server side libraries.\r\n\r\nI had problems to get the device authorization flow working with Keycloak due to this issue.\r\n\r\nWhat worked for me was extending OAuth20Service, and overriding the execute methods, and patching the request like that:\r\n`request.addHeader(\"Accept\", \"*/*\")`;\r\n\r\nThe accept header `*/*` is used per default by Postman and curl, so it seems to be a meaningful default - at least better than html, image and so on (afaik, scribejava is mostly dealing with JSON).\r\n\r\nI would suggest to change method `JDKHttpClient#prepareConnectionForBodyAndGetOutputStream` to set this meaningful default Accept header, if none has been already set. [2]\r\n\r\n[1] https://bugs.openjdk.org/browse/JDK-8163921\r\n[2] https://github.com/scribejava/scribejava/blob/49cf8a6f2a88b3c6398b6e7616bedc458f97c0e4/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.java#L224","author":{"url":"https://github.com/danielFesenmeyer","@type":"Person","name":"danielFesenmeyer"},"datePublished":"2022-06-30T16:31:32Z","url":"https://github.com/scribejava/scribejava/issues/1042"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5eb47605-5da2-8026-92dc-a2f185d604cd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDCAC:2A130F:B50812:100E015:6AFCB87A
html-safe-nonceb0ce60815cd7ee2214c4304df7ff98fda7ab4c673382380a9fdc1bee6ca0000a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0FDOjJBMTMwRjpCNTA4MTI6MTAwRTAxNTo2QUZDQjg3QSIsInZpc2l0b3JfaWQiOiI0NzYzNjYyOTMxMTg1MTU0MTcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbc18639a2fe1dc54eabc660101e37d9e2c7623796fb5dc7c1650fb75c71f5246
hovercard-subject-tagissue:1290384602
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/scribejava/scribejava/1042/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1eda2ce3c7e89c6e495c41a25f98c6d9c2f1d6aa1441e59cb2e1f4aad2b3db22/scribejava/scribejava/issues/1042
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1eda2ce3c7e89c6e495c41a25f98c6d9c2f1d6aa1441e59cb2e1f4aad2b3db22/scribejava/scribejava/issues/1042
og:image:altCurrently the JDKHttpClient uses the following Accept header, if none is specified by the calling code: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2 As described in a JDK issue [1], this ca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanielFesenmeyer
hostnamegithub.com
expected-hostnamegithub.com
Nonee3084aead77cbcb4f4904fba53851fa1a0546b0dec3619bd250815e72588dc6d
turbo-cache-controlno-preview
go-importgithub.com/scribejava/scribejava git https://github.com/scribejava/scribejava.git
octolytics-dimension-user_id15140551
octolytics-dimension-user_loginscribejava
octolytics-dimension-repository_id889932
octolytics-dimension-repository_nwoscribejava/scribejava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id889932
octolytics-dimension-repository_network_root_nwoscribejava/scribejava
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5410e4bebd3e45b138c853ecef3992279d86d5af
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/scribejava/scribejava/issues/1042#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fissues%2F1042
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fissues%2F1042
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=scribejava%2Fscribejava
Reloadhttps://github.com/scribejava/scribejava/issues/1042
Reloadhttps://github.com/scribejava/scribejava/issues/1042
Reloadhttps://github.com/scribejava/scribejava/issues/1042
scribejavahttps://github.com/scribejava
scribejavahttps://github.com/scribejava/scribejava
Codehttps://github.com/scribejava/scribejava
Issues44 (44)https://github.com/scribejava/scribejava/issues
Pull requests32 (32)https://github.com/scribejava/scribejava/pulls
Actionshttps://github.com/scribejava/scribejava/actions
Projectshttps://github.com/scribejava/scribejava/projects
Wikihttps://github.com/scribejava/scribejava/wiki
Security and qualityhttps://github.com/scribejava/scribejava/security
Insightshttps://github.com/scribejava/scribejava/insights
https://github.com/scribejava/scribejava
New issuehttps://github.com/login?return_to=https://github.com/scribejava/scribejava/issues/1042
New issuehttps://github.com/login?return_to=https://github.com/scribejava/scribejava/issues/1042
Use better default Accept-header for JDKHttpClienthttps://github.com/scribejava/scribejava/issues/1042#top
https://github.com/danielFesenmeyer
danielFesenmeyerhttps://github.com/danielFesenmeyer
on Jun 30, 2022https://github.com/scribejava/scribejava/issues/1042#issue-1290384602
https://bugs.openjdk.org/browse/JDK-8163921https://bugs.openjdk.org/browse/JDK-8163921
scribejava/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.javahttps://github.com/scribejava/scribejava/blob/49cf8a6f2a88b3c6398b6e7616bedc458f97c0e4/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.java#L224
49cf8a6https://github.com/scribejava/scribejava/commit/49cf8a6f2a88b3c6398b6e7616bedc458f97c0e4
Sign up for freehttps://github.com/signup?return_to=https://github.com/scribejava/scribejava/issues/1042
Sign in to commenthttps://github.com/login?return_to=https://github.com/scribejava/scribejava/issues/1042
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.