René's URL Explorer Experiment


Title: Device authorization codes request should include client_secret · Issue #1041 · scribejava/scribejava · GitHub

Open Graph Title: Device authorization codes request should include client_secret · Issue #1041 · scribejava/scribejava

X Title: Device authorization codes request should include client_secret · Issue #1041 · scribejava/scribejava

Description: Currently, the device authorization codes request does not include the client_secret parameter (aka apiKey). The OAuth 2.0 Device Grant RFC states [1]: The client authentication requirements of Section 3.2.1 of [RFC6749] apply to request...

Open Graph Description: Currently, the device authorization codes request does not include the client_secret parameter (aka apiKey). The OAuth 2.0 Device Grant RFC states [1]: The client authentication requirements of Sec...

X Description: Currently, the device authorization codes request does not include the client_secret parameter (aka apiKey). The OAuth 2.0 Device Grant RFC states [1]: The client authentication requirements of Sec...

Opengraph URL: https://github.com/scribejava/scribejava/issues/1041

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Device authorization codes request should include client_secret","articleBody":"Currently, the device authorization codes request does not include the client_secret parameter (aka apiKey).\r\n\r\nThe OAuth 2.0 Device Grant RFC states [1]:\r\n\r\n> The client authentication requirements of [Section 3.2.1 of [RFC6749]](https://datatracker.ietf.org/doc/html/rfc6749#section-3.2.1) apply to requests on this endpoint, which means that confidential clients (those that have established client credentials) authenticate in the same manner as when making requests to the token endpoint...\r\n\r\nHence, the method OAuth20Service#createDeviceAuthorizationCodesRequest(String) should not only set the client_id, but also the client_secret here [2].\r\nImho the line\r\n`request.addParameter(OAuthConstants.CLIENT_ID, getApiKey());`\r\nshould be replaced with:\r\n`api.getClientAuthentication().addClientAuthentication(request, getApiKey(), getApiSecret());`\r\n\r\nI observed this issue when trying to test device authorization with a confidential Keycloak client - I got a Keycloak response 401 with body:\r\n`{\"error\":\"unauthorized_client\",\"error_description\":\"Client secret not provided in request\"}`\r\n\r\n\r\n[1] https://datatracker.ietf.org/doc/html/rfc8628#section-3.1\r\n[2] https://github.com/scribejava/scribejava/blob/3a07d71f50b4f00bfda5fbae0eb765e612529ad9/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth20Service.java#L506","author":{"url":"https://github.com/danielFesenmeyer","@type":"Person","name":"danielFesenmeyer"},"datePublished":"2022-06-30T14:09:43Z","url":"https://github.com/scribejava/scribejava/issues/1041"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2bc7d90a-e8c0-8db3-6b5c-787a79bdb342
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD8FE:28C95D:A83A2D:F013BA:6AFCB84D
html-safe-nonce3760863f3ef5d0af1a020ce066c7732c3b0e21047edefb4da512408526b14c95
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEZFOjI4Qzk1RDpBODNBMkQ6RjAxM0JBOjZBRkNCODREIiwidmlzaXRvcl9pZCI6IjM3NTk2MTI4ODcyMDc1NTcxOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac56b722e38687e8b0773bed01e327c41fb66c7fbced9e07624f402077b483c342
hovercard-subject-tagissue:1290195135
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/scribejava/scribejava/1041/issue_layout
twitter:imagehttps://opengraph.githubassets.com/52ef7ffab2d0ba671e23e98f2856ebe5e21c0ca570722dac9710daa2db4fe5da/scribejava/scribejava/issues/1041
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52ef7ffab2d0ba671e23e98f2856ebe5e21c0ca570722dac9710daa2db4fe5da/scribejava/scribejava/issues/1041
og:image:altCurrently, the device authorization codes request does not include the client_secret parameter (aka apiKey). The OAuth 2.0 Device Grant RFC states [1]: The client authentication requirements of Sec...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanielFesenmeyer
hostnamegithub.com
expected-hostnamegithub.com
Nonee3084aead77cbcb4f4904fba53851fa1a0546b0dec3619bd250815e72588dc6d
turbo-cache-controlno-preview
go-importgithub.com/scribejava/scribejava git https://github.com/scribejava/scribejava.git
octolytics-dimension-user_id15140551
octolytics-dimension-user_loginscribejava
octolytics-dimension-repository_id889932
octolytics-dimension-repository_nwoscribejava/scribejava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id889932
octolytics-dimension-repository_network_root_nwoscribejava/scribejava
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5410e4bebd3e45b138c853ecef3992279d86d5af
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/scribejava/scribejava/issues/1041#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fissues%2F1041
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fissues%2F1041
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=scribejava%2Fscribejava
Reloadhttps://github.com/scribejava/scribejava/issues/1041
Reloadhttps://github.com/scribejava/scribejava/issues/1041
Reloadhttps://github.com/scribejava/scribejava/issues/1041
scribejavahttps://github.com/scribejava
scribejavahttps://github.com/scribejava/scribejava
Codehttps://github.com/scribejava/scribejava
Issues44 (44)https://github.com/scribejava/scribejava/issues
Pull requests32 (32)https://github.com/scribejava/scribejava/pulls
Actionshttps://github.com/scribejava/scribejava/actions
Projectshttps://github.com/scribejava/scribejava/projects
Wikihttps://github.com/scribejava/scribejava/wiki
Security and qualityhttps://github.com/scribejava/scribejava/security
Insightshttps://github.com/scribejava/scribejava/insights
https://github.com/scribejava/scribejava
New issuehttps://github.com/login?return_to=https://github.com/scribejava/scribejava/issues/1041
New issuehttps://github.com/login?return_to=https://github.com/scribejava/scribejava/issues/1041
Device authorization codes request should include client_secrethttps://github.com/scribejava/scribejava/issues/1041#top
https://github.com/danielFesenmeyer
danielFesenmeyerhttps://github.com/danielFesenmeyer
on Jun 30, 2022https://github.com/scribejava/scribejava/issues/1041#issue-1290195135
Section 3.2.1 of [RFC6749]https://datatracker.ietf.org/doc/html/rfc6749#section-3.2.1
https://datatracker.ietf.org/doc/html/rfc8628#section-3.1https://datatracker.ietf.org/doc/html/rfc8628#section-3.1
scribejava/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth20Service.javahttps://github.com/scribejava/scribejava/blob/3a07d71f50b4f00bfda5fbae0eb765e612529ad9/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth20Service.java#L506
3a07d71https://github.com/scribejava/scribejava/commit/3a07d71f50b4f00bfda5fbae0eb765e612529ad9
Sign up for freehttps://github.com/signup?return_to=https://github.com/scribejava/scribejava/issues/1041
Sign in to commenthttps://github.com/login?return_to=https://github.com/scribejava/scribejava/issues/1041
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.