René's URL Explorer Experiment


Title: engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava · GitHub

Open Graph Title: engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava

X Title: engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava

Description: This PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we convert Computers without that annoying copy at the end?? Background Suppose you want to convert a Computer into a Computer. Currently, you need (at a minimum): An engine.convert Op that transforms your A object into an I object. An engine.convert Op that transforms your B object into an O object. An engine.copy Op that puts the data from an O object into your B object or an engine.convert Op that transforms your O object into a B object and an engine.copy Op to put the data from the intermediary B object into the one you gave it. In many cases, however, those engine.convert Ops will be most performant when wrapping the object. If that wrapper is read/write (as is the case for ndarray -> RAI wrapping via imglyb, for example), when the Computer backing your Computer Op is called, the changes will be written through into the original B object, and the later engine.convert/engine.copy is unnecessary work. A new Op name: engine.wrap engine.wrap Ops are object conversions via a read/write wrapper. While not enforced, all engine.wrap Ops should be aliased engine.convert (and likely also convert.X). When performing conversion, the Op conversion MatchingRoutine will watch for the usage of engine.wrap Ops. If used for a preallocated output, the matching routine will avoid matching the output engine.convert/engine.copy Ops. In practice, this is a very simple change, as it is equivalent to the existing behavior that watches out for the engine.identity Op TODO: The proof of correctness here will be with inter-ComplexType image conversion, and as of right now the tests fail 😦. These tests must be fixed. Clean up PR (commits + code) Additional tests? Bump SciJava Ops Engine minor version, signifying new behavior.

Open Graph Description: This PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we...

X Description: This PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we...

Opengraph URL: https://github.com/scijava/scijava/pull/283

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:84257e3b-a673-17eb-67e1-6767b3274753
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8908:BAB60:2F22E92:3DF1625:696B8343
html-safe-nonce81e8e64d937f8e350f43570c7b3bdd76f06371c1f47187d76445e32a6ebb658c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTA4OkJBQjYwOjJGMjJFOTI6M0RGMTYyNTo2OTZCODM0MyIsInZpc2l0b3JfaWQiOiIyNjI0Mjg1ODMyMDY2NTk3Njk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdcfef33035e50666fa85850380ff10c7fd17bcfc6ae491670ef3df6d3c8169bb
hovercard-subject-tagpull_request:2327517605
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/scijava/scijava/pull/283/files
twitter:imagehttps://avatars.githubusercontent.com/u/29754838?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/29754838?s=400&v=4
og:image:altThis PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/scijava/scijava git https://github.com/scijava/scijava.git
octolytics-dimension-user_id1262770
octolytics-dimension-user_loginscijava
octolytics-dimension-repository_id85618439
octolytics-dimension-repository_nwoscijava/scijava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id85618439
octolytics-dimension-repository_network_root_nwoscijava/scijava
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/scijava/scijava/pull/283/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscijava%2Fscijava%2Fpull%2F283%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscijava%2Fscijava%2Fpull%2F283%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=scijava%2Fscijava
Reloadhttps://github.com/scijava/scijava/pull/283/files
Reloadhttps://github.com/scijava/scijava/pull/283/files
Reloadhttps://github.com/scijava/scijava/pull/283/files
scijava https://github.com/scijava
scijavahttps://github.com/scijava/scijava
Notifications https://github.com/login?return_to=%2Fscijava%2Fscijava
Fork 0 https://github.com/login?return_to=%2Fscijava%2Fscijava
Star 8 https://github.com/login?return_to=%2Fscijava%2Fscijava
Code https://github.com/scijava/scijava
Issues 63 https://github.com/scijava/scijava/issues
Pull requests 1 https://github.com/scijava/scijava/pulls
Actions https://github.com/scijava/scijava/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/scijava/scijava/security
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
Insights https://github.com/scijava/scijava/pulse
Code https://github.com/scijava/scijava
Issues https://github.com/scijava/scijava/issues
Pull requests https://github.com/scijava/scijava/pulls
Actions https://github.com/scijava/scijava/actions
Security https://github.com/scijava/scijava/security
Insights https://github.com/scijava/scijava/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fscijava%2Fscijava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fscijava%2Fscijava%2Fissues%2Fnew%2Fchoose
gselzerhttps://github.com/gselzer
mainhttps://github.com/scijava/scijava/tree/main
scijava-ops-image/view-rai-focusershttps://github.com/scijava/scijava/tree/scijava-ops-image/view-rai-focusers
Conversation 1 https://github.com/scijava/scijava/pull/283
Commits 3 https://github.com/scijava/scijava/pull/283/commits
Checks 1 https://github.com/scijava/scijava/pull/283/checks
Files changed https://github.com/scijava/scijava/pull/283/files
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
engine.wrap Ops https://github.com/scijava/scijava/pull/283/files#top
Show all changes 3 commits https://github.com/scijava/scijava/pull/283/files
0e7c585 WIP: Write wrapper focusers gselzer Mar 6, 2024 https://github.com/scijava/scijava/pull/283/commits/0e7c585fb4a97b15be08ab04948570f070617a8b
b6cde53 WIP: Create a suite of ComplexType RAI wrappers gselzer Mar 20, 2024 https://github.com/scijava/scijava/pull/283/commits/b6cde5345b5b65df7d656db397713d929057d1e2
ef0f1df BIG WIP: Engine.wrap + fixes gselzer Feb 11, 2025 https://github.com/scijava/scijava/pull/283/commits/ef0f1dfe093b83674d47b7320bb91e2aebab2ec6
Clear filters https://github.com/scijava/scijava/pull/283/files
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
Conversions.java https://github.com/scijava/scijava/pull/283/files#diff-811a8b23b26a1424e54d79851092e50be5309691c5e909f7698d41ac2422602a
ConvertedInfoTreeGenerator.java https://github.com/scijava/scijava/pull/283/files#diff-e296c05faf7ae7fae53af8656314b1de8ea960a9e3096997f208da314b6601d6
RuntimeSafeMatchingRoutine.java https://github.com/scijava/scijava/pull/283/files#diff-6fdf9488818f825052e59e82012146d0c044afa35cef160435593182fb06cabb
ConvertImages.java https://github.com/scijava/scijava/pull/283/files#diff-249ff2cf044ad10dd060d2cc3d929e6dd28f363fe5506267596b00654e5fe7f4
RAIWrappers.java https://github.com/scijava/scijava/pull/283/files#diff-9b5f5f378b1cef5de349ac4c9ec81482969e646c8cbf8e1c3ecdb1895e58f05d
ConvertImagesCorrectnessTest.java https://github.com/scijava/scijava/pull/283/files#diff-ee4baf5e547190abdb3fa38eed028a62a1e19df4766c45312f7dc15f146d67ff
RAIConvertersTest.java https://github.com/scijava/scijava/pull/283/files#diff-5038d75d12fe3430d7be53759dea6503a5e29468560a102313ee578e08120de2
TestConvertImages.java https://github.com/scijava/scijava/pull/283/files#diff-eab329591347a8350a369b328d1bb00419d5c533780b0a649838947e3577b6a5
RAIConvertersTest.vm https://github.com/scijava/scijava/pull/283/files#diff-ad9c69dbece89ce166444d1aa350ace7c32a28fb8ddf71aa0cef7f37af5db9e6
TestConvertImages.vm https://github.com/scijava/scijava/pull/283/files#diff-a1e9621132ddaad8b1fe0ede420f6e19fddb1a9629870239ce2d2dc2660f6859
scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/Conversions.javahttps://github.com/scijava/scijava/pull/283/files#diff-811a8b23b26a1424e54d79851092e50be5309691c5e909f7698d41ac2422602a
View file https://github.com/scijava/scijava/blob/ef0f1dfe093b83674d47b7320bb91e2aebab2ec6/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/Conversions.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scijava/scijava/pull/283/{{ revealButtonHref }}
https://github.com/scijava/scijava/pull/283/files#diff-811a8b23b26a1424e54d79851092e50be5309691c5e909f7698d41ac2422602a
https://github.com/scijava/scijava/pull/283/files#diff-811a8b23b26a1424e54d79851092e50be5309691c5e909f7698d41ac2422602a
...gine/src/main/java/org/scijava/ops/engine/matcher/convert/ConvertedInfoTreeGenerator.javahttps://github.com/scijava/scijava/pull/283/files#diff-e296c05faf7ae7fae53af8656314b1de8ea960a9e3096997f208da314b6601d6
View file https://github.com/scijava/scijava/blob/ef0f1dfe093b83674d47b7320bb91e2aebab2ec6/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/ConvertedInfoTreeGenerator.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scijava/scijava/pull/283/{{ revealButtonHref }}
https://github.com/scijava/scijava/pull/283/files#diff-e296c05faf7ae7fae53af8656314b1de8ea960a9e3096997f208da314b6601d6
https://github.com/scijava/scijava/pull/283/files#diff-e296c05faf7ae7fae53af8656314b1de8ea960a9e3096997f208da314b6601d6
...-engine/src/main/java/org/scijava/ops/engine/matcher/impl/RuntimeSafeMatchingRoutine.javahttps://github.com/scijava/scijava/pull/283/files#diff-6fdf9488818f825052e59e82012146d0c044afa35cef160435593182fb06cabb
View file https://github.com/scijava/scijava/blob/ef0f1dfe093b83674d47b7320bb91e2aebab2ec6/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/impl/RuntimeSafeMatchingRoutine.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/scijava/scijava/pull/283/{{ revealButtonHref }}
https://github.com/scijava/scijava/pull/283/files#diff-6fdf9488818f825052e59e82012146d0c044afa35cef160435593182fb06cabb
https://github.com/scijava/scijava/pull/283/files#diff-6fdf9488818f825052e59e82012146d0c044afa35cef160435593182fb06cabb
scijava-ops-image/src/main/java/org/scijava/ops/image/convert/ConvertImages.javahttps://github.com/scijava/scijava/pull/283/files#diff-249ff2cf044ad10dd060d2cc3d929e6dd28f363fe5506267596b00654e5fe7f4
View file https://github.com/scijava/scijava/blob/ef0f1dfe093b83674d47b7320bb91e2aebab2ec6/scijava-ops-image/src/main/java/org/scijava/ops/image/convert/ConvertImages.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
Please reload this pagehttps://github.com/scijava/scijava/pull/283/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.