René's URL Explorer Experiment

Title: engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava · GitHub

Open Graph Title: engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava

X Title: engine.wrap Ops by gselzer · Pull Request #283 · scijava/scijava

Description: This PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we convert Computers without that annoying copy at the end?? Background Suppose you want to convert a Computer into a Computer. Currently, you need (at a minimum): An engine.convert Op that transforms your A object into an I object. An engine.convert Op that transforms your B object into an O object. An engine.copy Op that puts the data from an O object into your B object or an engine.convert Op that transforms your O object into a B object and an engine.copy Op to put the data from the intermediary B object into the one you gave it. In many cases, however, those engine.convert Ops will be most performant when wrapping the object. If that wrapper is read/write (as is the case for ndarray -> RAI wrapping via imglyb, for example), when the Computer backing your Computer Op is called, the changes will be written through into the original B object, and the later engine.convert/engine.copy is unnecessary work. A new Op name: engine.wrap engine.wrap Ops are object conversions via a read/write wrapper. While not enforced, all engine.wrap Ops should be aliased engine.convert (and likely also convert.X). When performing conversion, the Op conversion MatchingRoutine will watch for the usage of engine.wrap Ops. If used for a preallocated output, the matching routine will avoid matching the output engine.convert/engine.copy Ops. In practice, this is a very simple change, as it is equivalent to the existing behavior that watches out for the engine.identity Op TODO: The proof of correctness here will be with inter-ComplexType image conversion, and as of right now the tests fail 😦. These tests must be fixed. Clean up PR (commits + code) Additional tests? Bump SciJava Ops Engine minor version, signifying new behavior.

Open Graph Description: This PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we...

X Description: This PR, based on a branch that was designed simply to streamline the conversion of RandomAccessibleIntervals via wrapping, has been taken over to add a new feature to Op conversion. Namely: Can we...

Opengraph URL: https://github.com/scijava/scijava/pull/283

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width