Title: No exception thrown for clashing adaptors · Issue #164 · scijava/scijava · GitHub
Open Graph Title: No exception thrown for clashing adaptors · Issue #164 · scijava/scijava
X Title: No exception thrown for clashing adaptors · Issue #164 · scijava/scijava
Description: The AdaptationMatchingRoutine currently short-circuits its search for candidates and returns the first viable adaptation. I don't think this is a problem, but it feels odd so I wanted to document it. You can test this with the LiftFuncti...
Open Graph Description: The AdaptationMatchingRoutine currently short-circuits its search for candidates and returns the first viable adaptation. I don't think this is a problem, but it feels odd so I wanted to document i...
X Description: The AdaptationMatchingRoutine currently short-circuits its search for candidates and returns the first viable adaptation. I don't think this is a problem, but it feels odd so I wanted to docume...
Opengraph URL: https://github.com/scijava/scijava/issues/164
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No exception thrown for clashing adaptors","articleBody":"The [AdaptationMatchingRoutine](https://github.com/scijava/incubator/blob/2917457c5fa549c95f0966b4913a13e318c3c227/scijava/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/adapt/AdaptationMatchingRoutine.java#L181) currently short-circuits its search for candidates and returns the first viable adaptation.\r\n\r\nI don't _think_ this is a problem, but it feels odd so I wanted to document it.\r\n\r\nYou can test this with the [LiftFunctionsToImgTest](https://github.com/scijava/incubator/blob/2917457c5fa549c95f0966b4913a13e318c3c227/imagej/imagej-ops2/src/test/java/net/imagej/ops2/adapt/LiftFunctionsToImgTest.java#L25-L40). It uses [this adaptor](https://github.com/scijava/incubator/blob/2917457c5fa549c95f0966b4913a13e318c3c227/imagej/imagej-ops2/src/main/java/net/imagej/ops2/adapt/LiftFunctionsToRAI.java#L74-L86) If you copy, paste, and rename that adaptor, the test will still pass.\r\n\r\nI'm wondering if anyone else can come up with situations where this will cause problems? I am slightly uncomfortable with the idea that we could have duplicate adaptors and not know it, the way we would with non-adaptor ops. But can't think of any functional problems.","author":{"url":"https://github.com/hinerm","@type":"Person","name":"hinerm"},"datePublished":"2023-12-12T19:18:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/164/scijava/issues/164"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a1e7fc68-0976-5f1c-6a2c-98477853f6d4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 842A:34D83D:6CDE25:90574A:696B48B1 |
| html-safe-nonce | ea015c38ac6cf7ef62451e37ad5d18e978535d75c659fe5cda53c8e893e60c42 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDJBOjM0RDgzRDo2Q0RFMjU6OTA1NzRBOjY5NkI0OEIxIiwidmlzaXRvcl9pZCI6IjkwMTY4ODMyMjY2NDYxMDQyNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2369a740ce6644787461764711ca9e0d5f8930feda7c11106bb809af1aa53ce7 |
| hovercard-subject-tag | issue:2038407470 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/scijava/scijava/164/issue_layout |
| twitter:image | https://opengraph.githubassets.com/96befb22f365008f39685ab126cf0c05a178db4196545945ccf55542d7423a84/scijava/scijava/issues/164 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/96befb22f365008f39685ab126cf0c05a178db4196545945ccf55542d7423a84/scijava/scijava/issues/164 |
| og:image:alt | The AdaptationMatchingRoutine currently short-circuits its search for candidates and returns the first viable adaptation. I don't think this is a problem, but it feels odd so I wanted to document i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hinerm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/scijava/scijava git https://github.com/scijava/scijava.git |
| octolytics-dimension-user_id | 1262770 |
| octolytics-dimension-user_login | scijava |
| octolytics-dimension-repository_id | 85618439 |
| octolytics-dimension-repository_nwo | scijava/scijava |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 85618439 |
| octolytics-dimension-repository_network_root_nwo | scijava/scijava |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width