René's URL Explorer Experiment


Title: Makes the reference types sound via a DST by akern40 · Pull Request #1532 · rust-ndarray/ndarray · GitHub

Open Graph Title: Makes the reference types sound via a DST by akern40 · Pull Request #1532 · rust-ndarray/ndarray

X Title: Makes the reference types sound via a DST by akern40 · Pull Request #1532 · rust-ndarray/ndarray

Description: ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations - Makes the reference types sound via a DST by akern40 · Pull Request #1532 · rust-ndarray/ndarray

Open Graph Description: The current implementation of ArrayRef and its cousins has them as sized types, which turns out to be a critical and unsound mistake. This PR is large, but its heart is small: change the ArrayRef i...

X Description: The current implementation of ArrayRef and its cousins has them as sized types, which turns out to be a critical and unsound mistake. This PR is large, but its heart is small: change the ArrayRef i...

Opengraph URL: https://github.com/rust-ndarray/ndarray/pull/1532

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6dbe125a-9572-7ad3-5414-896dc740fd6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE8A:3D0013:5F3124:87BDD2:6AFCA600
html-safe-nonce643a2605b9528effbc7989a6c9dcb19cc205f1a8e7802f77609f3081cb62a494
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRThBOjNEMDAxMzo1RjMxMjQ6ODdCREQyOjZBRkNBNjAwIiwidmlzaXRvcl9pZCI6Ijc1ODgyMDMyMDUwOTE5NjAzMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac034da8e5d88be03ebf58b517dce78b85dac5c5022b6825d525ed0829f355c692
hovercard-subject-tagpull_request:2926094589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rust-ndarray/ndarray/1532/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7ab89028fd947b0366e5cc24df8fd7a2080c44148066c81ff77d61387634de62/rust-ndarray/ndarray/pull/1532
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7ab89028fd947b0366e5cc24df8fd7a2080c44148066c81ff77d61387634de62/rust-ndarray/ndarray/pull/1532
og:image:altThe current implementation of ArrayRef and its cousins has them as sized types, which turns out to be a critical and unsound mistake. This PR is large, but its heart is small: change the ArrayRef i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameakern40
hostnamegithub.com
expected-hostnamegithub.com
Nonee3084aead77cbcb4f4904fba53851fa1a0546b0dec3619bd250815e72588dc6d
turbo-cache-controlno-cache
go-importgithub.com/rust-ndarray/ndarray git https://github.com/rust-ndarray/ndarray.git
octolytics-dimension-user_id44419403
octolytics-dimension-user_loginrust-ndarray
octolytics-dimension-repository_id22598813
octolytics-dimension-repository_nworust-ndarray/ndarray
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22598813
octolytics-dimension-repository_network_root_nworust-ndarray/ndarray
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5410e4bebd3e45b138c853ecef3992279d86d5af
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/rust-ndarray/ndarray/pull/1532#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1532
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1532
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rust-ndarray%2Fndarray
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1532
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1532
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1532
rust-ndarrayhttps://github.com/rust-ndarray
ndarrayhttps://github.com/rust-ndarray/ndarray
Codehttps://github.com/rust-ndarray/ndarray
Issues175 (175)https://github.com/rust-ndarray/ndarray/issues
Pull requests41 (41)https://github.com/rust-ndarray/ndarray/pulls
Discussionshttps://github.com/rust-ndarray/ndarray/discussions
Actionshttps://github.com/rust-ndarray/ndarray/actions
Projectshttps://github.com/rust-ndarray/ndarray/projects
Wikihttps://github.com/rust-ndarray/ndarray/wiki
Security and qualityhttps://github.com/rust-ndarray/ndarray/security
Insightshttps://github.com/rust-ndarray/ndarray/insights
https://github.com/rust-ndarray/ndarray
akern40https://github.com/akern40
rust-ndarray:masterhttps://github.com/rust-ndarray/ndarray/tree/master
akern40:sound-arrayref-via-dsthttps://github.com/akern40/ndarray/tree/sound-arrayref-via-dst
Conversationhttps://github.com/rust-ndarray/ndarray/pull/1532
Commits8 (8)https://github.com/rust-ndarray/ndarray/pull/1532/commits
Checkshttps://github.com/rust-ndarray/ndarray/pull/1532/checks
Files changedhttps://github.com/rust-ndarray/ndarray/pull/1532/files
Makes the reference types sound via a DSThttps://github.com/rust-ndarray/ndarray/pull/1532#top
akern40https://github.com/akern40
rust-ndarray:masterhttps://github.com/rust-ndarray/ndarray/tree/master
akern40:sound-arrayref-via-dsthttps://github.com/akern40/ndarray/tree/sound-arrayref-via-dst
https://github.com/akern40
akern40https://github.com/akern40
Oct 18, 2025https://github.com/rust-ndarray/ndarray/pull/1532#issue-3527991879
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
#1531https://github.com/rust-ndarray/ndarray/issues/1531
Rust type layouthttps://doc.rust-lang.org/beta/reference/type-layout.html
Rustonomicon on DSTshttps://doc.rust-lang.org/nomicon/exotic-sizes.html
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
akern40https://github.com/akern40
October 16, 2025 21:18https://github.com/rust-ndarray/ndarray/pull/1532#commits-pushed-e5277c0
https://github.com/akern40
Makes the reference types sound via a DST.https://github.com/rust-ndarray/ndarray/pull/1532/commits/e5277c0048b4746685e086e76e3934e1fcc6e79d
e5277c0https://github.com/rust-ndarray/ndarray/pull/1532/commits/e5277c0048b4746685e086e76e3934e1fcc6e79d
https://github.com/akern40
Make the ArrayParts struct private.https://github.com/rust-ndarray/ndarray/pull/1532/commits/fa65c45aea5bb5081045998657977bddaae0a2b2
fa65c45https://github.com/rust-ndarray/ndarray/pull/1532/commits/fa65c45aea5bb5081045998657977bddaae0a2b2
https://github.com/akern40
Add doc tests to test scripthttps://github.com/rust-ndarray/ndarray/pull/1532/commits/3380d941bf8f2cb2576d20f49eb004a61d6339e0
3380d94https://github.com/rust-ndarray/ndarray/pull/1532/commits/3380d941bf8f2cb2576d20f49eb004a61d6339e0
https://github.com/akern40
Remove the helper traits (for now) to make the diff smallerhttps://github.com/rust-ndarray/ndarray/pull/1532/commits/ac583c5e991412d30a5db6f2d6e92130a94b3276
ac583c5https://github.com/rust-ndarray/ndarray/pull/1532/commits/ac583c5e991412d30a5db6f2d6e92130a94b3276
https://github.com/akern40
Satisfy clippyhttps://github.com/rust-ndarray/ndarray/pull/1532/commits/b8ad7dcaebebd3e18d2c4800feef03036ce39fbe
b8ad7dchttps://github.com/rust-ndarray/ndarray/pull/1532/commits/b8ad7dcaebebd3e18d2c4800feef03036ce39fbe
https://github.com/akern40
Forgot config to enable bounds check for references on debughttps://github.com/rust-ndarray/ndarray/pull/1532/commits/f35e0354d923729839635b9087caf9d4708a25d3
f35e035https://github.com/rust-ndarray/ndarray/pull/1532/commits/f35e0354d923729839635b9087caf9d4708a25d3
https://github.com/akern40
Need to prefix variable that isn't used when debug assertions are tur…https://github.com/rust-ndarray/ndarray/pull/1532/commits/8364740de244ed2b268860904d264e32b5f8db72
8364740https://github.com/rust-ndarray/ndarray/pull/1532/commits/8364740de244ed2b268860904d264e32b5f8db72
https://github.com/akern40
akern40https://github.com/akern40
Oct 19, 2025 https://github.com/rust-ndarray/ndarray/pull/1532#pullrequestreview-3353923007
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1532/files/8364740de244ed2b268860904d264e32b5f8db72
src/lib.rshttps://github.com/rust-ndarray/ndarray/pull/1532/files/8364740de244ed2b268860904d264e32b5f8db72#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2442724463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
sarah-quinoneshttps://github.com/sarah-quinones
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2443461963
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2443508196
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2443553373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Unsized Coercionshttps://doc.rust-lang.org/reference/type-coercions.html#r-coerce.unsize
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
blusshttps://github.com/bluss
Oct 20, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2444180603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/akern40
Forgot repr(transparent) on LayoutRefhttps://github.com/rust-ndarray/ndarray/pull/1532/commits/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
c3c2cb3https://github.com/rust-ndarray/ndarray/pull/1532/commits/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
https://github.com/akern40
akern40https://github.com/akern40
Oct 19, 2025 https://github.com/rust-ndarray/ndarray/pull/1532#pullrequestreview-3353924748
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
src/lib.rshttps://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2442726729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
sarah-quinoneshttps://github.com/sarah-quinones
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2443462314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/akern40
akern40https://github.com/akern40
Oct 19, 2025 https://github.com/rust-ndarray/ndarray/pull/1532#pullrequestreview-3353925457
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
src/impl_ref_types.rshttps://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac#diff-b8df856993bae3c4bb058333a3403dec85bbb509fb4340928953c83248b5bdd9
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2442727586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/akern40
akern40https://github.com/akern40
October 19, 2025 02:35https://github.com/rust-ndarray/ndarray/pull/1532#event-20363389166
https://github.com/akern40
akern40https://github.com/akern40
blusshttps://github.com/bluss
October 19, 2025 02:35https://github.com/rust-ndarray/ndarray/pull/1532#event-20363389423
https://github.com/akern40
akern40https://github.com/akern40
Oct 19, 2025 https://github.com/rust-ndarray/ndarray/pull/1532#ref-issue-3519545321
Yanking 0.17.0 due to use-after-free unsoundness #1531 https://github.com/rust-ndarray/ndarray/issues/1531
https://github.com/akern40
akern40https://github.com/akern40
Oct 19, 2025 https://github.com/rust-ndarray/ndarray/pull/1532#pullrequestreview-3353926481
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
src/impl_ref_types.rshttps://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac#diff-b8df856993bae3c4bb058333a3403dec85bbb509fb4340928953c83248b5bdd9
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#discussion_r2442728832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/bluss
blusshttps://github.com/bluss
Oct 19, 2025 https://github.com/rust-ndarray/ndarray/pull/1532#pullrequestreview-3354614283
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
src/lib.rshttps://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/bluss
blusshttps://github.com/bluss
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#issuecomment-3419859201
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/sarah-quinones
sarah-quinoneshttps://github.com/sarah-quinones
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#issuecomment-3419910751
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/akern40
akern40https://github.com/akern40
Oct 19, 2025https://github.com/rust-ndarray/ndarray/pull/1532#issuecomment-3420059306
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/akern40
akern40https://github.com/akern40
a3b3537https://github.com/rust-ndarray/ndarray/commit/a3b3537788c799025fc7317a15869efbf7ec69e4
Oct 29, 2025https://github.com/rust-ndarray/ndarray/pull/1532#event-20568362062
https://github.com/akern40
akern40https://github.com/akern40
October 29, 2025 01:55https://github.com/rust-ndarray/ndarray/pull/1532#event-20568362845
https://github.com/SomeB1oody
SomeB1oodyhttps://github.com/SomeB1oody
Jul 19, 2026 https://github.com/rust-ndarray/ndarray/pull/1532#ref-pullrequest-4921438890
fix(docs): point section links at the pages that define their anchors #1606 https://github.com/rust-ndarray/ndarray/pull/1606
https://github.co/hiddenchars
https://github.com/rust-ndarray/ndarray/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1532
https://github.com/bluss
bluss https://github.com/bluss
https://github.com/rust-ndarray/ndarray/pull/1532/files/8364740de244ed2b268860904d264e32b5f8db72
https://github.com/sarah-quinones
sarah-quinones https://github.com/sarah-quinones
https://github.com/rust-ndarray/ndarray/pull/1532/files/c3c2cb3c9fbabdb3786a273ed9213cbb52fae1ac
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
Yanking 0.17.0 due to use-after-free unsoundness https://github.com/rust-ndarray/ndarray/issues/1531
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1532
https://github.com/akern40
https://github.com/bluss
https://github.com/sarah-quinones
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.