René's URL Explorer Experiment


Title: Make iterators covariant in element type by bluss · Pull Request #1417 · rust-ndarray/ndarray · GitHub

Open Graph Title: Make iterators covariant in element type by bluss · Pull Request #1417 · rust-ndarray/ndarray

X Title: Make iterators covariant in element type by bluss · Pull Request #1417 · rust-ndarray/ndarray

Description: The internal Baseiter type underlies most of the ndarray iterators, and it used *mut A for element type A. Update it to use NonNull which behaves identically except it's guaranteed to be non-nul...

Open Graph Description: The internal Baseiter type underlies most of the ndarray iterators, and it used *mut A for element type A. Update it to use NonNull<A> which behaves identically except it's guaranteed to ...

X Description: The internal Baseiter type underlies most of the ndarray iterators, and it used *mut A for element type A. Update it to use NonNull&lt;A&gt; which behaves identically except it&#39;s gu...

Opengraph URL: https://github.com/rust-ndarray/ndarray/pull/1417

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f54f937e-b698-0407-b05d-849e64eb07ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD86:16F07B:299856E:396F5A1:6964E028
html-safe-noncea950e8fd8ce40134eb13322b8aa1072a52dd9fc46721b83815a384e2778dbe47
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDg2OjE2RjA3QjoyOTk4NTZFOjM5NkY1QTE6Njk2NEUwMjgiLCJ2aXNpdG9yX2lkIjoiNTk2NjIwOTc4OTI3ODM0NzMwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f45a552d6306ca9bdfc78f8fa05f69a664d6ed625c46783401cc6300533442c
hovercard-subject-tagpull_request:2005711814
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rust-ndarray/ndarray/1417/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a5c9f6fc49f17598912205fe4a6009eb56395de34cfa260aa4ae85d26b62668/rust-ndarray/ndarray/pull/1417
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a5c9f6fc49f17598912205fe4a6009eb56395de34cfa260aa4ae85d26b62668/rust-ndarray/ndarray/pull/1417
og:image:altThe internal Baseiter type underlies most of the ndarray iterators, and it used *mut A for element type A. Update it to use NonNull<A> which behaves identically except it's guaranteed to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebluss
hostnamegithub.com
expected-hostnamegithub.com
None5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d
turbo-cache-controlno-preview
go-importgithub.com/rust-ndarray/ndarray git https://github.com/rust-ndarray/ndarray.git
octolytics-dimension-user_id44419403
octolytics-dimension-user_loginrust-ndarray
octolytics-dimension-repository_id22598813
octolytics-dimension-repository_nworust-ndarray/ndarray
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22598813
octolytics-dimension-repository_network_root_nworust-ndarray/ndarray
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8edad3509fd3b4374694551987974bbbcfd316c0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/rust-ndarray/ndarray/pull/1417#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1417
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1417
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rust-ndarray%2Fndarray
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1417
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1417
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1417
rust-ndarray https://github.com/rust-ndarray
ndarrayhttps://github.com/rust-ndarray/ndarray
Notifications https://github.com/login?return_to=%2Frust-ndarray%2Fndarray
Fork 360 https://github.com/login?return_to=%2Frust-ndarray%2Fndarray
Star 4.2k https://github.com/login?return_to=%2Frust-ndarray%2Fndarray
Code https://github.com/rust-ndarray/ndarray
Issues 172 https://github.com/rust-ndarray/ndarray/issues
Pull requests 34 https://github.com/rust-ndarray/ndarray/pulls
Discussions https://github.com/rust-ndarray/ndarray/discussions
Actions https://github.com/rust-ndarray/ndarray/actions
Projects 0 https://github.com/rust-ndarray/ndarray/projects
Wiki https://github.com/rust-ndarray/ndarray/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/rust-ndarray/ndarray/security
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1417
Insights https://github.com/rust-ndarray/ndarray/pulse
Code https://github.com/rust-ndarray/ndarray
Issues https://github.com/rust-ndarray/ndarray/issues
Pull requests https://github.com/rust-ndarray/ndarray/pulls
Discussions https://github.com/rust-ndarray/ndarray/discussions
Actions https://github.com/rust-ndarray/ndarray/actions
Projects https://github.com/rust-ndarray/ndarray/projects
Wiki https://github.com/rust-ndarray/ndarray/wiki
Security https://github.com/rust-ndarray/ndarray/security
Insights https://github.com/rust-ndarray/ndarray/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Frust-ndarray%2Fndarray%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Frust-ndarray%2Fndarray%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/rust-ndarray/ndarray/pull/1417#issue-comment-box
blusshttps://github.com/bluss
masterhttps://github.com/rust-ndarray/ndarray/tree/master
baseiter-covarianthttps://github.com/rust-ndarray/ndarray/tree/baseiter-covariant
Make iterators covariant in element type https://github.com/rust-ndarray/ndarray/pull/1417#top
blusshttps://github.com/bluss
masterhttps://github.com/rust-ndarray/ndarray/tree/master
baseiter-covarianthttps://github.com/rust-ndarray/ndarray/tree/baseiter-covariant
Conversation 1 https://github.com/rust-ndarray/ndarray/pull/1417
Commits 2 https://github.com/rust-ndarray/ndarray/pull/1417/commits
Checks 0 https://github.com/rust-ndarray/ndarray/pull/1417/checks
Files changed https://github.com/rust-ndarray/ndarray/pull/1417/files
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1417
https://github.co/hiddenchars
https://github.com/rust-ndarray/ndarray/pull/{{ revealButtonHref }}
https://github.com/bluss
blusshttps://github.com/bluss
Aug 6, 2024https://github.com/rust-ndarray/ndarray/pull/1417#issue-2450477341
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1417
#1290https://github.com/rust-ndarray/ndarray/issues/1290
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1417
https://github.com/bluss
blusshttps://github.com/bluss
force-pushedhttps://github.com/rust-ndarray/ndarray/compare/c165929da42ac05a7ef042556932472a70452cd1..75b5f93e5724d664349b47744d61ec758d1cacf7
c165929https://github.com/rust-ndarray/ndarray/commit/c165929da42ac05a7ef042556932472a70452cd1
75b5f93https://github.com/rust-ndarray/ndarray/commit/75b5f93e5724d664349b47744d61ec758d1cacf7
Compare https://github.com/rust-ndarray/ndarray/compare/c165929da42ac05a7ef042556932472a70452cd1..75b5f93e5724d664349b47744d61ec758d1cacf7
August 6, 2024 10:06https://github.com/rust-ndarray/ndarray/pull/1417#event-13776172200
https://github.com/bluss
Make iterators covariant in element typehttps://github.com/rust-ndarray/ndarray/pull/1417/commits/a9605dc251776985f1e6a49f12f91b61dbe9daa1
a9605dchttps://github.com/rust-ndarray/ndarray/pull/1417/commits/a9605dc251776985f1e6a49f12f91b61dbe9daa1
#1290https://github.com/rust-ndarray/ndarray/issues/1290
https://github.com/bluss
blusshttps://github.com/bluss
force-pushedhttps://github.com/rust-ndarray/ndarray/compare/75b5f93e5724d664349b47744d61ec758d1cacf7..a9605dc251776985f1e6a49f12f91b61dbe9daa1
75b5f93https://github.com/rust-ndarray/ndarray/commit/75b5f93e5724d664349b47744d61ec758d1cacf7
a9605dchttps://github.com/rust-ndarray/ndarray/commit/a9605dc251776985f1e6a49f12f91b61dbe9daa1
Compare https://github.com/rust-ndarray/ndarray/compare/75b5f93e5724d664349b47744d61ec758d1cacf7..a9605dc251776985f1e6a49f12f91b61dbe9daa1
August 6, 2024 10:09https://github.com/rust-ndarray/ndarray/pull/1417#event-13776216989
https://github.com/bluss
blusshttps://github.com/bluss
0.16.xhttps://github.com/rust-ndarray/ndarray/milestone/10
Aug 6, 2024https://github.com/rust-ndarray/ndarray/pull/1417#event-13776252879
https://github.com/bluss
blusshttps://github.com/bluss
Aug 6, 2024 https://github.com/rust-ndarray/ndarray/pull/1417#pullrequestreview-2220882694
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1417/files/a9605dc251776985f1e6a49f12f91b61dbe9daa1
src/impl_owned_array.rshttps://github.com/rust-ndarray/ndarray/pull/1417/files/a9605dc251776985f1e6a49f12f91b61dbe9daa1#diff-8b735d898bdc23f12eca2ff6e6f7b1cd6be0b2fae589ff658b8250065848e591
blusshttps://github.com/bluss
Aug 6, 2024https://github.com/rust-ndarray/ndarray/pull/1417#discussion_r1705283273
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1417
https://github.com/bluss
Convert Baseiter to use NonNull throughouthttps://github.com/rust-ndarray/ndarray/pull/1417/commits/00e15460ad6d99077f882e92857a9b431478244e
00e1546https://github.com/rust-ndarray/ndarray/pull/1417/commits/00e15460ad6d99077f882e92857a9b431478244e
https://github.com/bluss
blusshttps://github.com/bluss
force-pushedhttps://github.com/rust-ndarray/ndarray/compare/901a9988c55a987a87609ce55c98f1a4aa856406..00e15460ad6d99077f882e92857a9b431478244e
901a998https://github.com/rust-ndarray/ndarray/commit/901a9988c55a987a87609ce55c98f1a4aa856406
00e1546https://github.com/rust-ndarray/ndarray/commit/00e15460ad6d99077f882e92857a9b431478244e
Compare https://github.com/rust-ndarray/ndarray/compare/901a9988c55a987a87609ce55c98f1a4aa856406..00e15460ad6d99077f882e92857a9b431478244e
August 6, 2024 10:32https://github.com/rust-ndarray/ndarray/pull/1417#event-13776496036
https://github.com/bluss
blusshttps://github.com/bluss
Aug 6, 2024https://github.com/rust-ndarray/ndarray/pull/1417#event-13776580701
f7e4750https://github.com/rust-ndarray/ndarray/commit/f7e4750916318d7b1401770c119b365bc9ad0978
Aug 6, 2024https://github.com/rust-ndarray/ndarray/pull/1417#event-13776663779
https://github.com/bluss
blusshttps://github.com/bluss
August 6, 2024 10:45https://github.com/rust-ndarray/ndarray/pull/1417#event-13776664745
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1417
0.16.x https://github.com/rust-ndarray/ndarray/milestone/10
ndarray iterators don't always work well with impl Iterator https://github.com/rust-ndarray/ndarray/issues/1290
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1417
https://github.com/bluss
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.