René's URL Explorer Experiment


Title: Adds `triu` and `tril` methods directly to ArrayBase by akern40 · Pull Request #1386 · rust-ndarray/ndarray · GitHub

Open Graph Title: Adds `triu` and `tril` methods directly to ArrayBase by akern40 · Pull Request #1386 · rust-ndarray/ndarray

X Title: Adds `triu` and `tril` methods directly to ArrayBase by akern40 · Pull Request #1386 · rust-ndarray/ndarray

Description: The implementation seems to work, but unsure about whether this should be a free function vs bound directly to ArrayBase vs a trait. Closes #1323.

Open Graph Description: The implementation seems to work, but unsure about whether this should be a free function vs bound directly to ArrayBase vs a trait. Closes #1323.

X Description: The implementation seems to work, but unsure about whether this should be a free function vs bound directly to ArrayBase vs a trait. Closes #1323.

Opengraph URL: https://github.com/rust-ndarray/ndarray/pull/1386

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:82999e94-78bf-2af3-6078-567332e49978
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD55A:391641:5309DFD:7001957:6964DEC2
html-safe-nonce84f072e26dbec6e262e0a19c6f0eac9bd08e399c60031983eabf3f1b0f5ea909
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTVBOjM5MTY0MTo1MzA5REZEOjcwMDE5NTc6Njk2NERFQzIiLCJ2aXNpdG9yX2lkIjoiNjkyMTI3MTMyNDYwODYxODE3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac695fc2ec49e4648ace17e791f4e3de309d95c7b15ccaa7c63f9cf53be6a987c6
hovercard-subject-tagpull_request:1872443312
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rust-ndarray/ndarray/1386/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/209d6dc158490e7af3a6b10c9a88b0cf15fc977d4138213e24f46a22961ea4ed/rust-ndarray/ndarray/pull/1386
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/209d6dc158490e7af3a6b10c9a88b0cf15fc977d4138213e24f46a22961ea4ed/rust-ndarray/ndarray/pull/1386
og:image:altThe implementation seems to work, but unsure about whether this should be a free function vs bound directly to ArrayBase vs a trait. Closes #1323.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameakern40
hostnamegithub.com
expected-hostnamegithub.com
None5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d
turbo-cache-controlno-preview
go-importgithub.com/rust-ndarray/ndarray git https://github.com/rust-ndarray/ndarray.git
octolytics-dimension-user_id44419403
octolytics-dimension-user_loginrust-ndarray
octolytics-dimension-repository_id22598813
octolytics-dimension-repository_nworust-ndarray/ndarray
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id22598813
octolytics-dimension-repository_network_root_nworust-ndarray/ndarray
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8edad3509fd3b4374694551987974bbbcfd316c0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/rust-ndarray/ndarray/pull/1386#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1386
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1386
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rust-ndarray%2Fndarray
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1386
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1386
Reloadhttps://github.com/rust-ndarray/ndarray/pull/1386
rust-ndarray https://github.com/rust-ndarray
ndarrayhttps://github.com/rust-ndarray/ndarray
Notifications https://github.com/login?return_to=%2Frust-ndarray%2Fndarray
Fork 360 https://github.com/login?return_to=%2Frust-ndarray%2Fndarray
Star 4.2k https://github.com/login?return_to=%2Frust-ndarray%2Fndarray
Code https://github.com/rust-ndarray/ndarray
Issues 172 https://github.com/rust-ndarray/ndarray/issues
Pull requests 34 https://github.com/rust-ndarray/ndarray/pulls
Discussions https://github.com/rust-ndarray/ndarray/discussions
Actions https://github.com/rust-ndarray/ndarray/actions
Projects 0 https://github.com/rust-ndarray/ndarray/projects
Wiki https://github.com/rust-ndarray/ndarray/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/rust-ndarray/ndarray/security
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
Insights https://github.com/rust-ndarray/ndarray/pulse
Code https://github.com/rust-ndarray/ndarray
Issues https://github.com/rust-ndarray/ndarray/issues
Pull requests https://github.com/rust-ndarray/ndarray/pulls
Discussions https://github.com/rust-ndarray/ndarray/discussions
Actions https://github.com/rust-ndarray/ndarray/actions
Projects https://github.com/rust-ndarray/ndarray/projects
Wiki https://github.com/rust-ndarray/ndarray/wiki
Security https://github.com/rust-ndarray/ndarray/security
Insights https://github.com/rust-ndarray/ndarray/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Frust-ndarray%2Fndarray%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Frust-ndarray%2Fndarray%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/rust-ndarray/ndarray/pull/1386#issue-comment-box
nilgoyettehttps://github.com/nilgoyette
rust-ndarray:masterhttps://github.com/rust-ndarray/ndarray/tree/master
akern40:triangularhttps://github.com/akern40/ndarray/tree/triangular
Adds triu and tril methods directly to ArrayBase https://github.com/rust-ndarray/ndarray/pull/1386#top
nilgoyettehttps://github.com/nilgoyette
rust-ndarray:masterhttps://github.com/rust-ndarray/ndarray/tree/master
akern40:triangularhttps://github.com/akern40/ndarray/tree/triangular
Conversation 20 https://github.com/rust-ndarray/ndarray/pull/1386
Commits 4 https://github.com/rust-ndarray/ndarray/pull/1386/commits
Checks 0 https://github.com/rust-ndarray/ndarray/pull/1386/checks
Files changed https://github.com/rust-ndarray/ndarray/pull/1386/files
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.co/hiddenchars
https://github.com/rust-ndarray/ndarray/pull/{{ revealButtonHref }}
https://github.com/akern40
akern40https://github.com/akern40
May 16, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issue-2299278736
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
#1323https://github.com/rust-ndarray/ndarray/issues/1323
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/nilgoyette
nilgoyettehttps://github.com/nilgoyette
May 16, 2024 https://github.com/rust-ndarray/ndarray/pull/1386#pullrequestreview-2061051633
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1386/files
src/tri.rshttps://github.com/rust-ndarray/ndarray/pull/1386/files#diff-7f1cd9ab95ab771468becc8017a10e50bd28c266085948bc6f2e03c7cb3a56af
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
src/tri.rshttps://github.com/rust-ndarray/ndarray/pull/1386/files#diff-7f1cd9ab95ab771468becc8017a10e50bd28c266085948bc6f2e03c7cb3a56af
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
src/tri.rshttps://github.com/rust-ndarray/ndarray/pull/1386/files#diff-7f1cd9ab95ab771468becc8017a10e50bd28c266085948bc6f2e03c7cb3a56af
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
src/tri.rshttps://github.com/rust-ndarray/ndarray/pull/1386/files#diff-7f1cd9ab95ab771468becc8017a10e50bd28c266085948bc6f2e03c7cb3a56af
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/akern40
akern40https://github.com/akern40
May 18, 2024https://github.com/rust-ndarray/ndarray/pull/1386#event-12856080024
https://github.com/akern40
akern40https://github.com/akern40
May 18, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issuecomment-2118996376
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/akern40
akern40https://github.com/akern40
May 18, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issuecomment-2119000922
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/nilgoyette
nilgoyettehttps://github.com/nilgoyette
May 20, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issuecomment-2121056588
@blusshttps://github.com/bluss
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/akern40
akern40https://github.com/akern40
May 20, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issuecomment-2121229690
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
@blusshttps://github.com/bluss
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/akern40
akern40https://github.com/akern40
force-pushedhttps://github.com/rust-ndarray/ndarray/compare/7d24c549213a7912537f6376a9dd0746c9054423..6316fbe8d036ad1b1cc58f7d7b8fbb11bda1f6ee
7d24c54https://github.com/rust-ndarray/ndarray/commit/7d24c549213a7912537f6376a9dd0746c9054423
6316fbehttps://github.com/rust-ndarray/ndarray/commit/6316fbe8d036ad1b1cc58f7d7b8fbb11bda1f6ee
Compare https://github.com/rust-ndarray/ndarray/compare/7d24c549213a7912537f6376a9dd0746c9054423..6316fbe8d036ad1b1cc58f7d7b8fbb11bda1f6ee
May 22, 2024 03:13https://github.com/rust-ndarray/ndarray/pull/1386#event-12887693019
https://github.com/akern40
Adds triu and tril methods that mimic NumPy.https://github.com/rust-ndarray/ndarray/pull/1386/commits/3986824d1ed73a5c0763d2075410c087464ec74e
3986824https://github.com/rust-ndarray/ndarray/pull/1386/commits/3986824d1ed73a5c0763d2075410c087464ec74e
https://github.com/akern40
akern40https://github.com/akern40
force-pushedhttps://github.com/rust-ndarray/ndarray/compare/6316fbe8d036ad1b1cc58f7d7b8fbb11bda1f6ee..3986824d1ed73a5c0763d2075410c087464ec74e
6316fbehttps://github.com/rust-ndarray/ndarray/commit/6316fbe8d036ad1b1cc58f7d7b8fbb11bda1f6ee
3986824https://github.com/rust-ndarray/ndarray/commit/3986824d1ed73a5c0763d2075410c087464ec74e
Compare https://github.com/rust-ndarray/ndarray/compare/6316fbe8d036ad1b1cc58f7d7b8fbb11bda1f6ee..3986824d1ed73a5c0763d2075410c087464ec74e
May 22, 2024 03:14https://github.com/rust-ndarray/ndarray/pull/1386#event-12887701852
https://github.com/akern40
Uses alloc:: instead of std:: for vec! importhttps://github.com/rust-ndarray/ndarray/pull/1386/commits/449ad0e08aab60d1a574bf844d9da41ded2d2729
449ad0ehttps://github.com/rust-ndarray/ndarray/pull/1386/commits/449ad0e08aab60d1a574bf844d9da41ded2d2729
https://github.com/nilgoyette
nilgoyettehttps://github.com/nilgoyette
May 22, 2024 https://github.com/rust-ndarray/ndarray/pull/1386#pullrequestreview-2071973917
View reviewed changes https://github.com/rust-ndarray/ndarray/pull/1386/files/449ad0e08aab60d1a574bf844d9da41ded2d2729
src/tri.rshttps://github.com/rust-ndarray/ndarray/pull/1386/files/449ad0e08aab60d1a574bf844d9da41ded2d2729#diff-7f1cd9ab95ab771468becc8017a10e50bd28c266085948bc6f2e03c7cb3a56af
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
akern40https://github.com/akern40
May 24, 2024 23:06https://github.com/rust-ndarray/ndarray/pull/1386#commits-pushed-9e9c3f9
https://github.com/akern40
Uses initial check to clarify logichttps://github.com/rust-ndarray/ndarray/pull/1386/commits/9e9c3f9710c718c68eb382d6ef7032bea91618bb
9e9c3f9https://github.com/rust-ndarray/ndarray/pull/1386/commits/9e9c3f9710c718c68eb382d6ef7032bea91618bb
https://github.com/akern40
Removes unecessary commenthttps://github.com/rust-ndarray/ndarray/pull/1386/commits/84f0c80d9d95d47eff6a28f4dd1cc4c4a5cf8171
84f0c80https://github.com/rust-ndarray/ndarray/pull/1386/commits/84f0c80d9d95d47eff6a28f4dd1cc4c4a5cf8171
https://github.com/nilgoyette
nilgoyettehttps://github.com/nilgoyette
May 27, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issuecomment-2133530296
@akern40https://github.com/akern40
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/nilgoyette
nilgoyettehttps://github.com/nilgoyette
May 27, 2024https://github.com/rust-ndarray/ndarray/pull/1386#event-12946395789
72b0d09https://github.com/rust-ndarray/ndarray/commit/72b0d098ba05c889245dc86c66c13ba92086e5f4
May 27, 2024https://github.com/rust-ndarray/ndarray/pull/1386#event-12946613092
zackmdavishttps://github.com/zackmdavis
Aug 3, 2024 https://github.com/rust-ndarray/ndarray/pull/1386#ref-commit-c38bbbe
https://github.com/zackmdavis
bleeding-edge ndarrayhttps://github.com/zackmdavis/Radiance/commit/c38bbbea14e6cc11fbf14fbee3ad70125889d402
c38bbbehttps://github.com/zackmdavis/Radiance/commit/c38bbbea14e6cc11fbf14fbee3ad70125889d402
rust-ndarray/ndarray#1386https://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/zackmdavis
zackmdavishttps://github.com/zackmdavis
Aug 3, 2024https://github.com/rust-ndarray/ndarray/pull/1386#issuecomment-2266481812
@akern40https://github.com/akern40
you can run master by changing the version specification in your Cargo.toml tohttps://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/zackmdavis
zackmdavishttps://github.com/zackmdavis
Aug 3, 2024 https://github.com/rust-ndarray/ndarray/pull/1386#ref-issue-2446615876
tril and triu fail on 1×1 matrices #1415 https://github.com/rust-ndarray/ndarray/issues/1415
https://github.com/akern40
akern40https://github.com/akern40
September 29, 2024 00:44https://github.com/rust-ndarray/ndarray/pull/1386#event-14443156613
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1386
https://github.com/nilgoyette
nilgoyette https://github.com/nilgoyette
https://github.com/rust-ndarray/ndarray/pull/1386/files/449ad0e08aab60d1a574bf844d9da41ded2d2729
Implement numpy's triu and tril methods https://github.com/rust-ndarray/ndarray/issues/1323
Please reload this pagehttps://github.com/rust-ndarray/ndarray/pull/1386
https://github.com/akern40
https://github.com/nilgoyette
https://github.com/zackmdavis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.