| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:95b46192-d61f-b661-b949-e18c7f3272f9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D44E:1B891C:446E1:5EA5C:6AFCA273 |
| html-safe-nonce | caf215d848324ee47211fc19b960029fbf8eaae4041a4d1a406a0531fd977298 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDRFOjFCODkxQzo0NDZFMTo1RUE1Qzo2QUZDQTI3MyIsInZpc2l0b3JfaWQiOiIyNDAzOTg0MzE1MDk3MzI2MTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b5ddcd37e23ed636a367feb29ff3b4ed0859289998cbe52dedb34217c176a29a |
| hovercard-subject-tag | pull_request:1799060651 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rust-ndarray/ndarray/1377/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c67922b0bb558524a5d71f4b701ed5d6e437b51ad3c77182d150d4c9b028a60c/rust-ndarray/ndarray/pull/1377 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c67922b0bb558524a5d71f4b701ed5d6e437b51ad3c77182d150d4c9b028a60c/rust-ndarray/ndarray/pull/1377 |
| og:image:alt | This is very much a work-in-progress, but I wanted to know how this approach fits with the rest of the codebase. I realise it's not the most "rusty" implementation, but I think it cou... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Pencilcaseman |
| hostname | github.com |
| expected-hostname | github.com |
| None | e3084aead77cbcb4f4904fba53851fa1a0546b0dec3619bd250815e72588dc6d |
| turbo-cache-control | no-cache |
| go-import | github.com/rust-ndarray/ndarray git https://github.com/rust-ndarray/ndarray.git |
| octolytics-dimension-user_id | 44419403 |
| octolytics-dimension-user_login | rust-ndarray |
| octolytics-dimension-repository_id | 22598813 |
| octolytics-dimension-repository_nwo | rust-ndarray/ndarray |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22598813 |
| octolytics-dimension-repository_network_root_nwo | rust-ndarray/ndarray |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5410e4bebd3e45b138c853ecef3992279d86d5af |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/rust-ndarray/ndarray/pull/1377#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1377 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1377 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rust-ndarray%2Fndarray |
| Reload | https://github.com/rust-ndarray/ndarray/pull/1377 |
| Reload | https://github.com/rust-ndarray/ndarray/pull/1377 |
| Reload | https://github.com/rust-ndarray/ndarray/pull/1377 |
| rust-ndarray | https://github.com/rust-ndarray |
| ndarray | https://github.com/rust-ndarray/ndarray |
| Code | https://github.com/rust-ndarray/ndarray |
| Issues175 (175) | https://github.com/rust-ndarray/ndarray/issues |
| Pull requests41 (41) | https://github.com/rust-ndarray/ndarray/pulls |
| Discussions | https://github.com/rust-ndarray/ndarray/discussions |
| Actions | https://github.com/rust-ndarray/ndarray/actions |
| Projects | https://github.com/rust-ndarray/ndarray/projects |
| Wiki | https://github.com/rust-ndarray/ndarray/wiki |
| Security and quality | https://github.com/rust-ndarray/ndarray/security |
| Insights | https://github.com/rust-ndarray/ndarray/insights |
| https://github.com/rust-ndarray/ndarray |
| Pencilcaseman | https://github.com/Pencilcaseman |
| rust-ndarray:master | https://github.com/rust-ndarray/ndarray/tree/master |
| Pencilcaseman:master | https://github.com/Pencilcaseman/ndarray/tree/master |
| Conversation | https://github.com/rust-ndarray/ndarray/pull/1377 |
| Commits23 (23) | https://github.com/rust-ndarray/ndarray/pull/1377/commits |
| Checks | https://github.com/rust-ndarray/ndarray/pull/1377/checks |
| Files changed | https://github.com/rust-ndarray/ndarray/pull/1377/files |
| GPU Support via OpenCL | https://github.com/rust-ndarray/ndarray/pull/1377#top |
| Pencilcaseman | https://github.com/Pencilcaseman |
| rust-ndarray:master | https://github.com/rust-ndarray/ndarray/tree/master |
| Pencilcaseman:master | https://github.com/Pencilcaseman/ndarray/tree/master |
|
| https://github.com/Pencilcaseman |
| Pencilcaseman | https://github.com/Pencilcaseman |
| Mar 30, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#issue-2216616253 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| Pencilcaseman | https://github.com/Pencilcaseman |
| March 25, 2024 02:43 | https://github.com/rust-ndarray/ndarray/pull/1377#commits-pushed-28bdd02 |
|
| https://github.com/Pencilcaseman |
| Initial OpenCL things | https://github.com/rust-ndarray/ndarray/pull/1377/commits/28bdd028436839f820bacee15c0fca96d49734e1 |
| 28bdd02 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/28bdd028436839f820bacee15c0fca96d49734e1 |
|
| https://github.com/Pencilcaseman |
| Update CI | https://github.com/rust-ndarray/ndarray/pull/1377/commits/aa19194f88b1aac4021b47b84f2bf2a9b507802f |
| aa19194 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/aa19194f88b1aac4021b47b84f2bf2a9b507802f |
|
| https://github.com/Pencilcaseman |
| Why is CI failing? | https://github.com/rust-ndarray/ndarray/pull/1377/commits/24bcf1dbd07bbd7752f75a76ac2eb932bd0abe81 |
| 24bcf1d | https://github.com/rust-ndarray/ndarray/pull/1377/commits/24bcf1dbd07bbd7752f75a76ac2eb932bd0abe81 |
|
| https://github.com/Pencilcaseman |
| Remove some clippy warnings and fix some bugs | https://github.com/rust-ndarray/ndarray/pull/1377/commits/931dde4a9a0906eb06cf4288dde2f2b81293cb8d |
| 931dde4 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/931dde4a9a0906eb06cf4288dde2f2b81293cb8d |
|
| https://github.com/Pencilcaseman |
| Fix | https://github.com/rust-ndarray/ndarray/pull/1377/commits/67a0382183a40d7c4d1f5b7f884621cdbaea6ebe |
| 67a0382 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/67a0382183a40d7c4d1f5b7f884621cdbaea6ebe |
|
| https://github.com/Pencilcaseman |
| Fix tests | https://github.com/rust-ndarray/ndarray/pull/1377/commits/b03ff6fed40222c5c47fef95756c4294471a2f85 |
| b03ff6f | https://github.com/rust-ndarray/ndarray/pull/1377/commits/b03ff6fed40222c5c47fef95756c4294471a2f85 |
|
| https://github.com/Pencilcaseman |
| Update bench config | https://github.com/rust-ndarray/ndarray/pull/1377/commits/8dd39d1a634f6fd470e6f2a66e9b3dbf53c1aaa1 |
| 8dd39d1 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/8dd39d1a634f6fd470e6f2a66e9b3dbf53c1aaa1 |
|
| https://github.com/Pencilcaseman |
| Do not allow operations on mismatched devices | https://github.com/rust-ndarray/ndarray/pull/1377/commits/772bda49629614d78214069b12d3c0faf64569a7 |
| 772bda4 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/772bda49629614d78214069b12d3c0faf64569a7 |
|
| https://github.com/Pencilcaseman |
| oops | https://github.com/rust-ndarray/ndarray/pull/1377/commits/4ac3f969ea1e9efaa4932f0a8d96daff7c4ead9a |
| 4ac3f96 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/4ac3f969ea1e9efaa4932f0a8d96daff7c4ead9a |
|
| https://github.com/Pencilcaseman |
| Apparently strip isn't allowed in 1.57.0 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/00e39558a161117a97c6c8fef1ea87766aff86fd |
| 00e3955 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/00e39558a161117a97c6c8fef1ea87766aff86fd |
|
| https://github.com/Pencilcaseman |
| Bump MSRV | https://github.com/rust-ndarray/ndarray/pull/1377/commits/06427665a0ff57bce9ce1c326d3fd7815d416de4 |
| 0642766 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/06427665a0ff57bce9ce1c326d3fd7815d416de4 |
|
| https://github.com/Pencilcaseman |
| Remove unnecessary unsafe block | https://github.com/rust-ndarray/ndarray/pull/1377/commits/1b5d086898b83ac61a60347ae0ddbfd2874af81e |
| 1b5d086 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/1b5d086898b83ac61a60347ae0ddbfd2874af81e |
|
| https://github.com/Pencilcaseman |
| Fix issue | https://github.com/rust-ndarray/ndarray/pull/1377/commits/f92fe0d3dfa72e049112d43604ec3a1829a4f925 |
| f92fe0d | https://github.com/rust-ndarray/ndarray/pull/1377/commits/f92fe0d3dfa72e049112d43604ec3a1829a4f925 |
|
| https://github.com/Pencilcaseman |
| Why did that not work... Bump MSRV again | https://github.com/rust-ndarray/ndarray/pull/1377/commits/b04c5330b0af91a02145b63af0fdde879fbdc98b |
| b04c533 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/b04c5330b0af91a02145b63af0fdde879fbdc98b |
|
| https://github.com/Pencilcaseman |
| Update CI and tests. Decrease MSRV. | https://github.com/rust-ndarray/ndarray/pull/1377/commits/722c4f35921609ea6e619f5303b0aee314ae184a |
| 722c4f3 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/722c4f35921609ea6e619f5303b0aee314ae184a |
|
| https://github.com/Pencilcaseman |
| Update CI | https://github.com/rust-ndarray/ndarray/pull/1377/commits/fdcd653e306b67c63fcc1cf06f0106e542791ce8 |
| fdcd653 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/fdcd653e306b67c63fcc1cf06f0106e542791ce8 |
|
| https://github.com/Pencilcaseman |
| Further update CI | https://github.com/rust-ndarray/ndarray/pull/1377/commits/d813d66811af49e9a9b7ca8e59383bed6d85581d |
| d813d66 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/d813d66811af49e9a9b7ca8e59383bed6d85581d |
|
| https://github.com/Pencilcaseman |
| Version matching is hard | https://github.com/rust-ndarray/ndarray/pull/1377/commits/2253f78a56d19c5197332a554e6ba5e15ce40b77 |
| 2253f78 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/2253f78a56d19c5197332a554e6ba5e15ce40b77 |
|
| https://github.com/Pencilcaseman |
| Again, change MSRV | https://github.com/rust-ndarray/ndarray/pull/1377/commits/ed26986492f58e3ca360fb69a86695a11e774cb0 |
| ed26986 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/ed26986492f58e3ca360fb69a86695a11e774cb0 |
|
| https://github.com/Pencilcaseman |
| First OpenCL kernels! | https://github.com/rust-ndarray/ndarray/pull/1377/commits/c4541f58c90f04952715063b020cace93d7ec869 |
| c4541f5 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/c4541f58c90f04952715063b020cace93d7ec869 |
|
| https://github.com/Pencilcaseman |
| Clean up some code and update CI | https://github.com/rust-ndarray/ndarray/pull/1377/commits/77bfad65a87144d3de2ad00fd08fc313676df6b0 |
| 77bfad6 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/77bfad65a87144d3de2ad00fd08fc313676df6b0 |
|
| https://github.com/Pencilcaseman |
| Fix include order | https://github.com/rust-ndarray/ndarray/pull/1377/commits/48c5ee2901f29e264fccddbabae28866ffc8edb6 |
| 48c5ee2 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/48c5ee2901f29e264fccddbabae28866ffc8edb6 |
|
| https://github.com/Pencilcaseman |
| Revert formatting changes :( | https://github.com/rust-ndarray/ndarray/pull/1377/commits/96aba357bbf9024f32d01c337e44ff338f482e22 |
| 96aba35 | https://github.com/rust-ndarray/ndarray/pull/1377/commits/96aba357bbf9024f32d01c337e44ff338f482e22 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Apr 1, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#issuecomment-2030593762 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
|
Apr 1, 2024
| https://github.com/rust-ndarray/ndarray/pull/1377#pullrequestreview-1970042502 |
|
View reviewed changes
| https://github.com/rust-ndarray/ndarray/pull/1377/files/96aba357bbf9024f32d01c337e44ff338f482e22 |
| src/impl_ops.rs | https://github.com/rust-ndarray/ndarray/pull/1377/files/96aba357bbf9024f32d01c337e44ff338f482e22#diff-e7419c9ee225aa7fcaecd37efb27ef2304663459f838a52d6da174f2871ed656 |
| bluss | https://github.com/bluss |
| Mar 30, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#discussion_r1545478052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| src/impl_ops.rs | https://github.com/rust-ndarray/ndarray/pull/1377/files/96aba357bbf9024f32d01c337e44ff338f482e22#diff-e7419c9ee225aa7fcaecd37efb27ef2304663459f838a52d6da174f2871ed656 |
| bluss | https://github.com/bluss |
| Mar 30, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#discussion_r1545478247 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| src/impl_methods.rs | https://github.com/rust-ndarray/ndarray/pull/1377/files/96aba357bbf9024f32d01c337e44ff338f482e22#diff-ad89e759e86f5d18eb412398d9e76b1b32b25139284f34e5d873e341ba485a96 |
| bluss | https://github.com/bluss |
| Mar 30, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#discussion_r1545478550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| https://github.com/Pencilcaseman |
| Pencilcaseman | https://github.com/Pencilcaseman |
| Apr 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#issuecomment-2030851904 |
| @bluss | https://github.com/bluss |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1377#issuecomment-2265104202 |
| #1272 (comment) | https://github.com/rust-ndarray/ndarray/issues/1272#issuecomment-2254655584 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| https://github.co/hiddenchars |
| https://github.com/rust-ndarray/ndarray/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1377 |
|
| https://github.com/bluss |
|
bluss
| https://github.com/bluss |
|
| https://github.com/rust-ndarray/ndarray/pull/1377/files/96aba357bbf9024f32d01c337e44ff338f482e22 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1377 |
|
| https://github.com/Pencilcaseman |
|
| https://github.com/bluss |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |