| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bd6ed432-2573-f460-4c74-d127e2e8b8c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E61E:7FE64:484C1B8:6124B15:6964DF63 |
| html-safe-nonce | 388e43e67a478f1c7aba975796259a2ecc449c0d80e979c893cd8f56de04337e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjFFOjdGRTY0OjQ4NEMxQjg6NjEyNEIxNTo2OTY0REY2MyIsInZpc2l0b3JfaWQiOiIzNDEwMjAzODIwMDQzODUzNjY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 97ded7122d7c328ed33dcb58089b69fa5bd73c5a1df92b95eaf8683c7a882505 |
| hovercard-subject-tag | pull_request:662643653 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rust-ndarray/ndarray/1028/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a8f055198e6ea82bddd3eb451e85fad6e329e8779f4eb6e3c343713dde025e3c/rust-ndarray/ndarray/pull/1028 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8f055198e6ea82bddd3eb451e85fad6e329e8779f4eb6e3c343713dde025e3c/rust-ndarray/ndarray/pull/1028 |
| og:image:alt | Add A: Clone bound to into_shared and implement DataOwned for CowRepr
See #1027 regarding the A: Clone bound for into_shared.
I've marked this PR as a draft because it would be good to add some... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jturner314 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d |
| turbo-cache-control | no-preview |
| go-import | github.com/rust-ndarray/ndarray git https://github.com/rust-ndarray/ndarray.git |
| octolytics-dimension-user_id | 44419403 |
| octolytics-dimension-user_login | rust-ndarray |
| octolytics-dimension-repository_id | 22598813 |
| octolytics-dimension-repository_nwo | rust-ndarray/ndarray |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 22598813 |
| octolytics-dimension-repository_network_root_nwo | rust-ndarray/ndarray |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8edad3509fd3b4374694551987974bbbcfd316c0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/rust-ndarray/ndarray/pull/1028#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1028 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1028 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rust-ndarray%2Fndarray |
| Reload | https://github.com/rust-ndarray/ndarray/pull/1028 |
| Reload | https://github.com/rust-ndarray/ndarray/pull/1028 |
| Reload | https://github.com/rust-ndarray/ndarray/pull/1028 |
|
rust-ndarray
| https://github.com/rust-ndarray |
| ndarray | https://github.com/rust-ndarray/ndarray |
|
Notifications
| https://github.com/login?return_to=%2Frust-ndarray%2Fndarray |
|
Fork
360
| https://github.com/login?return_to=%2Frust-ndarray%2Fndarray |
|
Star
4.2k
| https://github.com/login?return_to=%2Frust-ndarray%2Fndarray |
|
Code
| https://github.com/rust-ndarray/ndarray |
|
Issues
172
| https://github.com/rust-ndarray/ndarray/issues |
|
Pull requests
34
| https://github.com/rust-ndarray/ndarray/pulls |
|
Discussions
| https://github.com/rust-ndarray/ndarray/discussions |
|
Actions
| https://github.com/rust-ndarray/ndarray/actions |
|
Projects
0
| https://github.com/rust-ndarray/ndarray/projects |
|
Wiki
| https://github.com/rust-ndarray/ndarray/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/rust-ndarray/ndarray/security |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
|
Insights
| https://github.com/rust-ndarray/ndarray/pulse |
|
Code
| https://github.com/rust-ndarray/ndarray |
|
Issues
| https://github.com/rust-ndarray/ndarray/issues |
|
Pull requests
| https://github.com/rust-ndarray/ndarray/pulls |
|
Discussions
| https://github.com/rust-ndarray/ndarray/discussions |
|
Actions
| https://github.com/rust-ndarray/ndarray/actions |
|
Projects
| https://github.com/rust-ndarray/ndarray/projects |
|
Wiki
| https://github.com/rust-ndarray/ndarray/wiki |
|
Security
| https://github.com/rust-ndarray/ndarray/security |
|
Insights
| https://github.com/rust-ndarray/ndarray/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Frust-ndarray%2Fndarray%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Frust-ndarray%2Fndarray%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/rust-ndarray/ndarray/pull/1028#issue-comment-box |
| bluss | https://github.com/bluss |
| rust-ndarray:master | https://github.com/rust-ndarray/ndarray/tree/master |
| jturner314:cowrepr-dataowned | https://github.com/jturner314/ndarray/tree/cowrepr-dataowned |
|
Make CowArray an owned storage array, require Clone bound for into_shared
| https://github.com/rust-ndarray/ndarray/pull/1028#top |
| bluss | https://github.com/bluss |
| rust-ndarray:master | https://github.com/rust-ndarray/ndarray/tree/master |
| jturner314:cowrepr-dataowned | https://github.com/jturner314/ndarray/tree/cowrepr-dataowned |
|
Conversation
2
| https://github.com/rust-ndarray/ndarray/pull/1028 |
|
Commits
2
| https://github.com/rust-ndarray/ndarray/pull/1028/commits |
|
Checks
0
| https://github.com/rust-ndarray/ndarray/pull/1028/checks |
|
Files changed
| https://github.com/rust-ndarray/ndarray/pull/1028/files |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
| https://github.co/hiddenchars |
| https://github.com/rust-ndarray/ndarray/pull/{{ revealButtonHref }} |
|
| https://github.com/jturner314 |
| jturner314 | https://github.com/jturner314 |
| Jun 5, 2021 | https://github.com/rust-ndarray/ndarray/pull/1028#issue-912489160 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
| #1027 | https://github.com/rust-ndarray/ndarray/issues/1027 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
| https://github.com/jturner314 |
| jturner314 | https://github.com/jturner314 |
|
breaking-change
| https://github.com/rust-ndarray/ndarray/issues?q=state%3Aopen%20label%3Abreaking-change |
| Jun 5, 2021 | https://github.com/rust-ndarray/ndarray/pull/1028#event-4847295325 |
| https://github.com/jturner314 |
| jturner314 | https://github.com/jturner314 |
|
Jun 18, 2021
| https://github.com/rust-ndarray/ndarray/pull/1028#ref-issue-925063809 |
|
Add From impls for CowArray, similar to Array and ArrayView
#1037
| https://github.com/rust-ndarray/ndarray/issues/1037 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| 0.16.0 | https://github.com/rust-ndarray/ndarray/milestone/2 |
| Mar 10, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#event-12064879416 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| 0.16.0 | https://github.com/rust-ndarray/ndarray/milestone/2 |
| 0.17.0 | https://github.com/rust-ndarray/ndarray/milestone/9 |
| Apr 6, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#event-12381810514 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| force-pushed | https://github.com/rust-ndarray/ndarray/compare/36954ef9fd3a50d6ba054169c7ef70532faea150..de793b3572ef91969466b9a453b7a16fd0ff38e3 |
| 36954ef | https://github.com/rust-ndarray/ndarray/commit/36954ef9fd3a50d6ba054169c7ef70532faea150 |
| de793b3 | https://github.com/rust-ndarray/ndarray/commit/de793b3572ef91969466b9a453b7a16fd0ff38e3 |
|
Compare
| https://github.com/rust-ndarray/ndarray/compare/36954ef9fd3a50d6ba054169c7ef70532faea150..de793b3572ef91969466b9a453b7a16fd0ff38e3 |
| August 2, 2024 19:44 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746095439 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#issuecomment-2266037850 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
| jturner314 | https://github.com/jturner314 |
| August 2, 2024 21:48 | https://github.com/rust-ndarray/ndarray/pull/1028#commits-pushed-be3aa20 |
|
| https://github.com/jturner314 |
|
| https://github.com/bluss |
| Add A: Clone bound to into_shared | https://github.com/rust-ndarray/ndarray/pull/1028/commits/be3aa20f837d8a247cfea417e80c379b63cb7b78 |
| be3aa20 | https://github.com/rust-ndarray/ndarray/pull/1028/commits/be3aa20f837d8a247cfea417e80c379b63cb7b78 |
|
| https://github.com/jturner314 |
|
| https://github.com/bluss |
| Implement DataOwned for CowRepr | https://github.com/rust-ndarray/ndarray/pull/1028/commits/9681ababca251c4aa8c88bfe069dfce74f48ffcb |
| 9681aba | https://github.com/rust-ndarray/ndarray/pull/1028/commits/9681ababca251c4aa8c88bfe069dfce74f48ffcb |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| force-pushed | https://github.com/rust-ndarray/ndarray/compare/de793b3572ef91969466b9a453b7a16fd0ff38e3..9681ababca251c4aa8c88bfe069dfce74f48ffcb |
| de793b3 | https://github.com/rust-ndarray/ndarray/commit/de793b3572ef91969466b9a453b7a16fd0ff38e3 |
| 9681aba | https://github.com/rust-ndarray/ndarray/commit/9681ababca251c4aa8c88bfe069dfce74f48ffcb |
|
Compare
| https://github.com/rust-ndarray/ndarray/compare/de793b3572ef91969466b9a453b7a16fd0ff38e3..9681ababca251c4aa8c88bfe069dfce74f48ffcb |
| August 2, 2024 19:49 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746137447 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746456951 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746457954 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| August 2, 2024 20:30 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746459092 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
|
Aug 2, 2024
| https://github.com/rust-ndarray/ndarray/pull/1028#pullrequestreview-2216358182 |
|
View reviewed changes
| https://github.com/rust-ndarray/ndarray/pull/1028/files/9681ababca251c4aa8c88bfe069dfce74f48ffcb |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#issuecomment-2266107150 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
| https://github.com/bluss |
| bluss | https://github.com/bluss |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746464888 |
| e29a524 | https://github.com/rust-ndarray/ndarray/commit/e29a52411928f35a78d1d333d15a29e1eedcddb1 |
| Aug 2, 2024 | https://github.com/rust-ndarray/ndarray/pull/1028#event-13746534459 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frust-ndarray%2Fndarray%2Fpull%2F1028 |
|
| https://github.com/bluss |
|
bluss
| https://github.com/bluss |
|
| https://github.com/rust-ndarray/ndarray/pull/1028/files/9681ababca251c4aa8c88bfe069dfce74f48ffcb |
|
breaking-change
| https://github.com/rust-ndarray/ndarray/issues?q=state%3Aopen%20label%3Abreaking-change |
|
0.17.0
| https://github.com/rust-ndarray/ndarray/milestone/9 |
| Please reload this page | https://github.com/rust-ndarray/ndarray/pull/1028 |
|
| https://github.com/jturner314 |
|
| https://github.com/bluss |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |