Title: Changing rstack.rslint.trace.server restarts every stack instead of updating trace in place · Issue #39 · rstackjs/rstack-editor · GitHub
Open Graph Title: Changing rstack.rslint.trace.server restarts every stack instead of updating trace in place · Issue #39 · rstackjs/rstack-editor
X Title: Changing rstack.rslint.trace.server restarts every stack instead of updating trace in place · Issue #39 · rstackjs/rstack-editor
Description: Problem Changing rstack.rslint.trace.server restarts the whole extension instead of updating the trace level in place. trace.server is listed in the Rslint controller's restartOnSettings (packages/vscode/src/stacks/lint/index.ts:71-75). ...
Open Graph Description: Problem Changing rstack.rslint.trace.server restarts the whole extension instead of updating the trace level in place. trace.server is listed in the Rslint controller's restartOnSettings (packages/...
X Description: Problem Changing rstack.rslint.trace.server restarts the whole extension instead of updating the trace level in place. trace.server is listed in the Rslint controller's restartOnSettings (packa...
Opengraph URL: https://github.com/rstackjs/rstack-editor/issues/39
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Changing rstack.rslint.trace.server restarts every stack instead of updating trace in place","articleBody":"## Problem\n\nChanging `rstack.rslint.trace.server` restarts the whole extension instead of updating the trace level in place.\n\n`trace.server` is listed in the Rslint controller's `restartOnSettings` (`packages/vscode/src/stacks/lint/index.ts:71-75`). The shell answers any matching configuration change with `restart(undefined, …)` (`packages/vscode/src/extension.ts:73-110`), which expands to every stack (`extension.ts:248-257`). So flipping a debug-only setting from `off` to `messages`:\n\n1. retires Rslint, Rstest and fmt (status bar goes to `starting`),\n2. sends `didClose` for every open document and deletes its diagnostics,\n3. disposes the Rstest `TestController` (the Test Explorer tree is destroyed and rebuilt),\n4. stops every fmt server,\n5. re-runs detection and rebuilds all three stacks.\n\nThe replacement client only attaches a trace channel and calls `client.setTrace` when the setting is non-`off` at construction time (`packages/vscode/src/stacks/lint/Rslint.ts:415-445,509-514`), so there is no path to enable tracing on a running client.\n\n## Upstream behavior\n\nThe standalone rslint extension supplied a `traceOutputChannel` unconditionally and let `vscode-languageclient` own the setting: it puts the initial value into the `initialize` request's `trace` field and sends `$/setTrace` on every later change, with no restart (`rslint@origin/main:packages/vscode-extension/src/Rslint.ts:96-119,429-434`). Its E2E asserts that `off → messages → verbose → off` reaches every running client via `$/setTrace` while each server's start count stays at 1 (`packages/vscode-extension/__tests__/suite-jsconfig/trace-output-channel.test.ts:200-300`).\n\n## Proposal\n\n- Drop `trace.server` from `restartOnSettings` in `stacks/lint/index.ts`.\n- Pass the trace channel to the language client unconditionally so `vscode-languageclient` handles `$/setTrace` itself; remove the manual `setTrace` call.\n- Keep the shared `Rstack: Rslint` channel for trace output (the four-channel layout in `channels.ts` is a deliberate cap and unrelated to whether a restart is needed).\n- Add an E2E in `e2e/lint/` mirroring the upstream assertions: changing the setting notifies running clients and does not restart any server.\n- Check whether `rstack.fmt.trace.server` has the same issue and apply the same fix.\n\n## Context\n\nFound while auditing the standalone rslint/rstest extensions for sunset. This is the only confirmed behavior regression relative to the standalone extensions.\n","author":{"url":"https://github.com/fi3ework","@type":"Person","name":"fi3ework"},"datePublished":"2026-09-03T08:13:27Z","url":"https://github.com/rstackjs/rstack-editor/issues/39"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:47870eed-4657-3fe4-e90c-240c596fbdf1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A73E:12821C:14ED5F2:1C84396:6AEC4165 |
| html-safe-nonce | 9f98d305aa30ec1a0c7e610821528f6a4e306c3f24b88a7aaf9cf281d56c9580 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzNFOjEyODIxQzoxNEVENUYyOjFDODQzOTY6NkFFQzQxNjUiLCJ2aXNpdG9yX2lkIjoiNjc2Mjk0MDUzNzgzNzk5NDM0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3f006eea71e796ac9640c18befc26c2f22b46c64eccc609c36ee27a2dc8e9541 |
| hovercard-subject-tag | issue:5334070555 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/rstackjs/rstack-editor/39/issue_layout |
| twitter:image | https://opengraph.githubassets.com/56a0753b3af34f309eee5bb71e1d3948b00b5b9889abe64576bd7e7eba1aafe7/rstackjs/rstack-editor/issues/39 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/56a0753b3af34f309eee5bb71e1d3948b00b5b9889abe64576bd7e7eba1aafe7/rstackjs/rstack-editor/issues/39 |
| og:image:alt | Problem Changing rstack.rslint.trace.server restarts the whole extension instead of updating the trace level in place. trace.server is listed in the Rslint controller's restartOnSettings (packages/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fi3ework |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1dcf8db8e9101b96aecb2bc4e1fd095c110db63a7a140d8a7a9de997e07663e3 |
| turbo-cache-control | no-preview |
| go-import | github.com/rstackjs/rstack-editor git https://github.com/rstackjs/rstack-editor.git |
| octolytics-dimension-user_id | 129049372 |
| octolytics-dimension-user_login | rstackjs |
| octolytics-dimension-repository_id | 1316963958 |
| octolytics-dimension-repository_nwo | rstackjs/rstack-editor |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1316963958 |
| octolytics-dimension-repository_network_root_nwo | rstackjs/rstack-editor |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c248a9ae2572141cd7b35bf30a770cdc842dbc35 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width