René's URL Explorer Experiment


Title: fix(lint): respect --config in Rslint plugin workers by LucasIcarus · Pull Request #592 · rstackjs/rstack-cli · GitHub

Open Graph Title: fix(lint): respect --config in Rslint plugin workers by LucasIcarus · Pull Request #592 · rstackjs/rstack-cli

X Title: fix(lint): respect --config in Rslint plugin workers by LucasIcarus · Pull Request #592 · rstackjs/rstack-cli

Description: Motivation Rslint runs JS plugin rules in worker threads that import Rstack's internal lint config again. The --config path only exists in the main thread's state, so the workers look for rstack.config.* in cwd. If the selected config has JS plugin rules, rs lint -c from a directory without a config fails with worker exited during init, and if a config in cwd registers the same plugin name, the workers silently run that config's implementation instead. rs check -c is affected the same way. See #591. Changes Before starting Rslint, rs lint and rs check set RSTACK_CLI_CONFIG_PATH to the resolved --config path, and the internal lint config passes it to loadRstackConfig(). Worker threads inherit the variable. Nothing else reads it, so other commands and programmatic loadRstackConfig() calls are unchanged. Without --config, the variable is cleared, so an inherited value is ignored. The new tests cover a cwd without a config, a cwd config that registers the same plugin name, and an inherited variable without --config. rs check -c was checked by hand. files, ignores and the implicit tsconfig.json lookup still resolve from cwd when --config points elsewhere. That is left to #591.

Open Graph Description: Motivation Rslint runs JS plugin rules in worker threads that import Rstack's internal lint config again. The --config path only exists in the main thread's state, so the workers look for r...

X Description: Motivation Rslint runs JS plugin rules in worker threads that import Rstack's internal lint config again. The --config path only exists in the main thread's state, so the workers lo...

Opengraph URL: https://github.com/rstackjs/rstack-cli/pull/592

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:747d64c6-8db9-186d-f016-eb1647b48b2d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2EA:192017:EF843F:142F05F:6AEC20F5
html-safe-nonceb938cab960b9bb08c4dc8d1f752ed084eb83e416987d27826cdae0d2809e9abd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkVBOjE5MjAxNzpFRjg0M0Y6MTQyRjA1Rjo2QUVDMjBGNSIsInZpc2l0b3JfaWQiOiI1ODAxNTIxMTQwOTQ0NjA5NTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3437d3030cb80737675614682250559f17664aaee971507215be923b7b37e3dd
hovercard-subject-tagpull_request:4979281458
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/rstackjs/rstack-cli/pull/592/files
twitter:imagehttps://avatars.githubusercontent.com/u/15810641?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15810641?s=400&v=4
og:image:altMotivation Rslint runs JS plugin rules in worker threads that import Rstack's internal lint config again. The --config path only exists in the main thread's state, so the workers look for r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned063d52022f5f270ef55a70761d126c8085d492d3c251084b07781784c02dad4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/rstackjs/rstack-cli git https://github.com/rstackjs/rstack-cli.git
octolytics-dimension-user_id129049372
octolytics-dimension-user_loginrstackjs
octolytics-dimension-repository_id1138027854
octolytics-dimension-repository_nworstackjs/rstack-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1138027854
octolytics-dimension-repository_network_root_nworstackjs/rstack-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56e59340194011ba3cb6809acfa979ccbd174288
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/rstackjs/rstack-cli/pull/592/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frstackjs%2Frstack-cli%2Fpull%2F592%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frstackjs%2Frstack-cli%2Fpull%2F592%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=rstackjs%2Frstack-cli
Reloadhttps://github.com/rstackjs/rstack-cli/pull/592/files
Reloadhttps://github.com/rstackjs/rstack-cli/pull/592/files
Reloadhttps://github.com/rstackjs/rstack-cli/pull/592/files
rstackjshttps://github.com/rstackjs
rstack-clihttps://github.com/rstackjs/rstack-cli
Codehttps://github.com/rstackjs/rstack-cli
Issues3 (3)https://github.com/rstackjs/rstack-cli/issues
Pull requests1 (1)https://github.com/rstackjs/rstack-cli/pulls
Discussionshttps://github.com/rstackjs/rstack-cli/discussions
Actionshttps://github.com/rstackjs/rstack-cli/actions
Projectshttps://github.com/rstackjs/rstack-cli/projects
Security and qualityhttps://github.com/rstackjs/rstack-cli/security
Insightshttps://github.com/rstackjs/rstack-cli/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Frstackjs%2Frstack-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Frstackjs%2Frstack-cli%2Fissues%2Fnew%2Fchoose
chenjiahanhttps://github.com/chenjiahan
rstackjs:mainhttps://github.com/rstackjs/rstack-cli/tree/main
LucasIcarus:fix-lint-config-in-workershttps://github.com/LucasIcarus/rstack-cli/tree/fix-lint-config-in-workers
Conversation 1 https://github.com/rstackjs/rstack-cli/pull/592
Commits 1 https://github.com/rstackjs/rstack-cli/pull/592/commits
Checks 4 https://github.com/rstackjs/rstack-cli/pull/592/checks
Files changed https://github.com/rstackjs/rstack-cli/pull/592/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/592/files
fix(lint): respect --config in Rslint plugin workers https://github.com/rstackjs/rstack-cli/pull/592/files#top
Show all changes 1 commit https://github.com/rstackjs/rstack-cli/pull/592/files
bd2406e fix(lint): respect --config in Rslint plugin workers LucasIcarus Oct 23, 2026 https://github.com/rstackjs/rstack-cli/pull/592/commits/bd2406e007677879fb3c500664418969d0424afa
Clear filters https://github.com/rstackjs/rstack-cli/pull/592/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/592/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/592/files
commands.ts https://github.com/rstackjs/rstack-cli/pull/592/files#diff-c3b0123d5d69dcc527de6fe3cd48cff2e1405a8a325238837f3b847ee2ac5823
config.ts https://github.com/rstackjs/rstack-cli/pull/592/files#diff-56cb682bbca3cc1d4f4dccec2feef18640fbe2307c696e5486e813ef96fac871
rslintConfig.ts https://github.com/rstackjs/rstack-cli/pull/592/files#diff-03f02101a3d10b23d1bf734f30dd06d67a93a58ea55488b9ddf9831e521aa396
index.test.ts https://github.com/rstackjs/rstack-cli/pull/592/files#diff-eac001b7d24449d378ee64d5bfe8265e5e769157830f9522cbd059b1e2b921a7
rstack.config.ts https://github.com/rstackjs/rstack-cli/pull/592/files#diff-1d70dce433f5e8833abb6566ba8a09a6de6358790dbd937cbbc296b48d3f621b
index.js https://github.com/rstackjs/rstack-cli/pull/592/files#diff-d05263747b7678cfb8e73fb09c92056b0a7d0c276ccbaae8862077b53d9d1f8b
rstack.config.ts https://github.com/rstackjs/rstack-cli/pull/592/files#diff-eda7d43599f562ace08a87c73fc423f859ca648c6d9d633e172ff40b5d2b8280
packages/rstack/src/cli/commands.tshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-c3b0123d5d69dcc527de6fe3cd48cff2e1405a8a325238837f3b847ee2ac5823
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/src/cli/commands.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/592/files#diff-c3b0123d5d69dcc527de6fe3cd48cff2e1405a8a325238837f3b847ee2ac5823
https://github.com/rstackjs/rstack-cli/pull/592/files#diff-c3b0123d5d69dcc527de6fe3cd48cff2e1405a8a325238837f3b847ee2ac5823
https://github.com/rstackjs/rstack-cli/pull/592/files#diff-c3b0123d5d69dcc527de6fe3cd48cff2e1405a8a325238837f3b847ee2ac5823
packages/rstack/src/config.tshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-56cb682bbca3cc1d4f4dccec2feef18640fbe2307c696e5486e813ef96fac871
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/src/config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/592/files#diff-56cb682bbca3cc1d4f4dccec2feef18640fbe2307c696e5486e813ef96fac871
https://github.com/rstackjs/rstack-cli/pull/592/files#diff-56cb682bbca3cc1d4f4dccec2feef18640fbe2307c696e5486e813ef96fac871
packages/rstack/src/rslintConfig.tshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-03f02101a3d10b23d1bf734f30dd06d67a93a58ea55488b9ddf9831e521aa396
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/src/rslintConfig.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/592/files#diff-03f02101a3d10b23d1bf734f30dd06d67a93a58ea55488b9ddf9831e521aa396
packages/rstack/tests/cli/specify-config-lint/index.test.tshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-eac001b7d24449d378ee64d5bfe8265e5e769157830f9522cbd059b1e2b921a7
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/tests/cli/specify-config-lint/index.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
packages/rstack/tests/cli/specify-config-lint/workspace/app/rstack.config.tshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-1d70dce433f5e8833abb6566ba8a09a6de6358790dbd937cbbc296b48d3f621b
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/tests/cli/specify-config-lint/workspace/app/rstack.config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
packages/rstack/tests/cli/specify-config-lint/workspace/app/src/index.jshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-d05263747b7678cfb8e73fb09c92056b0a7d0c276ccbaae8862077b53d9d1f8b
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/tests/cli/specify-config-lint/workspace/app/src/index.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
packages/rstack/tests/cli/specify-config-lint/workspace/rstack.config.tshttps://github.com/rstackjs/rstack-cli/pull/592/files#diff-eda7d43599f562ace08a87c73fc423f859ca648c6d9d633e172ff40b5d2b8280
View file https://github.com/LucasIcarus/rstack-cli/blob/bd2406e007677879fb3c500664418969d0424afa/packages/rstack/tests/cli/specify-config-lint/workspace/rstack.config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/592/{{ revealButtonHref }}
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/592/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.