René's URL Explorer Experiment


Title: perf(fmt): reuse formatter import promise by chenjiahan · Pull Request #589 · rstackjs/rstack-cli · GitHub

Open Graph Title: perf(fmt): reuse formatter import promise by chenjiahan · Pull Request #589 · rstackjs/rstack-cli

X Title: perf(fmt): reuse formatter import promise by chenjiahan · Pull Request #589 · rstackjs/rstack-cli

Description: Motivation Formatting each uncached file repeats a dynamic import() call even after the formatter module has loaded. Changes Add a cachedImport helper following Rsbuild: share pending and fulfilled imports, and clear rejected Promises to allow retries. Use it in the formatter worker while keeping imports after cache-hit checks so formatter dependencies still load lazily. Prior prototype profiling reduced cumulative repeat-import time across 8 workers from 829 ms to 49 ms. Whole-repository check medians were 16.61 s before and 16.64 s after (7 fresh-process runs, Node.js 22.16.0, --no-cache), so no stable end-to-end speedup was observed. These measurements predate the helper extraction. Validated package and native builds, 156 focused tests (including lazy loading, import reuse, and retry after rejection), lint, type checking, and formatting.

Open Graph Description: Motivation Formatting each uncached file repeats a dynamic import() call even after the formatter module has loaded. Changes Add a cachedImport helper following Rsbuild: share pending and fulfilled...

X Description: Motivation Formatting each uncached file repeats a dynamic import() call even after the formatter module has loaded. Changes Add a cachedImport helper following Rsbuild: share pending and fulfilled...

Opengraph URL: https://github.com/rstackjs/rstack-cli/pull/589

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a8e11092-d815-f2c4-501b-d0ec8734b63e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5B8:13B8B0:11E43EA:1825419:6AEC2C16
html-safe-nonce1c1b9f5b06471c1014c78c6de6a3a901e4b4bcb3e9ae928925165975fbde062f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUI4OjEzQjhCMDoxMUU0M0VBOjE4MjU0MTk6NkFFQzJDMTYiLCJ2aXNpdG9yX2lkIjoiMzE2NzM0MjA3NTc4MzUyNjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac881f9aacf7bf7bc2bb85c12fc5cf66a8d89bad4b632daa10052109588a8983fc
hovercard-subject-tagpull_request:4936160384
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/rstackjs/rstack-cli/pull/589/files
twitter:imagehttps://avatars.githubusercontent.com/u/7237365?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7237365?s=400&v=4
og:image:altMotivation Formatting each uncached file repeats a dynamic import() call even after the formatter module has loaded. Changes Add a cachedImport helper following Rsbuild: share pending and fulfilled...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef290b7f408d9675a032f84ceb13aaf80220f947c681b4c5d9a7560a59ee32f02
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/rstackjs/rstack-cli git https://github.com/rstackjs/rstack-cli.git
octolytics-dimension-user_id129049372
octolytics-dimension-user_loginrstackjs
octolytics-dimension-repository_id1138027854
octolytics-dimension-repository_nworstackjs/rstack-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1138027854
octolytics-dimension-repository_network_root_nworstackjs/rstack-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasead9a37a663eb727a42b8bacc5e035cc3a24dd058
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/rstackjs/rstack-cli/pull/589/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frstackjs%2Frstack-cli%2Fpull%2F589%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frstackjs%2Frstack-cli%2Fpull%2F589%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=rstackjs%2Frstack-cli
Reloadhttps://github.com/rstackjs/rstack-cli/pull/589/files
Reloadhttps://github.com/rstackjs/rstack-cli/pull/589/files
Reloadhttps://github.com/rstackjs/rstack-cli/pull/589/files
rstackjshttps://github.com/rstackjs
rstack-clihttps://github.com/rstackjs/rstack-cli
Codehttps://github.com/rstackjs/rstack-cli
Issues3 (3)https://github.com/rstackjs/rstack-cli/issues
Pull requests1 (1)https://github.com/rstackjs/rstack-cli/pulls
Discussionshttps://github.com/rstackjs/rstack-cli/discussions
Actionshttps://github.com/rstackjs/rstack-cli/actions
Projectshttps://github.com/rstackjs/rstack-cli/projects
Security and qualityhttps://github.com/rstackjs/rstack-cli/security
Insightshttps://github.com/rstackjs/rstack-cli/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Frstackjs%2Frstack-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Frstackjs%2Frstack-cli%2Fissues%2Fnew%2Fchoose
chenjiahanhttps://github.com/chenjiahan
mainhttps://github.com/rstackjs/rstack-cli/tree/main
chenjiahan/cache-fmt-import-promisehttps://github.com/rstackjs/rstack-cli/tree/chenjiahan/cache-fmt-import-promise
Conversation 2 https://github.com/rstackjs/rstack-cli/pull/589
Commits 2 https://github.com/rstackjs/rstack-cli/pull/589/commits
Checks 5 https://github.com/rstackjs/rstack-cli/pull/589/checks
Files changed https://github.com/rstackjs/rstack-cli/pull/589/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/589/files
perf(fmt): reuse formatter import promise https://github.com/rstackjs/rstack-cli/pull/589/files#top
Show all changes 2 commits https://github.com/rstackjs/rstack-cli/pull/589/files
74d6842 perf(fmt): reuse formatter import promise chenjiahan Oct 20, 2026 https://github.com/rstackjs/rstack-cli/pull/589/commits/74d68427b2f6c396431ff0ba0edca3b98e290b53
459fa4c refactor(fmt): use shared cached import helper chenjiahan Oct 20, 2026 https://github.com/rstackjs/rstack-cli/pull/589/commits/459fa4cd8f25d3cdf2b64354608d12ad2a1f8cfd
Clear filters https://github.com/rstackjs/rstack-cli/pull/589/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/589/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/589/files
cachedImport.ts https://github.com/rstackjs/rstack-cli/pull/589/files#diff-05857f0651bffb473a11662f26b7dbe54f36ef1451c447c5d53736d3974c0fee
worker.ts https://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
cachedImport.test.ts https://github.com/rstackjs/rstack-cli/pull/589/files#diff-66c9e28b77b7d4b2d781cea0a2e812f5506b7a02f6ab9096a5a5657a8c16c4dc
packages/rstack/src/cachedImport.tshttps://github.com/rstackjs/rstack-cli/pull/589/files#diff-05857f0651bffb473a11662f26b7dbe54f36ef1451c447c5d53736d3974c0fee
View file https://github.com/rstackjs/rstack-cli/blob/459fa4cd8f25d3cdf2b64354608d12ad2a1f8cfd/packages/rstack/src/cachedImport.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/589/{{ revealButtonHref }}
packages/rstack/src/fmt/worker.tshttps://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
View file https://github.com/rstackjs/rstack-cli/blob/459fa4cd8f25d3cdf2b64354608d12ad2a1f8cfd/packages/rstack/src/fmt/worker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/589/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
https://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
https://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
https://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
https://github.com/rstackjs/rstack-cli/pull/589/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
packages/rstack/tests/cachedImport.test.tshttps://github.com/rstackjs/rstack-cli/pull/589/files#diff-66c9e28b77b7d4b2d781cea0a2e812f5506b7a02f6ab9096a5a5657a8c16c4dc
View file https://github.com/rstackjs/rstack-cli/blob/459fa4cd8f25d3cdf2b64354608d12ad2a1f8cfd/packages/rstack/tests/cachedImport.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/589/{{ revealButtonHref }}
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/589/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.