René's URL Explorer Experiment


Title: fix(fmt): verify written output before caching it as clean by chenjiahan · Pull Request #481 · rstackjs/rstack-cli · GitHub

Open Graph Title: fix(fmt): verify written output before caching it as clean by chenjiahan · Pull Request #481 · rstackjs/rstack-cli

X Title: fix(fmt): verify written output before caching it as clean by chenjiahan · Pull Request #481 · rstackjs/rstack-cli

Description: Motivation Non-idempotent formatting can leave a file needing another pass while the cache reports it as clean, causing cached and uncached checks to disagree. Fixes #479. Changes Cache the checked input and its result so newly written content is verified on the next run. Keep the cache version unchanged and add one regression case comparing cached and uncached checks after writing. Validated with pnpm build, pnpm --filter rstack build:native, pnpm check, and pnpm test (374 passed, 1 skipped).

Open Graph Description: Motivation Non-idempotent formatting can leave a file needing another pass while the cache reports it as clean, causing cached and uncached checks to disagree. Fixes #479. Changes Cache the checked...

X Description: Motivation Non-idempotent formatting can leave a file needing another pass while the cache reports it as clean, causing cached and uncached checks to disagree. Fixes #479. Changes Cache the checked...

Opengraph URL: https://github.com/rstackjs/rstack-cli/pull/481

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c2d22bdb-58a8-93f3-bc05-7fdbb2b3eb2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD932:110ABC:F07825:1443F96:6AEC1E7A
html-safe-noncebfa64524bca8ae3d97954de89541f426fdad3d3539df6feebada10f24cd87d7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTMyOjExMEFCQzpGMDc4MjU6MTQ0M0Y5Njo2QUVDMUU3QSIsInZpc2l0b3JfaWQiOiI1MDExMzUyNjQyODc3Mzk4NjUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccd4347d09e0ce36423080949a5b2787ae5041957268ad6fa2aede4697e9c44d4
hovercard-subject-tagpull_request:4523317139
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/rstackjs/rstack-cli/pull/481/files
twitter:imagehttps://avatars.githubusercontent.com/u/7237365?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7237365?s=400&v=4
og:image:altMotivation Non-idempotent formatting can leave a file needing another pass while the cache reports it as clean, causing cached and uncached checks to disagree. Fixes #479. Changes Cache the checked...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned063d52022f5f270ef55a70761d126c8085d492d3c251084b07781784c02dad4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/rstackjs/rstack-cli git https://github.com/rstackjs/rstack-cli.git
octolytics-dimension-user_id129049372
octolytics-dimension-user_loginrstackjs
octolytics-dimension-repository_id1138027854
octolytics-dimension-repository_nworstackjs/rstack-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1138027854
octolytics-dimension-repository_network_root_nworstackjs/rstack-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56e59340194011ba3cb6809acfa979ccbd174288
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/rstackjs/rstack-cli/pull/481/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frstackjs%2Frstack-cli%2Fpull%2F481%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frstackjs%2Frstack-cli%2Fpull%2F481%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=rstackjs%2Frstack-cli
Reloadhttps://github.com/rstackjs/rstack-cli/pull/481/files
Reloadhttps://github.com/rstackjs/rstack-cli/pull/481/files
Reloadhttps://github.com/rstackjs/rstack-cli/pull/481/files
rstackjshttps://github.com/rstackjs
rstack-clihttps://github.com/rstackjs/rstack-cli
Codehttps://github.com/rstackjs/rstack-cli
Issues3 (3)https://github.com/rstackjs/rstack-cli/issues
Pull requests1 (1)https://github.com/rstackjs/rstack-cli/pulls
Discussionshttps://github.com/rstackjs/rstack-cli/discussions
Actionshttps://github.com/rstackjs/rstack-cli/actions
Projectshttps://github.com/rstackjs/rstack-cli/projects
Security and qualityhttps://github.com/rstackjs/rstack-cli/security
Insightshttps://github.com/rstackjs/rstack-cli/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Frstackjs%2Frstack-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Frstackjs%2Frstack-cli%2Fissues%2Fnew%2Fchoose
chenjiahanhttps://github.com/chenjiahan
mainhttps://github.com/rstackjs/rstack-cli/tree/main
chenjiahan/fix-fmt-cache-outputhttps://github.com/rstackjs/rstack-cli/tree/chenjiahan/fix-fmt-cache-output
Conversation 2 https://github.com/rstackjs/rstack-cli/pull/481
Commits 1 https://github.com/rstackjs/rstack-cli/pull/481/commits
Checks 5 https://github.com/rstackjs/rstack-cli/pull/481/checks
Files changed https://github.com/rstackjs/rstack-cli/pull/481/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/481/files
fix(fmt): verify written output before caching it as clean https://github.com/rstackjs/rstack-cli/pull/481/files#top
Show all changes 1 commit https://github.com/rstackjs/rstack-cli/pull/481/files
c6c0e60 fix(fmt): verify written output before caching it as clean chenjiahan Sep 14, 2026 https://github.com/rstackjs/rstack-cli/pull/481/commits/c6c0e60eecab0d069aede2ce5c3ee3cb42c3ba0d
Clear filters https://github.com/rstackjs/rstack-cli/pull/481/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/481/files
Please reload this pagehttps://github.com/rstackjs/rstack-cli/pull/481/files
worker.ts https://github.com/rstackjs/rstack-cli/pull/481/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
cache.test.ts https://github.com/rstackjs/rstack-cli/pull/481/files#diff-7d9b7d70fcd9cad8662dbb1c55d81aa00ee70887f031da1049f972a9a70eb785
runnerCache.test.ts https://github.com/rstackjs/rstack-cli/pull/481/files#diff-ac9333e53eacec5dbd032bf07b0e49ae0fa3b67f3424d7ec9f979e0aa63d5bb9
packages/rstack/src/fmt/worker.tshttps://github.com/rstackjs/rstack-cli/pull/481/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
View file https://github.com/rstackjs/rstack-cli/blob/c6c0e60eecab0d069aede2ce5c3ee3cb42c3ba0d/packages/rstack/src/fmt/worker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/481/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-77a7a809e4d39364808b4c6d3f4721210581006550335eb3f363d6cd749de424
packages/rstack/tests/cli/fmt/cache.test.tshttps://github.com/rstackjs/rstack-cli/pull/481/files#diff-7d9b7d70fcd9cad8662dbb1c55d81aa00ee70887f031da1049f972a9a70eb785
View file https://github.com/rstackjs/rstack-cli/blob/c6c0e60eecab0d069aede2ce5c3ee3cb42c3ba0d/packages/rstack/tests/cli/fmt/cache.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/481/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-7d9b7d70fcd9cad8662dbb1c55d81aa00ee70887f031da1049f972a9a70eb785
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-7d9b7d70fcd9cad8662dbb1c55d81aa00ee70887f031da1049f972a9a70eb785
packages/rstack/tests/fmt/runnerCache.test.tshttps://github.com/rstackjs/rstack-cli/pull/481/files#diff-ac9333e53eacec5dbd032bf07b0e49ae0fa3b67f3424d7ec9f979e0aa63d5bb9
View file https://github.com/rstackjs/rstack-cli/blob/c6c0e60eecab0d069aede2ce5c3ee3cb42c3ba0d/packages/rstack/tests/fmt/runnerCache.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/rstackjs/rstack-cli/pull/481/{{ revealButtonHref }}
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-ac9333e53eacec5dbd032bf07b0e49ae0fa3b67f3424d7ec9f979e0aa63d5bb9
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-ac9333e53eacec5dbd032bf07b0e49ae0fa3b67f3424d7ec9f979e0aa63d5bb9
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-ac9333e53eacec5dbd032bf07b0e49ae0fa3b67f3424d7ec9f979e0aa63d5bb9
https://github.com/rstackjs/rstack-cli/pull/481/files#diff-ac9333e53eacec5dbd032bf07b0e49ae0fa3b67f3424d7ec9f979e0aa63d5bb9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.