| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:13bcc80e-3857-a472-d237-224e6499fdf4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB14:70F23:66EFF0:8D08B6:69824A15 |
| html-safe-nonce | a2c2d476f7e5958ad323c388dad6d71580aff0ad628b733120940f428accbf59 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjE0OjcwRjIzOjY2RUZGMDo4RDA4QjY6Njk4MjRBMTUiLCJ2aXNpdG9yX2lkIjoiNTI0MTU4OTQ1ODU4Njk3ODgzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5b12a540a53e358245a0466283974299cdb3db70efde6655f1b23a5348f03c2e |
| hovercard-subject-tag | pull_request:374600763 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ros2-java/ros2_java/85/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0a4b3d4fa0cace5b3977e6a812672ceeb0ae2c86e0dea4031ef9bae06138a264/ros2-java/ros2_java/pull/85 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0a4b3d4fa0cace5b3977e6a812672ceeb0ae2c86e0dea4031ef9bae06138a264/ros2-java/ros2_java/pull/85 |
| og:image:alt | Depends on #76 in order for tests to pass.
Re-enable the service-related tests with some modifications. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jacobperron |
| hostname | github.com |
| expected-hostname | github.com |
| None | e2ebc70d7d37443ffd1ae8f91a253417e0725a69916687ec3b823f2451fb6caa |
| turbo-cache-control | no-preview |
| go-import | github.com/ros2-java/ros2_java git https://github.com/ros2-java/ros2_java.git |
| octolytics-dimension-user_id | 23436176 |
| octolytics-dimension-user_login | ros2-java |
| octolytics-dimension-repository_id | 52850323 |
| octolytics-dimension-repository_nwo | ros2-java/ros2_java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 52850323 |
| octolytics-dimension-repository_network_root_nwo | ros2-java/ros2_java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6241ad74f49cf194bf94dad6a72d8792f1c2ab10 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/ros2-java/ros2_java/pull/85#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F85 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F85 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ros2-java%2Fros2_java |
| Reload | https://github.com/ros2-java/ros2_java/pull/85 |
| Reload | https://github.com/ros2-java/ros2_java/pull/85 |
| Reload | https://github.com/ros2-java/ros2_java/pull/85 |
|
ros2-java
| https://github.com/ros2-java |
| ros2_java | https://github.com/ros2-java/ros2_java |
|
Notifications
| https://github.com/login?return_to=%2Fros2-java%2Fros2_java |
|
Fork
108
| https://github.com/login?return_to=%2Fros2-java%2Fros2_java |
|
Star
199
| https://github.com/login?return_to=%2Fros2-java%2Fros2_java |
|
Code
| https://github.com/ros2-java/ros2_java |
|
Issues
54
| https://github.com/ros2-java/ros2_java/issues |
|
Pull requests
9
| https://github.com/ros2-java/ros2_java/pulls |
|
Actions
| https://github.com/ros2-java/ros2_java/actions |
|
Projects
0
| https://github.com/ros2-java/ros2_java/projects |
|
Security
0
| https://github.com/ros2-java/ros2_java/security |
|
Insights
| https://github.com/ros2-java/ros2_java/pulse |
|
Code
| https://github.com/ros2-java/ros2_java |
|
Issues
| https://github.com/ros2-java/ros2_java/issues |
|
Pull requests
| https://github.com/ros2-java/ros2_java/pulls |
|
Actions
| https://github.com/ros2-java/ros2_java/actions |
|
Projects
| https://github.com/ros2-java/ros2_java/projects |
|
Security
| https://github.com/ros2-java/ros2_java/security |
|
Insights
| https://github.com/ros2-java/ros2_java/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fros2-java%2Fros2_java%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fros2-java%2Fros2_java%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/ros2-java/ros2_java/pull/85#issue-comment-box |
| esteve | https://github.com/esteve |
| dashing | https://github.com/ros2-java/ros2_java/tree/dashing |
| wait_for_service | https://github.com/ros2-java/ros2_java/tree/wait_for_service |
|
Add Client methods for checking and waiting for service availability
| https://github.com/ros2-java/ros2_java/pull/85#top |
| esteve | https://github.com/esteve |
| dashing | https://github.com/ros2-java/ros2_java/tree/dashing |
| wait_for_service | https://github.com/ros2-java/ros2_java/tree/wait_for_service |
|
Conversation
2
| https://github.com/ros2-java/ros2_java/pull/85 |
|
Commits
3
| https://github.com/ros2-java/ros2_java/pull/85/commits |
|
Checks
0
| https://github.com/ros2-java/ros2_java/pull/85/checks |
|
Files changed
| https://github.com/ros2-java/ros2_java/pull/85/files |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/85 |
| https://github.co/hiddenchars |
| https://github.com/ros2-java/ros2_java/pull/{{ revealButtonHref }} |
|
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| Feb 12, 2020 | https://github.com/ros2-java/ros2_java/pull/85#issue-564353195 |
| #76 | https://github.com/ros2-java/ros2_java/pull/76 |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/85 |
| jacobperron | https://github.com/jacobperron |
| February 12, 2020 15:37 | https://github.com/ros2-java/ros2_java/pull/85#commits-pushed-e76a2a2 |
|
| https://github.com/jacobperron |
| Re-enable tests related to services | https://github.com/ros2-java/ros2_java/pull/85/commits/e76a2a25f8732953b87da464722d85e6b64178e5 |
| e76a2a2 | https://github.com/ros2-java/ros2_java/pull/85/commits/e76a2a25f8732953b87da464722d85e6b64178e5 |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability | https://github.com/ros2-java/ros2_java/pull/85/commits/05ab20c8818baa86c21a498d14f2edaff9c7829e |
| 05ab20c | https://github.com/ros2-java/ros2_java/pull/85/commits/05ab20c8818baa86c21a498d14f2edaff9c7829e |
|
| https://github.com/jacobperron |
| Refactor ClientTest to avoid repeatedly sending requests | https://github.com/ros2-java/ros2_java/pull/85/commits/09b538246e9e024c7109cc3f55e22f3cffaa13da |
| 09b5382 | https://github.com/ros2-java/ros2_java/pull/85/commits/09b538246e9e024c7109cc3f55e22f3cffaa13da |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
|
Feb 12, 2020
| https://github.com/ros2-java/ros2_java/pull/85#ref-pullrequest-564353462 |
|
Wait for service before making request
ros2-java/ros2_java_examples#6
| https://github.com/ros2-java/ros2_java_examples/pull/6 |
| https://github.com/clalancette |
| clalancette | https://github.com/clalancette |
|
Feb 26, 2020
| https://github.com/ros2-java/ros2_java/pull/85#pullrequestreview-365210725 |
|
View reviewed changes
| https://github.com/ros2-java/ros2_java/pull/85/files/09b538246e9e024c7109cc3f55e22f3cffaa13da |
| clalancette | https://github.com/clalancette |
| https://github.com/ros2-java/ros2_java/pull/85#pullrequestreview-365210725 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/85 |
| https://github.com/esteve |
| esteve | https://github.com/esteve |
| Feb 27, 2020 | https://github.com/ros2-java/ros2_java/pull/85#issuecomment-592033463 |
| @jacobperron | https://github.com/jacobperron |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/85 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| Mar 10, 2020 | https://github.com/ros2-java/ros2_java/pull/85#event-3112832565 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
|
enhancement
| https://github.com/ros2-java/ros2_java/issues?q=state%3Aopen%20label%3Aenhancement |
| Mar 10, 2020 | https://github.com/ros2-java/ros2_java/pull/85#event-3112833012 |
| https://github.com/esteve |
| esteve | https://github.com/esteve |
|
May 7, 2020
| https://github.com/ros2-java/ros2_java/pull/85#pullrequestreview-407421380 |
|
View reviewed changes
| https://github.com/ros2-java/ros2_java/pull/85/files/09b538246e9e024c7109cc3f55e22f3cffaa13da |
| https://github.com/esteve |
| esteve | https://github.com/esteve |
| 7bddf8e | https://github.com/ros2-java/ros2_java/commit/7bddf8e6e2490f98853e3c796089596458d6dca7 |
| May 7, 2020 | https://github.com/ros2-java/ros2_java/pull/85#event-3312656418 |
| https://github.com/esteve |
| esteve | https://github.com/esteve |
| May 7, 2020 12:28 | https://github.com/ros2-java/ros2_java/pull/85#event-3312656825 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/85#ref-commit-0190b11 |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability ( | https://github.com/osrf/ros2_java/commit/0190b11139a142af83d76a1e917b1a2b9196f605 |
| #… | https://github.com/osrf/ros2_java/pull/85 |
| 0190b11 | https://github.com/osrf/ros2_java/commit/0190b11139a142af83d76a1e917b1a2b9196f605 |
| …85 | https://github.com/osrf/ros2_java/pull/85 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/85#ref-pullrequest-739435846 |
|
Sync with upstream dashing branch
osrf/ros2_java#48
| https://github.com/osrf/ros2_java/pull/48 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/85#ref-commit-d28fde1 |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability ( | https://github.com/osrf/ros2_java/commit/d28fde11bb50d352f7ae01bb30b6eff62ebc9abb |
| #… | https://github.com/osrf/ros2_java/pull/85 |
| d28fde1 | https://github.com/osrf/ros2_java/commit/d28fde11bb50d352f7ae01bb30b6eff62ebc9abb |
| …85 | https://github.com/osrf/ros2_java/pull/85 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/85#ref-commit-94e53fb |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability ( | https://github.com/osrf/ros2_java/commit/94e53fb057b0482f08fcac8293d2d9fab36ffb2c |
| #… | https://github.com/osrf/ros2_java/pull/85 |
| 94e53fb | https://github.com/osrf/ros2_java/commit/94e53fb057b0482f08fcac8293d2d9fab36ffb2c |
| …85 | https://github.com/osrf/ros2_java/pull/85 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/85#ref-commit-1f48964 |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability ( | https://github.com/osrf/ros2_java/commit/1f48964894ada730da0f9669ac9f9feaed251a90 |
| #… | https://github.com/osrf/ros2_java/pull/85 |
| 1f48964 | https://github.com/osrf/ros2_java/commit/1f48964894ada730da0f9669ac9f9feaed251a90 |
| …85 | https://github.com/osrf/ros2_java/pull/85 |
| jacobperron | https://github.com/jacobperron |
|
May 17, 2021
| https://github.com/ros2-java/ros2_java/pull/85#ref-commit-8403e70 |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability ( | https://github.com/ros2-java/ros2_java/commit/8403e7061d741fc3fd47109dbe9500bb367dac6e |
| #… | https://github.com/ros2-java/ros2_java/pull/85 |
| 8403e70 | https://github.com/ros2-java/ros2_java/commit/8403e7061d741fc3fd47109dbe9500bb367dac6e |
| …85 | https://github.com/ros2-java/ros2_java/pull/85 |
| jacobperron | https://github.com/jacobperron |
|
May 17, 2021
| https://github.com/ros2-java/ros2_java/pull/85#ref-commit-81678ab |
|
| https://github.com/jacobperron |
| Add Client methods for checking and waiting for service availability ( | https://github.com/ros2-java/ros2_java/commit/81678abc53a7ab3d6b61e0d87e071cb0901809b8 |
| #… | https://github.com/ros2-java/ros2_java/pull/85 |
| 81678ab | https://github.com/ros2-java/ros2_java/commit/81678abc53a7ab3d6b61e0d87e071cb0901809b8 |
| …85 | https://github.com/ros2-java/ros2_java/pull/85 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F85 |
|
| https://github.com/esteve |
|
esteve
| https://github.com/esteve |
|
| https://github.com/ros2-java/ros2_java/pull/85/files/09b538246e9e024c7109cc3f55e22f3cffaa13da |
|
| https://github.com/clalancette |
|
clalancette
| https://github.com/clalancette |
|
| https://github.com/ros2-java/ros2_java/pull/85/files/09b538246e9e024c7109cc3f55e22f3cffaa13da |
|
| https://github.com/jacobperron |
|
jacobperron
| https://github.com/jacobperron |
|
enhancement
| https://github.com/ros2-java/ros2_java/issues?q=state%3Aopen%20label%3Aenhancement |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/85 |
|
| https://github.com/jacobperron |
|
| https://github.com/esteve |
|
| https://github.com/clalancette |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |