| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bb50f755-9313-0a5d-926e-4f959f71b691 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B098:9C3C1:3097D6:435182:6980D96F |
| html-safe-nonce | 2a329eb75ff9ff6f6f6de87de3238ee657e0de4467a661347d0c8e68e08b9bfd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDk4OjlDM0MxOjMwOTdENjo0MzUxODI6Njk4MEQ5NkYiLCJ2aXNpdG9yX2lkIjoiNjE2NTMxNzM2NDk1MTg2NTcxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2b39129e2a09c654971c74d80b4f34108572aa1932f95dd74e76c29845595106 |
| hovercard-subject-tag | pull_request:506362643 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ros2-java/ros2_java/140/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e0a66033f4db498a8228979914edb56751ed8cc19ad44d1cd9151d0d93af30ac/ros2-java/ros2_java/pull/140 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e0a66033f4db498a8228979914edb56751ed8cc19ad44d1cd9151d0d93af30ac/ros2-java/ros2_java/pull/140 |
| og:image:alt | Though service generation was fixed in #76, the new files were not added to the CMakeLists.txt for compilation. This PR contains the following:
Clean up some redundant code generation (7da1faf)
Fi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jacobperron |
| hostname | github.com |
| expected-hostname | github.com |
| None | 17bc0924c8593587ed4a8ae12c6076d0895c5516aaa44daccbb68ede54878b1f |
| turbo-cache-control | no-preview |
| go-import | github.com/ros2-java/ros2_java git https://github.com/ros2-java/ros2_java.git |
| octolytics-dimension-user_id | 23436176 |
| octolytics-dimension-user_login | ros2-java |
| octolytics-dimension-repository_id | 52850323 |
| octolytics-dimension-repository_nwo | ros2-java/ros2_java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 52850323 |
| octolytics-dimension-repository_network_root_nwo | ros2-java/ros2_java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 602fb6e6fec65cf4baabc1305db1830bc609c154 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/ros2-java/ros2_java/pull/140#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F140 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F140 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ros2-java%2Fros2_java |
| Reload | https://github.com/ros2-java/ros2_java/pull/140 |
| Reload | https://github.com/ros2-java/ros2_java/pull/140 |
| Reload | https://github.com/ros2-java/ros2_java/pull/140 |
|
ros2-java
| https://github.com/ros2-java |
| ros2_java | https://github.com/ros2-java/ros2_java |
|
Notifications
| https://github.com/login?return_to=%2Fros2-java%2Fros2_java |
|
Fork
108
| https://github.com/login?return_to=%2Fros2-java%2Fros2_java |
|
Star
199
| https://github.com/login?return_to=%2Fros2-java%2Fros2_java |
|
Code
| https://github.com/ros2-java/ros2_java |
|
Issues
54
| https://github.com/ros2-java/ros2_java/issues |
|
Pull requests
9
| https://github.com/ros2-java/ros2_java/pulls |
|
Actions
| https://github.com/ros2-java/ros2_java/actions |
|
Projects
0
| https://github.com/ros2-java/ros2_java/projects |
|
Security
0
| https://github.com/ros2-java/ros2_java/security |
|
Insights
| https://github.com/ros2-java/ros2_java/pulse |
|
Code
| https://github.com/ros2-java/ros2_java |
|
Issues
| https://github.com/ros2-java/ros2_java/issues |
|
Pull requests
| https://github.com/ros2-java/ros2_java/pulls |
|
Actions
| https://github.com/ros2-java/ros2_java/actions |
|
Projects
| https://github.com/ros2-java/ros2_java/projects |
|
Security
| https://github.com/ros2-java/ros2_java/security |
|
Insights
| https://github.com/ros2-java/ros2_java/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fros2-java%2Fros2_java%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fros2-java%2Fros2_java%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/ros2-java/ros2_java/pull/140#issue-comment-box |
| jacobperron | https://github.com/jacobperron |
| dashing | https://github.com/ros2-java/ros2_java/tree/dashing |
| jacob/fix_action_generation | https://github.com/ros2-java/ros2_java/tree/jacob/fix_action_generation |
|
Compile generated action-related services
| https://github.com/ros2-java/ros2_java/pull/140#top |
| jacobperron | https://github.com/jacobperron |
| dashing | https://github.com/ros2-java/ros2_java/tree/dashing |
| jacob/fix_action_generation | https://github.com/ros2-java/ros2_java/tree/jacob/fix_action_generation |
|
Conversation
6
| https://github.com/ros2-java/ros2_java/pull/140 |
|
Commits
4
| https://github.com/ros2-java/ros2_java/pull/140/commits |
|
Checks
0
| https://github.com/ros2-java/ros2_java/pull/140/checks |
|
Files changed
| https://github.com/ros2-java/ros2_java/pull/140/files |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/140 |
| https://github.co/hiddenchars |
| https://github.com/ros2-java/ros2_java/pull/{{ revealButtonHref }} |
|
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| Oct 20, 2020 | https://github.com/ros2-java/ros2_java/pull/140#issue-725074327 |
| #76 | https://github.com/ros2-java/ros2_java/pull/76 |
| 7da1faf | https://github.com/ros2-java/ros2_java/commit/7da1faff84178fd7d407a4b08fcf7ada4c392bbc |
| 50d2789 | https://github.com/ros2-java/ros2_java/commit/50d2789764d7c55054805fb3187a3b5dc91fb1fa |
| e1a70cf | https://github.com/ros2-java/ros2_java/commit/e1a70cf145f8cbbafbe738b50e56b9fa2f72ef5e |
| 86b4240 | https://github.com/ros2-java/ros2_java/commit/86b4240b17c76e162ad5f8c452b19bd5a9e36a01 |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/140 |
| jacobperron | https://github.com/jacobperron |
| October 20, 2020 00:06 | https://github.com/ros2-java/ros2_java/pull/140#commits-pushed-7da1faf |
|
| https://github.com/jacobperron |
| Remove redundant code generation | https://github.com/ros2-java/ros2_java/pull/140/commits/7da1faff84178fd7d407a4b08fcf7ada4c392bbc |
| 7da1faf | https://github.com/ros2-java/ros2_java/pull/140/commits/7da1faff84178fd7d407a4b08fcf7ada4c392bbc |
|
| https://github.com/jacobperron |
| Strip action service suffixes from C include prefix | https://github.com/ros2-java/ros2_java/pull/140/commits/50d2789764d7c55054805fb3187a3b5dc91fb1fa |
| 50d2789 | https://github.com/ros2-java/ros2_java/pull/140/commits/50d2789764d7c55054805fb3187a3b5dc91fb1fa |
|
| https://github.com/jacobperron |
| Generate Java code for SendGoal and GetResult service definitions | https://github.com/ros2-java/ros2_java/pull/140/commits/e1a70cf145f8cbbafbe738b50e56b9fa2f72ef5e |
| e1a70cf | https://github.com/ros2-java/ros2_java/pull/140/commits/e1a70cf145f8cbbafbe738b50e56b9fa2f72ef5e |
|
| https://github.com/jacobperron |
| Compile generated service definitions for actions | https://github.com/ros2-java/ros2_java/pull/140/commits/86b4240b17c76e162ad5f8c452b19bd5a9e36a01 |
| 86b4240 | https://github.com/ros2-java/ros2_java/pull/140/commits/86b4240b17c76e162ad5f8c452b19bd5a9e36a01 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| Oct 20, 2020 | https://github.com/ros2-java/ros2_java/pull/140#event-3896024516 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| esteve | https://github.com/esteve |
| ivanpauno | https://github.com/ivanpauno |
| October 20, 2020 00:17 | https://github.com/ros2-java/ros2_java/pull/140#event-3896024779 |
|
Strip action service suffixes from C include prefix
ros2/rosidl#538
| https://github.com/ros2/rosidl/pull/538 |
|
ROS Actions
#138
| https://github.com/ros2-java/ros2_java/issues/138 |
| https://github.com/ivanpauno |
| ivanpauno | https://github.com/ivanpauno |
|
Oct 20, 2020
| https://github.com/ros2-java/ros2_java/pull/140#pullrequestreview-512755472 |
|
View reviewed changes
| https://github.com/ros2-java/ros2_java/pull/140/files/86b4240b17c76e162ad5f8c452b19bd5a9e36a01 |
| ivanpauno | https://github.com/ivanpauno |
| https://github.com/ros2-java/ros2_java/pull/140#pullrequestreview-512755472 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/140 |
| rosidl_generator_java/resource/msg.cpp.em | https://github.com/ros2-java/ros2_java/pull/140/files/86b4240b17c76e162ad5f8c452b19bd5a9e36a01#diff-21b7b52d426b9b687289f5bdaac8ea748f96a46e3e117c145acec10567d048ee |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/140 |
| rosidl_generator_java/resource/msg.cpp.em | https://github.com/ros2-java/ros2_java/pull/140/files/86b4240b17c76e162ad5f8c452b19bd5a9e36a01#diff-21b7b52d426b9b687289f5bdaac8ea748f96a46e3e117c145acec10567d048ee |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/140 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| 66d622c | https://github.com/ros2-java/ros2_java/commit/66d622c8a55f61f847654e1b9d8a4152d6b21a13 |
| Nov 9, 2020 | https://github.com/ros2-java/ros2_java/pull/140#event-3976087303 |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
| November 9, 2020 22:30 | https://github.com/ros2-java/ros2_java/pull/140#event-3976087491 |
| jacobperron | https://github.com/jacobperron |
|
Nov 9, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-ac275f6 |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/osrf/ros2_java/commit/ac275f64b6221270c9a9b66f309144305a68bd2d |
| ros2-java#140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/osrf/ros2_java/commit/ac275f64b6221270c9a9b66f309144305a68bd2d |
| ac275f6 | https://github.com/osrf/ros2_java/commit/ac275f64b6221270c9a9b66f309144305a68bd2d |
| https://github.com/jacobperron |
| jacobperron | https://github.com/jacobperron |
|
Nov 9, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-pullrequest-739435846 |
|
Sync with upstream dashing branch
osrf/ros2_java#48
| https://github.com/osrf/ros2_java/pull/48 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-bd03ae9 |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/osrf/ros2_java/commit/bd03ae99b3fa31c026fa949c812ff1173355495b |
| ros2-java#140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/osrf/ros2_java/commit/bd03ae99b3fa31c026fa949c812ff1173355495b |
| bd03ae9 | https://github.com/osrf/ros2_java/commit/bd03ae99b3fa31c026fa949c812ff1173355495b |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-75acd2e |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/osrf/ros2_java/commit/75acd2ea8391888e8bfc37de51acf3baf73263d9 |
| ros2-java#140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/osrf/ros2_java/commit/75acd2ea8391888e8bfc37de51acf3baf73263d9 |
| 75acd2e | https://github.com/osrf/ros2_java/commit/75acd2ea8391888e8bfc37de51acf3baf73263d9 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-75db094 |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/osrf/ros2_java/commit/75db0943c60c5d0b2f2fce18e9b00048d7058d22 |
| ros2-java#140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/osrf/ros2_java/commit/75db0943c60c5d0b2f2fce18e9b00048d7058d22 |
| 75db094 | https://github.com/osrf/ros2_java/commit/75db0943c60c5d0b2f2fce18e9b00048d7058d22 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-aa96c96 |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/osrf/ros2_java/commit/aa96c969500cb4e349418529b7c0f0fc756101b8 |
| ros2-java#140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/osrf/ros2_java/commit/aa96c969500cb4e349418529b7c0f0fc756101b8 |
| aa96c96 | https://github.com/osrf/ros2_java/commit/aa96c969500cb4e349418529b7c0f0fc756101b8 |
| jacobperron | https://github.com/jacobperron |
|
Nov 10, 2020
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-fcb45e2 |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/osrf/ros2_java/commit/fcb45e2d27515af23bedd650a697d90ab601d511 |
| ros2-java#140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/osrf/ros2_java/commit/fcb45e2d27515af23bedd650a697d90ab601d511 |
| fcb45e2 | https://github.com/osrf/ros2_java/commit/fcb45e2d27515af23bedd650a697d90ab601d511 |
| jacobperron | https://github.com/jacobperron |
|
May 17, 2021
| https://github.com/ros2-java/ros2_java/pull/140#ref-commit-885fa3f |
|
| https://github.com/jacobperron |
| Compile generated action-related services ( | https://github.com/ros2-java/ros2_java/commit/885fa3fc838d4d94529192e2e7685595482a6b74 |
| #140 | https://github.com/ros2-java/ros2_java/pull/140 |
| ) | https://github.com/ros2-java/ros2_java/commit/885fa3fc838d4d94529192e2e7685595482a6b74 |
| 885fa3f | https://github.com/ros2-java/ros2_java/commit/885fa3fc838d4d94529192e2e7685595482a6b74 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F140 |
|
| https://github.com/ivanpauno |
|
ivanpauno
| https://github.com/ivanpauno |
|
| https://github.com/ros2-java/ros2_java/pull/140/files/86b4240b17c76e162ad5f8c452b19bd5a9e36a01 |
|
| https://github.com/esteve |
|
esteve
| https://github.com/esteve |
|
| https://github.com/jacobperron |
|
jacobperron
| https://github.com/jacobperron |
| Please reload this page | https://github.com/ros2-java/ros2_java/pull/140 |
|
| https://github.com/jacobperron |
|
| https://github.com/ivanpauno |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |