| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9762c46b-5c04-db3c-8761-389e06291eea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 91A4:1BA4F9:162DCD:1CE2B8:6A4D94E6 |
| html-safe-nonce | c68392d063f88913d812ec96c103b978ea94fe995761c8fee5cb964f22947b85 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUE0OjFCQTRGOToxNjJEQ0Q6MUNFMkI4OjZBNEQ5NEU2IiwidmlzaXRvcl9pZCI6IjUyNDEzNDIxMDcxMzg3NTc4NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9dfa617e3cdcee2670cbc32a87c4cf91c934fa5f7a806b9a94fc05d48ca6b28e |
| hovercard-subject-tag | pull_request:1840309936 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ros-visualization/python_qt_binding/139/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1d68a33a977f14837b5af393a87b88e739ca3f9aaa43f43192a73825c7152370/ros-visualization/python_qt_binding/pull/139 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1d68a33a977f14837b5af393a87b88e739ca3f9aaa43f43192a73825c7152370/ros-visualization/python_qt_binding/pull/139 |
| og:image:alt | This PR #137 introduces a regresion. CMP0148 is new in CMake 3.27. The main CMakeLists.txt is using 3.5, I updated the cmake/shiboken_helper.cmake version to 3.5 too. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahcorde |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/ros-visualization/python_qt_binding git https://github.com/ros-visualization/python_qt_binding.git |
| octolytics-dimension-user_id | 2328629 |
| octolytics-dimension-user_login | ros-visualization |
| octolytics-dimension-repository_id | 5860977 |
| octolytics-dimension-repository_nwo | ros-visualization/python_qt_binding |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 5860977 |
| octolytics-dimension-repository_network_root_nwo | ros-visualization/python_qt_binding |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 74e2a9c78f1e38588de4f25885878349d721eedf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/ros-visualization/python_qt_binding/pull/139#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F139 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F139 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ros-visualization%2Fpython_qt_binding |
| Reload | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| Reload | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| Reload | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
|
ros-visualization
| https://github.com/ros-visualization |
| python_qt_binding | https://github.com/ros-visualization/python_qt_binding |
|
Notifications
| https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding |
|
Fork
63
| https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding |
|
Star
34
| https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding |
|
Code
| https://github.com/ros-visualization/python_qt_binding |
|
Issues
7
| https://github.com/ros-visualization/python_qt_binding/issues |
|
Pull requests
4
| https://github.com/ros-visualization/python_qt_binding/pulls |
|
Actions
| https://github.com/ros-visualization/python_qt_binding/actions |
|
Security and quality
0
| https://github.com/ros-visualization/python_qt_binding/security |
|
Insights
| https://github.com/ros-visualization/python_qt_binding/pulse |
|
Code
| https://github.com/ros-visualization/python_qt_binding |
|
Issues
| https://github.com/ros-visualization/python_qt_binding/issues |
|
Pull requests
| https://github.com/ros-visualization/python_qt_binding/pulls |
|
Actions
| https://github.com/ros-visualization/python_qt_binding/actions |
|
Security and quality
| https://github.com/ros-visualization/python_qt_binding/security |
|
Insights
| https://github.com/ros-visualization/python_qt_binding/pulse |
| clalancette | https://github.com/clalancette |
| rolling | https://github.com/ros-visualization/python_qt_binding/tree/rolling |
| ahcorde/rolling/cmake_shiboken | https://github.com/ros-visualization/python_qt_binding/tree/ahcorde/rolling/cmake_shiboken |
| Conversation | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| Commits2 (2) | https://github.com/ros-visualization/python_qt_binding/pull/139/commits |
| Checks | https://github.com/ros-visualization/python_qt_binding/pull/139/checks |
| Files changed | https://github.com/ros-visualization/python_qt_binding/pull/139/files |
| update cmake version | https://github.com/ros-visualization/python_qt_binding/pull/139#top |
| clalancette | https://github.com/clalancette |
| rolling | https://github.com/ros-visualization/python_qt_binding/tree/rolling |
| ahcorde/rolling/cmake_shiboken | https://github.com/ros-visualization/python_qt_binding/tree/ahcorde/rolling/cmake_shiboken |
|
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issue-2262940986 |
| #137 | https://github.com/ros-visualization/python_qt_binding/pull/137 |
| a regresion | https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_release/1874/console |
| CMP0148 | https://cmake.org/cmake/help/latest/policy/CMP0148.html |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
|
| https://github.com/ahcorde |
| update cmake version | https://github.com/ros-visualization/python_qt_binding/pull/139/commits/e50e52ef4e48fce3d877b9dfc84fba10757cce4b |
| e50e52e | https://github.com/ros-visualization/python_qt_binding/pull/139/commits/e50e52ef4e48fce3d877b9dfc84fba10757cce4b |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| sloretz | https://github.com/sloretz |
| code owner | https://github.com/ros-visualization/python_qt_binding/blob/e6b881ee5028e601a2f8aa844ec12b770831d38f/CODEOWNERS#L2 |
| April 25, 2024 07:59 | https://github.com/ros-visualization/python_qt_binding/pull/139#event-12603719543 |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| clalancette | https://github.com/clalancette |
| April 25, 2024 07:59 | https://github.com/ros-visualization/python_qt_binding/pull/139#event-12603720205 |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#event-12603720388 |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issuecomment-2076600110 |
| http://ci.ros2.org/job/nightly_linux-rhel_release/1875/ |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
|
| https://github.com/ahcorde |
| fix | https://github.com/ros-visualization/python_qt_binding/pull/139/commits/5720410c57b6b700ceb9b4498cee03ad1b261e9d |
| 5720410 | https://github.com/ros-visualization/python_qt_binding/pull/139/commits/5720410c57b6b700ceb9b4498cee03ad1b261e9d |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issuecomment-2076658540 |
| http://ci.ros2.org/job/nightly_linux-rhel_release/1876/ |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issuecomment-2076897278 |
| http://ci.ros2.org/job/ci_linux/20936/ |
| http://ci.ros2.org/job/ci_linux-aarch64/15227/ |
| http://ci.ros2.org/job/ci_windows/21610/ |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| https://github.com/clalancette |
| clalancette | https://github.com/clalancette |
|
Apr 25, 2024
| https://github.com/ros-visualization/python_qt_binding/pull/139#pullrequestreview-2022237736 |
|
View reviewed changes
| https://github.com/ros-visualization/python_qt_binding/pull/139/files/5720410c57b6b700ceb9b4498cee03ad1b261e9d |
| https://github.com/clalancette |
| clalancette | https://github.com/clalancette |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issuecomment-2076964746 |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| https://github.com/clalancette |
| clalancette | https://github.com/clalancette |
| 4fe5bce | https://github.com/ros-visualization/python_qt_binding/commit/4fe5bceb353f5dfcef4f78f9266c0983521bd7ac |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#event-12607594903 |
| https://github.com/clalancette |
| clalancette | https://github.com/clalancette |
| April 25, 2024 12:25 | https://github.com/ros-visualization/python_qt_binding/pull/139#event-12607595645 |
| https://github.com/clalancette |
| clalancette | https://github.com/clalancette |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issuecomment-2077061897 |
| @Mergifyio | https://github.com/Mergifyio |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| https://github.com/apps/mergify |
| mergify | https://github.com/apps/mergify |
| Apr 25, 2024 | https://github.com/ros-visualization/python_qt_binding/pull/139#issuecomment-2077062834 |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| #140 update cmake version (backport #139) | https://github.com/ros-visualization/python_qt_binding/pull/140 |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| mergify | https://github.com/apps/mergify |
|
Apr 25, 2024
| https://github.com/ros-visualization/python_qt_binding/pull/139#ref-commit-1220093 |
|
| https://github.com/ahcorde |
|
| https://github.com/marketplace/mergify |
| Only suppress Python warnings on new enough CMake ( | https://github.com/ros-visualization/python_qt_binding/commit/12200930bd76a43f245490baed6197662341efd7 |
| #139 | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| ) | https://github.com/ros-visualization/python_qt_binding/commit/12200930bd76a43f245490baed6197662341efd7 |
| 1220093 | https://github.com/ros-visualization/python_qt_binding/commit/12200930bd76a43f245490baed6197662341efd7 |
| 4fe5bce | https://github.com/ros-visualization/python_qt_binding/commit/4fe5bceb353f5dfcef4f78f9266c0983521bd7ac |
| https://github.com/apps/mergify |
| mergify | https://github.com/apps/mergify |
|
Apr 25, 2024
| https://github.com/ros-visualization/python_qt_binding/pull/139#ref-pullrequest-2263460039 |
|
update cmake version (backport #139)
#140
| https://github.com/ros-visualization/python_qt_binding/pull/140 |
| clalancette | https://github.com/clalancette |
|
Apr 25, 2024
| https://github.com/ros-visualization/python_qt_binding/pull/139#ref-commit-c30a87f |
|
| https://github.com/ahcorde |
|
| https://github.com/clalancette |
| Only suppress Python warnings on new enough CMake ( | https://github.com/ros-visualization/python_qt_binding/commit/c30a87f68e4ed39e1e2c21e1d4553824a23e285e |
| #139 | https://github.com/ros-visualization/python_qt_binding/pull/139 |
| ) | https://github.com/ros-visualization/python_qt_binding/commit/c30a87f68e4ed39e1e2c21e1d4553824a23e285e |
| c30a87f | https://github.com/ros-visualization/python_qt_binding/commit/c30a87f68e4ed39e1e2c21e1d4553824a23e285e |
| https://github.com/ahcorde |
| ahcorde | https://github.com/ahcorde |
|
Apr 25, 2024
| https://github.com/ros-visualization/python_qt_binding/pull/139#ref-pullrequest-2259019815 |
|
Suppress warning from Shiboken2.
#137
| https://github.com/ros-visualization/python_qt_binding/pull/137 |
| https://github.co/hiddenchars |
| https://github.com/ros-visualization/python_qt_binding/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F139 |
|
| https://github.com/clalancette |
|
clalancette
| https://github.com/clalancette |
|
| https://github.com/ros-visualization/python_qt_binding/pull/139/files/5720410c57b6b700ceb9b4498cee03ad1b261e9d |
|
| https://github.com/sloretz |
|
sloretz
| https://github.com/sloretz |
|
| https://github.com/ahcorde |
|
ahcorde
| https://github.com/ahcorde |
| Please reload this page | https://github.com/ros-visualization/python_qt_binding/pull/139 |
|
| https://github.com/ahcorde |
|
| https://github.com/clalancette |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |