René's URL Explorer Experiment


Title: Fix to allow ninja to use make for generators (#123) by yashi · Pull Request #128 · ros-visualization/python_qt_binding · GitHub

Open Graph Title: Fix to allow ninja to use make for generators (#123) by yashi · Pull Request #128 · ros-visualization/python_qt_binding

X Title: Fix to allow ninja to use make for generators (#123) by yashi · Pull Request #128 · ros-visualization/python_qt_binding

Description: Contribute to ros-visualization/python_qt_binding development by creating an account on GitHub.

Open Graph Description: This is a backport of upstream commit ade88c5. This allows ROS Humble LTS to be compiled with Ninja. Without this, colcon build with an environment variable CMAKE_GENERATOR=Ninja for packages depe...

X Description: This is a backport of upstream commit ade88c5. This allows ROS Humble LTS to be compiled with Ninja. Without this, colcon build with an environment variable CMAKE_GENERATOR=Ninja for packages depe...

Opengraph URL: https://github.com/ros-visualization/python_qt_binding/pull/128

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:616bb6d0-fe6c-2769-6b20-a3a240144340
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE70:75D13:7FAAF:B03CE:6A4C9106
html-safe-nonceef50557ff8f2c02b5874a0b37d3191d6332e57b9bb4bd57e68cd0284eb489240
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTcwOjc1RDEzOjdGQUFGOkIwM0NFOjZBNEM5MTA2IiwidmlzaXRvcl9pZCI6Ijg2NjA3NTQyNDUxMDI2MzczMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb43deae028d5f5c2571018c5f4fb37cd34871bbc2c4c1d50e6839d7d1f1ae449
hovercard-subject-tagpull_request:1535816045
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ros-visualization/python_qt_binding/128/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/43d570e97cb7437097a221c2e344bfd8ac6682660f24b82771a37e6b6d5c5556/ros-visualization/python_qt_binding/pull/128
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43d570e97cb7437097a221c2e344bfd8ac6682660f24b82771a37e6b6d5c5556/ros-visualization/python_qt_binding/pull/128
og:image:altThis is a backport of upstream commit ade88c5. This allows ROS Humble LTS to be compiled with Ninja. Without this, colcon build with an environment variable CMAKE_GENERATOR=Ninja for packages depe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyashi
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/ros-visualization/python_qt_binding git https://github.com/ros-visualization/python_qt_binding.git
octolytics-dimension-user_id2328629
octolytics-dimension-user_loginros-visualization
octolytics-dimension-repository_id5860977
octolytics-dimension-repository_nworos-visualization/python_qt_binding
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id5860977
octolytics-dimension-repository_network_root_nworos-visualization/python_qt_binding
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ros-visualization/python_qt_binding/pull/128#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F128
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F128
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ros-visualization%2Fpython_qt_binding
Reloadhttps://github.com/ros-visualization/python_qt_binding/pull/128
Reloadhttps://github.com/ros-visualization/python_qt_binding/pull/128
Reloadhttps://github.com/ros-visualization/python_qt_binding/pull/128
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/128
ros-visualization https://github.com/ros-visualization
python_qt_bindinghttps://github.com/ros-visualization/python_qt_binding
Notifications https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding
Fork 63 https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding
Star 34 https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding
Code https://github.com/ros-visualization/python_qt_binding
Issues 7 https://github.com/ros-visualization/python_qt_binding/issues
Pull requests 4 https://github.com/ros-visualization/python_qt_binding/pulls
Actions https://github.com/ros-visualization/python_qt_binding/actions
Security and quality 0 https://github.com/ros-visualization/python_qt_binding/security
Insights https://github.com/ros-visualization/python_qt_binding/pulse
Code https://github.com/ros-visualization/python_qt_binding
Issues https://github.com/ros-visualization/python_qt_binding/issues
Pull requests https://github.com/ros-visualization/python_qt_binding/pulls
Actions https://github.com/ros-visualization/python_qt_binding/actions
Security and quality https://github.com/ros-visualization/python_qt_binding/security
Insights https://github.com/ros-visualization/python_qt_binding/pulse
clalancettehttps://github.com/clalancette
ros-visualization:humblehttps://github.com/ros-visualization/python_qt_binding/tree/humble
yashi:backport-fix-to-allow-ninja-to-use-make-for-generatorshttps://github.com/yashi/python_qt_binding/tree/backport-fix-to-allow-ninja-to-use-make-for-generators
Conversationhttps://github.com/ros-visualization/python_qt_binding/pull/128
Commits1 (1)https://github.com/ros-visualization/python_qt_binding/pull/128/commits
Checkshttps://github.com/ros-visualization/python_qt_binding/pull/128/checks
Files changedhttps://github.com/ros-visualization/python_qt_binding/pull/128/files
Fix to allow ninja to use make for generators (#123)https://github.com/ros-visualization/python_qt_binding/pull/128#top
clalancettehttps://github.com/clalancette
ros-visualization:humblehttps://github.com/ros-visualization/python_qt_binding/tree/humble
yashi:backport-fix-to-allow-ninja-to-use-make-for-generatorshttps://github.com/yashi/python_qt_binding/tree/backport-fix-to-allow-ninja-to-use-make-for-generators
https://github.com/yashi
yashihttps://github.com/yashi
Sep 29, 2023https://github.com/ros-visualization/python_qt_binding/pull/128#issue-1919350665
ade88c5https://github.com/ros-visualization/python_qt_binding/commit/ade88c56e27bcb74732e8bd8475fbda00d722355
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/128
https://github.com/mjcarroll
https://github.com/clalancette
https://github.com/yashi
Fix to allow ninja to use make for generators (https://github.com/ros-visualization/python_qt_binding/pull/128/commits/566979a3c223fa134f6cdfe673f667159522684a
ros-visualization#123https://github.com/ros-visualization/python_qt_binding/pull/123
)https://github.com/ros-visualization/python_qt_binding/pull/128/commits/566979a3c223fa134f6cdfe673f667159522684a
566979ahttps://github.com/ros-visualization/python_qt_binding/pull/128/commits/566979a3c223fa134f6cdfe673f667159522684a
ade88c5https://github.com/yashi/python_qt_binding/commit/ade88c56e27bcb74732e8bd8475fbda00d722355
https://github.com/clalancette
clalancettehttps://github.com/clalancette
Oct 16, 2023 https://github.com/ros-visualization/python_qt_binding/pull/128#pullrequestreview-1680056843
View reviewed changes https://github.com/ros-visualization/python_qt_binding/pull/128/files/566979a3c223fa134f6cdfe673f667159522684a
clalancettehttps://github.com/clalancette
https://github.com/ros-visualization/python_qt_binding/pull/128#pullrequestreview-1680056843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/128
https://github.com/clalancette
clalancettehttps://github.com/clalancette
Oct 16, 2023https://github.com/ros-visualization/python_qt_binding/pull/128#issuecomment-1764545733
http://ci.ros2.org/job/ci_linux/19662/
http://ci.ros2.org/job/ci_linux-aarch64/14169/
http://ci.ros2.org/job/ci_windows/20385/
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/128
https://github.com/clalancette
clalancettehttps://github.com/clalancette
2cc0552https://github.com/ros-visualization/python_qt_binding/commit/2cc0552fe3be8861e889150725f39ca915fe59e4
Oct 17, 2023https://github.com/ros-visualization/python_qt_binding/pull/128#event-10678914877
https://github.com/yashi
yashihttps://github.com/yashi
October 17, 2023 13:54https://github.com/ros-visualization/python_qt_binding/pull/128#event-10678962051
https://github.co/hiddenchars
https://github.com/ros-visualization/python_qt_binding/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F128
https://github.com/clalancette
clalancette https://github.com/clalancette
https://github.com/ros-visualization/python_qt_binding/pull/128/files/566979a3c223fa134f6cdfe673f667159522684a
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/128
https://github.com/yashi
https://github.com/clalancette
https://github.com/mjcarroll
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.