René's URL Explorer Experiment


Title: Fix to allow ninja to use make for generators by mjcarroll · Pull Request #123 · ros-visualization/python_qt_binding · GitHub

Open Graph Title: Fix to allow ninja to use make for generators by mjcarroll · Pull Request #123 · ros-visualization/python_qt_binding

X Title: Fix to allow ninja to use make for generators by mjcarroll · Pull Request #123 · ros-visualization/python_qt_binding

Description: Contribute to ros-visualization/python_qt_binding development by creating an account on GitHub.

Open Graph Description: There is an issue when building qt_gui_cpp with ninja, and it is traced back to python_qt_binding. This allows ninja to find the make executable and use it for this particular step. The alternativ...

X Description: There is an issue when building qt_gui_cpp with ninja, and it is traced back to python_qt_binding. This allows ninja to find the make executable and use it for this particular step. The alternativ...

Opengraph URL: https://github.com/ros-visualization/python_qt_binding/pull/123

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca66a172-4f59-0a32-d72a-fd8af4fcf53c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95D6:ACE83:378408:4A8BF9:6A519086
html-safe-nonce1e735af3eb7d348ac60194f44beb5cdfad57d947cafb6a228a762852ef9e4ca2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUQ2OkFDRTgzOjM3ODQwODo0QThCRjk6NkE1MTkwODYiLCJ2aXNpdG9yX2lkIjoiNjIzOTA2ODk4MDAwNDM2MDMyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac89f0ccf358f18864a0469499b4b9a5890759692bfe00024d338a5db70f15a75d
hovercard-subject-tagpull_request:1259102283
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ros-visualization/python_qt_binding/123/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d5a87cacb6d4ad8d6a70d00ac731ecc313959435f1300feae39adb0a172a4e8/ros-visualization/python_qt_binding/pull/123
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d5a87cacb6d4ad8d6a70d00ac731ecc313959435f1300feae39adb0a172a4e8/ros-visualization/python_qt_binding/pull/123
og:image:altThere is an issue when building qt_gui_cpp with ninja, and it is traced back to python_qt_binding. This allows ninja to find the make executable and use it for this particular step. The alternativ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjcarroll
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/ros-visualization/python_qt_binding git https://github.com/ros-visualization/python_qt_binding.git
octolytics-dimension-user_id2328629
octolytics-dimension-user_loginros-visualization
octolytics-dimension-repository_id5860977
octolytics-dimension-repository_nworos-visualization/python_qt_binding
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id5860977
octolytics-dimension-repository_network_root_nworos-visualization/python_qt_binding
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ros-visualization/python_qt_binding/pull/123#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F123
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F123
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ros-visualization%2Fpython_qt_binding
Reloadhttps://github.com/ros-visualization/python_qt_binding/pull/123
Reloadhttps://github.com/ros-visualization/python_qt_binding/pull/123
Reloadhttps://github.com/ros-visualization/python_qt_binding/pull/123
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
ros-visualization https://github.com/ros-visualization
python_qt_bindinghttps://github.com/ros-visualization/python_qt_binding
Notifications https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding
Fork 63 https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding
Star 34 https://github.com/login?return_to=%2Fros-visualization%2Fpython_qt_binding
Code https://github.com/ros-visualization/python_qt_binding
Issues 7 https://github.com/ros-visualization/python_qt_binding/issues
Pull requests 4 https://github.com/ros-visualization/python_qt_binding/pulls
Actions https://github.com/ros-visualization/python_qt_binding/actions
Security and quality 0 https://github.com/ros-visualization/python_qt_binding/security
Insights https://github.com/ros-visualization/python_qt_binding/pulse
Code https://github.com/ros-visualization/python_qt_binding
Issues https://github.com/ros-visualization/python_qt_binding/issues
Pull requests https://github.com/ros-visualization/python_qt_binding/pulls
Actions https://github.com/ros-visualization/python_qt_binding/actions
Security and quality https://github.com/ros-visualization/python_qt_binding/security
Insights https://github.com/ros-visualization/python_qt_binding/pulse
mjcarrollhttps://github.com/mjcarroll
rollinghttps://github.com/ros-visualization/python_qt_binding/tree/rolling
mjcarroll/ninja_sip_generatorhttps://github.com/ros-visualization/python_qt_binding/tree/mjcarroll/ninja_sip_generator
Conversationhttps://github.com/ros-visualization/python_qt_binding/pull/123
Commits2 (2)https://github.com/ros-visualization/python_qt_binding/pull/123/commits
Checkshttps://github.com/ros-visualization/python_qt_binding/pull/123/checks
Files changedhttps://github.com/ros-visualization/python_qt_binding/pull/123/files
Fix to allow ninja to use make for generatorshttps://github.com/ros-visualization/python_qt_binding/pull/123#top
mjcarrollhttps://github.com/mjcarroll
rollinghttps://github.com/ros-visualization/python_qt_binding/tree/rolling
mjcarroll/ninja_sip_generatorhttps://github.com/ros-visualization/python_qt_binding/tree/mjcarroll/ninja_sip_generator
https://github.com/mjcarroll
mjcarrollhttps://github.com/mjcarroll
Mar 1, 2023https://github.com/ros-visualization/python_qt_binding/pull/123#issue-1605283860
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
Fix to allow ninja to use make for generatorshttps://github.com/ros-visualization/python_qt_binding/pull/123/commits/93322c2908ee74802cf079d39e44c131be36d275
93322c2https://github.com/ros-visualization/python_qt_binding/pull/123/commits/93322c2908ee74802cf079d39e44c131be36d275
https://github.com/mjcarroll
mjcarrollhttps://github.com/mjcarroll
sloretzhttps://github.com/sloretz
code ownerhttps://github.com/ros-visualization/python_qt_binding/blob/0a7f68ec8cb219233c9a640ca8517af73510949d/CODEOWNERS#L2
March 1, 2023 16:26https://github.com/ros-visualization/python_qt_binding/pull/123#event-8640193973
https://github.com/clalancette
clalancettehttps://github.com/clalancette
Mar 2, 2023 https://github.com/ros-visualization/python_qt_binding/pull/123#pullrequestreview-1321960618
View reviewed changes https://github.com/ros-visualization/python_qt_binding/pull/123/files/93322c2908ee74802cf079d39e44c131be36d275
clalancettehttps://github.com/clalancette
https://github.com/ros-visualization/python_qt_binding/pull/123#pullrequestreview-1321960618
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
cmake/sip_helper.cmakehttps://github.com/ros-visualization/python_qt_binding/pull/123/files/93322c2908ee74802cf079d39e44c131be36d275#diff-837e40112175930a749c0e28fa5c79eeb17901c8eafab813a52b97eb58b03c63
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
https://github.com/mjcarroll
https://github.com/clalancette
Find make binary on all non-Windows platformshttps://github.com/ros-visualization/python_qt_binding/pull/123/commits/6bb4541252c6a62e81f714b786e0f7a78e360c40
6bb4541https://github.com/ros-visualization/python_qt_binding/pull/123/commits/6bb4541252c6a62e81f714b786e0f7a78e360c40
https://github.com/clalancette
clalancettehttps://github.com/clalancette
Mar 2, 2023 https://github.com/ros-visualization/python_qt_binding/pull/123#pullrequestreview-1322043094
View reviewed changes https://github.com/ros-visualization/python_qt_binding/pull/123/files/6bb4541252c6a62e81f714b786e0f7a78e360c40
clalancettehttps://github.com/clalancette
https://github.com/ros-visualization/python_qt_binding/pull/123#pullrequestreview-1322043094
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
https://github.com/mjcarroll
mjcarrollhttps://github.com/mjcarroll
Mar 2, 2023https://github.com/ros-visualization/python_qt_binding/pull/123#issuecomment-1452576947
http://ci.ros2.org/job/ci_linux/18159/
http://ci.ros2.org/job/ci_linux-aarch64/12698/
http://ci.ros2.org/job/ci_windows/18819/
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
https://github.com/mjcarroll
mjcarrollhttps://github.com/mjcarroll
ade88c5https://github.com/ros-visualization/python_qt_binding/commit/ade88c56e27bcb74732e8bd8475fbda00d722355
Mar 3, 2023https://github.com/ros-visualization/python_qt_binding/pull/123#event-8660440762
https://github.com/mjcarroll
mjcarrollhttps://github.com/mjcarroll
March 3, 2023 14:40https://github.com/ros-visualization/python_qt_binding/pull/123#event-8660441350
yashihttps://github.com/yashi
Sep 29, 2023 https://github.com/ros-visualization/python_qt_binding/pull/123#ref-commit-566979a
https://github.com/mjcarroll
https://github.com/clalancette
https://github.com/yashi
Fix to allow ninja to use make for generators (https://github.com/yashi/python_qt_binding/commit/566979a3c223fa134f6cdfe673f667159522684a
ros-visualization#123https://github.com/ros-visualization/python_qt_binding/pull/123
)https://github.com/yashi/python_qt_binding/commit/566979a3c223fa134f6cdfe673f667159522684a
566979ahttps://github.com/yashi/python_qt_binding/commit/566979a3c223fa134f6cdfe673f667159522684a
ade88c5https://github.com/yashi/python_qt_binding/commit/ade88c56e27bcb74732e8bd8475fbda00d722355
clalancettehttps://github.com/clalancette
Oct 17, 2023 https://github.com/ros-visualization/python_qt_binding/pull/123#ref-commit-2cc0552
https://github.com/yashi
https://github.com/mjcarroll
https://github.com/clalancette
Fix to allow ninja to use make for generators (https://github.com/ros-visualization/python_qt_binding/commit/2cc0552fe3be8861e889150725f39ca915fe59e4
#123https://github.com/ros-visualization/python_qt_binding/pull/123
) (https://github.com/ros-visualization/python_qt_binding/commit/2cc0552fe3be8861e889150725f39ca915fe59e4
#128https://github.com/ros-visualization/python_qt_binding/pull/128
)https://github.com/ros-visualization/python_qt_binding/commit/2cc0552fe3be8861e889150725f39ca915fe59e4
2cc0552https://github.com/ros-visualization/python_qt_binding/commit/2cc0552fe3be8861e889150725f39ca915fe59e4
ade88c5https://github.com/ros-visualization/python_qt_binding/commit/ade88c56e27bcb74732e8bd8475fbda00d722355
https://github.com/peci1
peci1https://github.com/peci1
May 10, 2024https://github.com/ros-visualization/python_qt_binding/pull/123#issuecomment-2104310355
#111 (comment)https://github.com/ros-visualization/python_qt_binding/issues/111#issuecomment-2104306840
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
jprestwohttps://github.com/jprestwo
Feb 17, 2026 https://github.com/ros-visualization/python_qt_binding/pull/123#ref-commit-0af82f6
https://github.com/mjcarroll
https://github.com/clalancette
https://github.com/jprestwo
Fix to allow ninja to use make for generators (https://github.com/locusrobotics/python_qt_binding/commit/0af82f636fd39c838327d64535622fc27d58b74f
ros-visualization#123https://github.com/ros-visualization/python_qt_binding/pull/123
)https://github.com/locusrobotics/python_qt_binding/commit/0af82f636fd39c838327d64535622fc27d58b74f
0af82f6https://github.com/locusrobotics/python_qt_binding/commit/0af82f636fd39c838327d64535622fc27d58b74f
https://github.co/hiddenchars
https://github.com/ros-visualization/python_qt_binding/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros-visualization%2Fpython_qt_binding%2Fpull%2F123
https://github.com/clalancette
clalancette https://github.com/clalancette
https://github.com/ros-visualization/python_qt_binding/pull/123/files/6bb4541252c6a62e81f714b786e0f7a78e360c40
https://github.com/sloretz
sloretz https://github.com/sloretz
Please reload this pagehttps://github.com/ros-visualization/python_qt_binding/pull/123
https://github.com/mjcarroll
https://github.com/peci1
https://github.com/clalancette
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.