| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2da3a5b1-d681-e64e-685d-b1928fdef1cf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9048:33D2D8:1E72405:2BD6700:6A4CED57 |
| html-safe-nonce | 87db21a171372fa0c0b26ab83ce0cdd9208693859b27f7868b7c7982bee6a656 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQ4OjMzRDJEODoxRTcyNDA1OjJCRDY3MDA6NkE0Q0VENTciLCJ2aXNpdG9yX2lkIjoiNzE3ODUzOTQ4NzY5NzEwNDIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ff89b734d07be78bbbe941bb9b1f99106fd51d36191562ba2560c134b1df0689 |
| hovercard-subject-tag | pull_request:740541433 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rootstrap/android-base/49/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6d5834bb902059342384dc9affef0c1c98a47a216e4673258ea079e32a736214/rootstrap/android-base/pull/49 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6d5834bb902059342384dc9affef0c1c98a47a216e4673258ea079e32a736214/rootstrap/android-base/pull/49 |
| og:image:alt | Add Koin instead of Hilt as DI as an alternative for this base project
There are some pros and cons about it, at least that I can notice, such as:
PROS
We don´t have to use annotations, since Koin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | santi-andracchi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8 |
| turbo-cache-control | no-cache |
| go-import | github.com/rootstrap/android-base git https://github.com/rootstrap/android-base.git |
| octolytics-dimension-user_id | 13138290 |
| octolytics-dimension-user_login | rootstrap |
| octolytics-dimension-repository_id | 184807903 |
| octolytics-dimension-repository_nwo | rootstrap/android-base |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 184807903 |
| octolytics-dimension-repository_network_root_nwo | rootstrap/android-base |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | efec6750a5afcaeaf5dfcf629f404cf98c8371e3 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/rootstrap/android-base/pull/49#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frootstrap%2Fandroid-base%2Fpull%2F49 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frootstrap%2Fandroid-base%2Fpull%2F49 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rootstrap%2Fandroid-base |
| Reload | https://github.com/rootstrap/android-base/pull/49 |
| Reload | https://github.com/rootstrap/android-base/pull/49 |
| Reload | https://github.com/rootstrap/android-base/pull/49 |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
|
rootstrap
| https://github.com/rootstrap |
| android-base | https://github.com/rootstrap/android-base |
|
Notifications
| https://github.com/login?return_to=%2Frootstrap%2Fandroid-base |
|
Fork
6
| https://github.com/login?return_to=%2Frootstrap%2Fandroid-base |
|
Star
42
| https://github.com/login?return_to=%2Frootstrap%2Fandroid-base |
|
Code
| https://github.com/rootstrap/android-base |
|
Issues
11
| https://github.com/rootstrap/android-base/issues |
|
Pull requests
2
| https://github.com/rootstrap/android-base/pulls |
|
Actions
| https://github.com/rootstrap/android-base/actions |
|
Projects
| https://github.com/rootstrap/android-base/projects |
|
Security and quality
0
| https://github.com/rootstrap/android-base/security |
|
Insights
| https://github.com/rootstrap/android-base/pulse |
|
Code
| https://github.com/rootstrap/android-base |
|
Issues
| https://github.com/rootstrap/android-base/issues |
|
Pull requests
| https://github.com/rootstrap/android-base/pulls |
|
Actions
| https://github.com/rootstrap/android-base/actions |
|
Projects
| https://github.com/rootstrap/android-base/projects |
|
Security and quality
| https://github.com/rootstrap/android-base/security |
|
Insights
| https://github.com/rootstrap/android-base/pulse |
| santi-andracchi | https://github.com/santi-andracchi |
| master | https://github.com/rootstrap/android-base/tree/master |
| ft/add-koin | https://github.com/rootstrap/android-base/tree/ft/add-koin |
| Conversation | https://github.com/rootstrap/android-base/pull/49 |
| Commits2 (2) | https://github.com/rootstrap/android-base/pull/49/commits |
| Checks | https://github.com/rootstrap/android-base/pull/49/checks |
| Files changed | https://github.com/rootstrap/android-base/pull/49/files |
| Add Koin instead of dagger-hilt as DI | https://github.com/rootstrap/android-base/pull/49#top |
| santi-andracchi | https://github.com/santi-andracchi |
| master | https://github.com/rootstrap/android-base/tree/master |
| ft/add-koin | https://github.com/rootstrap/android-base/tree/ft/add-koin |
|
| https://github.com/santi-andracchi |
| santi-andracchi | https://github.com/santi-andracchi |
| Sep 22, 2021 | https://github.com/rootstrap/android-base/pull/49#issue-1004385473 |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
| Dagger-Hilt & Koin under the hood | https://proandroiddev.com/how-dagger-hilt-and-koin-differ-under-the-hood-c3be1a2959d7 |
| Koin Vs Dagger-Hilt | https://medium.com/gradeup/dependency-injection-dagger-hilt-vs-koin-ab2f7f85e6c6 |
| Mockk | https://mockk.io/ |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
| September 20, 2021 18:52 | https://github.com/rootstrap/android-base/pull/49#commits-pushed-c6fc863 |
| Add koin as DI instead of dagger-hilt | https://github.com/rootstrap/android-base/pull/49/commits/c6fc8630f3bf53e52cdc490334c1f74fcf8307f4 |
| c6fc863 | https://github.com/rootstrap/android-base/pull/49/commits/c6fc8630f3bf53e52cdc490334c1f74fcf8307f4 |
| Use mockk for testing | https://github.com/rootstrap/android-base/pull/49/commits/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
| e7555ec | https://github.com/rootstrap/android-base/pull/49/commits/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
| https://github.com/santi-andracchi |
| santi-andracchi | https://github.com/santi-andracchi |
| Sep 22, 2021 | https://github.com/rootstrap/android-base/pull/49#event-5343752963 |
| https://github.com/santi-andracchi |
| santi-andracchi | https://github.com/santi-andracchi |
| amaury901130 | https://github.com/amaury901130 |
| jjszolno | https://github.com/jjszolno |
| mato2593 | https://github.com/mato2593 |
| ximenaperez | https://github.com/ximenaperez |
| code owners | https://github.com/rootstrap/android-base/blob/f0b6e77ea0dae93390847debaa0e9dcf065a8b46/CODEOWNERS#L4 |
| September 22, 2021 14:44 | https://github.com/rootstrap/android-base/pull/49#event-5343753002 |
| https://github.com/amaury901130 |
| amaury901130 | https://github.com/amaury901130 |
| agustinkoll-rootstrap | https://github.com/agustinkoll-rootstrap |
| lmiotti | https://github.com/lmiotti |
| marcossalto | https://github.com/marcossalto |
| sfiamene | https://github.com/sfiamene |
| September 22, 2021 16:07 | https://github.com/rootstrap/android-base/pull/49#event-5344319731 |
| https://github.com/amaury901130 |
| amaury901130 | https://github.com/amaury901130 |
|
Feb 16, 2022
| https://github.com/rootstrap/android-base/pull/49#ref-pullrequest-1122223816 |
|
Clean architecture koin
#58
| https://github.com/rootstrap/android-base/pull/58 |
| https://github.com/sfiamene |
| sfiamene | https://github.com/sfiamene |
|
Feb 17, 2022
| https://github.com/rootstrap/android-base/pull/49#pullrequestreview-886383546 |
|
View reviewed changes
| https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
| .idea/gradle.xml | https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9#diff-952b752681ded498853ce6363aa309aac9e6bd15fe12a907be0b8d2142d1fa21 |
| sfiamene | https://github.com/sfiamene |
| Feb 17, 2022 | https://github.com/rootstrap/android-base/pull/49#discussion_r809348815 |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
| https://github.com/sfiamene |
| sfiamene | https://github.com/sfiamene |
|
Feb 17, 2022
| https://github.com/rootstrap/android-base/pull/49#pullrequestreview-886384602 |
|
View reviewed changes
| https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
| app/src/androidTest/AndroidManifest.xml | https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9#diff-804ea906a6b3190e0645d648a36ac7df82fa7f672ca865b7661263e4b13131b9 |
| sfiamene | https://github.com/sfiamene |
| Feb 17, 2022 | https://github.com/rootstrap/android-base/pull/49#discussion_r809349555 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
| https://github.com/sfiamene |
| sfiamene | https://github.com/sfiamene |
|
Feb 17, 2022
| https://github.com/rootstrap/android-base/pull/49#pullrequestreview-886385784 |
|
View reviewed changes
| https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
| app/src/main/java/com/rootstrap/android/di/AppModule.kt | https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9#diff-2af303fbeef9b3f68fe19f5486cc4a288803f4d561a1543aac87c7a37fe351d6 |
| sfiamene | https://github.com/sfiamene |
| Feb 17, 2022 | https://github.com/rootstrap/android-base/pull/49#discussion_r809350391 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
| https://github.com/sfiamene |
| sfiamene | https://github.com/sfiamene |
|
Feb 17, 2022
| https://github.com/rootstrap/android-base/pull/49#pullrequestreview-886386736 |
|
View reviewed changes
| https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
| https://github.com/amaury901130 |
| amaury901130 | https://github.com/amaury901130 |
|
hold
| https://github.com/rootstrap/android-base/issues?q=state%3Aopen%20label%3Ahold |
| Feb 18, 2022 | https://github.com/rootstrap/android-base/pull/49#event-6098685081 |
| https://github.co/hiddenchars |
| https://github.com/rootstrap/android-base/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frootstrap%2Fandroid-base%2Fpull%2F49 |
|
| https://github.com/sfiamene |
|
sfiamene
| https://github.com/sfiamene |
|
| https://github.com/rootstrap/android-base/pull/49/files/e7555ec75c1933b2117a4d0c5d142d0e18a07af9 |
|
| https://github.com/amaury901130 |
|
amaury901130
| https://github.com/amaury901130 |
|
| https://github.com/jjszolno |
|
jjszolno
| https://github.com/jjszolno |
|
| https://github.com/mato2593 |
|
mato2593
| https://github.com/mato2593 |
|
| https://github.com/ximenaperez |
|
ximenaperez
| https://github.com/ximenaperez |
|
| https://github.com/lmiotti |
|
lmiotti
| https://github.com/lmiotti |
|
| https://github.com/agustinkoll-rootstrap |
|
agustinkoll-rootstrap
| https://github.com/agustinkoll-rootstrap |
|
| https://github.com/marcossalto |
|
marcossalto
| https://github.com/marcossalto |
|
| https://github.com/santi-andracchi |
|
santi-andracchi
| https://github.com/santi-andracchi |
|
hold
| https://github.com/rootstrap/android-base/issues?q=state%3Aopen%20label%3Ahold |
| Please reload this page | https://github.com/rootstrap/android-base/pull/49 |
|
| https://github.com/santi-andracchi |
|
| https://github.com/sfiamene |
|
| https://github.com/amaury901130 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |