| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:838dc074-0ad5-074b-fb37-9cad859eb0c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A234:39B4C3:FA5B1:1614AB:696A15F7 |
| html-safe-nonce | 7effe9c1a11b8423997a6b4c985a9bcda62772ebd89f66706bf98f5397486d4a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjM0OjM5QjRDMzpGQTVCMToxNjE0QUI6Njk2QTE1RjciLCJ2aXNpdG9yX2lkIjoiNzM0MjE2MjgzODEyMzMyMDgyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | afea2933ee6e1b6ea244494473dcd3c8dfbc4f8c307886bc1f05aecd18ec11b5 |
| hovercard-subject-tag | pull_request:315176275 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/rethinkdb/rethinkdb-python/140/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e48e57d83789b0a26142791da20d753db7c409e9440d8e125ed3c6ac1f935a34/rethinkdb/rethinkdb-python/pull/140 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e48e57d83789b0a26142791da20d753db7c409e9440d8e125ed3c6ac1f935a34/rethinkdb/rethinkdb-python/pull/140 |
| og:image:alt | Reason for the change
#124
Description
Ensure we can use subdomains in the hostname of SSL hostname matching, so we can connect to RethinkDB using wildcat SSL Certs.
Checklist
Unit tests created/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabor-boros |
| hostname | github.com |
| expected-hostname | github.com |
| None | 34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923 |
| turbo-cache-control | no-preview |
| go-import | github.com/rethinkdb/rethinkdb-python git https://github.com/rethinkdb/rethinkdb-python.git |
| octolytics-dimension-user_id | 1229647 |
| octolytics-dimension-user_login | rethinkdb |
| octolytics-dimension-repository_id | 134593743 |
| octolytics-dimension-repository_nwo | rethinkdb/rethinkdb-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 134593743 |
| octolytics-dimension-repository_network_root_nwo | rethinkdb/rethinkdb-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e8bd37502700f365b18a4d39acf7cb7947e11b1a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/rethinkdb/rethinkdb-python/pull/140#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frethinkdb%2Frethinkdb-python%2Fpull%2F140 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frethinkdb%2Frethinkdb-python%2Fpull%2F140 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=rethinkdb%2Frethinkdb-python |
| Reload | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
| Reload | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
| Reload | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
|
rethinkdb
| https://github.com/rethinkdb |
| rethinkdb-python | https://github.com/rethinkdb/rethinkdb-python |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
|
Notifications
| https://github.com/login?return_to=%2Frethinkdb%2Frethinkdb-python |
|
Fork
35
| https://github.com/login?return_to=%2Frethinkdb%2Frethinkdb-python |
|
Star
65
| https://github.com/login?return_to=%2Frethinkdb%2Frethinkdb-python |
|
Code
| https://github.com/rethinkdb/rethinkdb-python |
|
Issues
34
| https://github.com/rethinkdb/rethinkdb-python/issues |
|
Pull requests
4
| https://github.com/rethinkdb/rethinkdb-python/pulls |
|
Actions
| https://github.com/rethinkdb/rethinkdb-python/actions |
|
Projects
0
| https://github.com/rethinkdb/rethinkdb-python/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/rethinkdb/rethinkdb-python/security |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
|
Insights
| https://github.com/rethinkdb/rethinkdb-python/pulse |
|
Code
| https://github.com/rethinkdb/rethinkdb-python |
|
Issues
| https://github.com/rethinkdb/rethinkdb-python/issues |
|
Pull requests
| https://github.com/rethinkdb/rethinkdb-python/pulls |
|
Actions
| https://github.com/rethinkdb/rethinkdb-python/actions |
|
Projects
| https://github.com/rethinkdb/rethinkdb-python/projects |
|
Security
| https://github.com/rethinkdb/rethinkdb-python/security |
|
Insights
| https://github.com/rethinkdb/rethinkdb-python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Frethinkdb%2Frethinkdb-python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Frethinkdb%2Frethinkdb-python%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/rethinkdb/rethinkdb-python/pull/140#issue-comment-box |
| gabor-boros | https://github.com/gabor-boros |
| master | https://github.com/rethinkdb/rethinkdb-python/tree/master |
| feature/wildcard-certs-hostname | https://github.com/rethinkdb/rethinkdb-python/tree/feature/wildcard-certs-hostname |
|
Feature/wildcard certs hostname
| https://github.com/rethinkdb/rethinkdb-python/pull/140#top |
| gabor-boros | https://github.com/gabor-boros |
| master | https://github.com/rethinkdb/rethinkdb-python/tree/master |
| feature/wildcard-certs-hostname | https://github.com/rethinkdb/rethinkdb-python/tree/feature/wildcard-certs-hostname |
|
Conversation
2
| https://github.com/rethinkdb/rethinkdb-python/pull/140 |
|
Commits
6
| https://github.com/rethinkdb/rethinkdb-python/pull/140/commits |
|
Checks
0
| https://github.com/rethinkdb/rethinkdb-python/pull/140/checks |
|
Files changed
| https://github.com/rethinkdb/rethinkdb-python/pull/140/files |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
| https://github.co/hiddenchars |
| https://github.com/rethinkdb/rethinkdb-python/pull/{{ revealButtonHref }} |
|
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
| Sep 7, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#issue-490605914 |
| #124 | https://github.com/rethinkdb/rethinkdb-python/issues/124 |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
| gabor-boros | https://github.com/gabor-boros |
| September 7, 2019 09:46 | https://github.com/rethinkdb/rethinkdb-python/pull/140#commits-pushed-4d51074 |
|
| https://github.com/gabor-boros |
| Add helper to get the hostname for ssl matching | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/4d510742c8328a423d67ddec37bae957d972a63b |
| 4d51074 | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/4d510742c8328a423d67ddec37bae957d972a63b |
|
| https://github.com/gabor-boros |
| Extend net and net_gevent to use the new helper | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/0c7608706a427fceb8fec30d27af8f716fc75709 |
| 0c76087 | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/0c7608706a427fceb8fec30d27af8f716fc75709 |
|
| https://github.com/gabor-boros |
| New line at the end of helpers | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/6e14dc76e97fa3b1aab0137b35fb499e54dc4603 |
| 6e14dc7 | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/6e14dc76e97fa3b1aab0137b35fb499e54dc4603 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
| Sep 7, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#event-2616068781 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
|
enhancement
| https://github.com/rethinkdb/rethinkdb-python/issues?q=state%3Aopen%20label%3Aenhancement |
| Sep 7, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#event-2616068869 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
| Release 2.4.2 | https://github.com/rethinkdb/rethinkdb-python/milestone/2 |
| Release 2.4.4 | https://github.com/rethinkdb/rethinkdb-python/milestone/3 |
| Sep 7, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#event-2616068909 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
|
Sep 7, 2019
| https://github.com/rethinkdb/rethinkdb-python/pull/140#ref-issue-445269910 |
|
ssl wildcat is not support
#124
| https://github.com/rethinkdb/rethinkdb-python/issues/124 |
|
| https://github.com/gabor-boros |
| Fix codacy issues | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/af04a2cdbace8326adc843f8d81c457e10557363 |
| af04a2c | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/af04a2cdbace8326adc843f8d81c457e10557363 |
| https://github.com/rethinkdb |
| rethinkdb | https://github.com/rethinkdb |
| Sep 7, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#event-2616072269 |
| gabor-boros | https://github.com/gabor-boros |
| September 13, 2019 10:18 | https://github.com/rethinkdb/rethinkdb-python/pull/140#commits-pushed-aa62ff2 |
|
| https://github.com/gabor-boros |
| Removing the regexp. It can not handle localhost and special TLDs | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/aa62ff26614a2a9a0788c0ad64ce8420a77d1d02 |
| aa62ff2 | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/aa62ff26614a2a9a0788c0ad64ce8420a77d1d02 |
|
| https://github.com/gabor-boros |
| Remove unused imports | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/b5dfb9504483b5e26ca6da03c97a948ed6ecea54 |
| b5dfb95 | https://github.com/rethinkdb/rethinkdb-python/pull/140/commits/b5dfb9504483b5e26ca6da03c97a948ed6ecea54 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
| 95e96de | https://github.com/rethinkdb/rethinkdb-python/commit/95e96de9c940e6d97c3f368cff01c3f884695bf2 |
| Sep 13, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#event-2631580923 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
| September 13, 2019 08:30 | https://github.com/rethinkdb/rethinkdb-python/pull/140#event-2631581101 |
| https://github.com/srh |
| srh | https://github.com/srh |
| Oct 27, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#issuecomment-546748000 |
| https://docs.python.org/3/library/ssl.html | https://docs.python.org/3/library/ssl.html |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
| Oct 28, 2019 | https://github.com/rethinkdb/rethinkdb-python/pull/140#issuecomment-546845013 |
| @bacnv | https://github.com/bacnv |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
| https://github.com/gabor-boros |
| gabor-boros | https://github.com/gabor-boros |
|
Nov 2, 2019
| https://github.com/rethinkdb/rethinkdb-python/pull/140#ref-pullrequest-516537053 |
|
Revert "Feature/wildcard certs hostname"
#150
| https://github.com/rethinkdb/rethinkdb-python/pull/150 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Frethinkdb%2Frethinkdb-python%2Fpull%2F140 |
|
| https://github.com/gabor-boros |
|
gabor-boros
| https://github.com/gabor-boros |
|
enhancement
| https://github.com/rethinkdb/rethinkdb-python/issues?q=state%3Aopen%20label%3Aenhancement |
|
Release 2.4.4
| https://github.com/rethinkdb/rethinkdb-python/milestone/3 |
| Please reload this page | https://github.com/rethinkdb/rethinkdb-python/pull/140 |
|
| https://github.com/gabor-boros |
|
| https://github.com/srh |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |