| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:70b36922-0c13-ed17-0f69-ad53f7f1c0a2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA50:15E5F9:2B94A0B:3BB1AAB:6B005BB8 |
| html-safe-nonce | d0ada28913224a9f3b7c488daf44f44e1a97b896fa97028f29c8f33711fe51d4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTUwOjE1RTVGOToyQjk0QTBCOjNCQjFBQUI6NkIwMDVCQjgiLCJ2aXNpdG9yX2lkIjoiNjk1MzQxNDY4ODA4MDE1NzYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3450722c8ee78382f931fbfdacf3f3100074c98171679c391408127d2ae931a8 |
| hovercard-subject-tag | pull_request:821018250 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/reactphp/socket/283/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e289b9bd847d4b4bef60f9a4f4fb4eec3cbe83d74fd08459cf9cfb6dd056c192/reactphp/socket/pull/283 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e289b9bd847d4b4bef60f9a4f4fb4eec3cbe83d74fd08459cf9cfb6dd056c192/reactphp/socket/pull/283 |
| og:image:alt | I noticed that this testsuite still uses the old eventloop implementation. After I changed everything to the new default loop some tests got stuck in execution, because other tests didn't close... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SimonFrings |
| hostname | github.com |
| expected-hostname | github.com |
| None | 29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73 |
| turbo-cache-control | no-cache |
| go-import | github.com/reactphp/socket git https://github.com/reactphp/socket.git |
| octolytics-dimension-user_id | 1696866 |
| octolytics-dimension-user_login | reactphp |
| octolytics-dimension-repository_id | 4287591 |
| octolytics-dimension-repository_nwo | reactphp/socket |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 4287591 |
| octolytics-dimension-repository_network_root_nwo | reactphp/socket |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eacd927ba6112e3b01ba99c762bd699a4a4f5df7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/reactphp/socket/pull/283#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F283 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F283 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=reactphp%2Fsocket |
| Reload | https://github.com/reactphp/socket/pull/283 |
| Reload | https://github.com/reactphp/socket/pull/283 |
| Reload | https://github.com/reactphp/socket/pull/283 |
| reactphp | https://github.com/reactphp |
| socket | https://github.com/reactphp/socket |
| Code | https://github.com/reactphp/socket |
| Issues7 (7) | https://github.com/reactphp/socket/issues |
| Pull requests9 (9) | https://github.com/reactphp/socket/pulls |
| Actions | https://github.com/reactphp/socket/actions |
| Security and quality | https://github.com/reactphp/socket/security |
| Insights | https://github.com/reactphp/socket/insights |
| https://github.com/reactphp/socket |
| WyriHaximus | https://github.com/WyriHaximus |
| reactphp:master | https://github.com/reactphp/socket/tree/master |
| SimonFrings:eventloop | https://github.com/SimonFrings/socket/tree/eventloop |
| Conversation | https://github.com/reactphp/socket/pull/283 |
| Commits3 (3) | https://github.com/reactphp/socket/pull/283/commits |
| Checks | https://github.com/reactphp/socket/pull/283/checks |
| Files changed | https://github.com/reactphp/socket/pull/283/files |
| Use default loop in testsuite and close server and connection leftovers | https://github.com/reactphp/socket/pull/283#top |
| WyriHaximus | https://github.com/WyriHaximus |
| reactphp:master | https://github.com/reactphp/socket/tree/master |
| SimonFrings:eventloop | https://github.com/SimonFrings/socket/tree/eventloop |
|
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
| Jan 13, 2022 | https://github.com/reactphp/socket/pull/283#issue-1101834865 |
| Please reload this page | https://github.com/reactphp/socket/pull/283 |
| #260 | https://github.com/reactphp/socket/pull/260 |
| clue/reactphp-block#60 | https://github.com/clue/reactphp-block/pull/60 |
| Please reload this page | https://github.com/reactphp/socket/pull/283 |
| SimonFrings | https://github.com/SimonFrings |
| January 13, 2022 11:46 | https://github.com/reactphp/socket/pull/283#commits-pushed-d846ea9 |
|
| https://github.com/SimonFrings |
| Clean up event-loop leftovers in test classes | https://github.com/reactphp/socket/pull/283/commits/d846ea9380f08c640a719c50af223ef2569eeb9d |
| d846ea9 | https://github.com/reactphp/socket/pull/283/commits/d846ea9380f08c640a719c50af223ef2569eeb9d |
|
| https://github.com/SimonFrings |
| Close open servers and connections at end of tests | https://github.com/reactphp/socket/pull/283/commits/82acd6cf2ab996f68f808858cc0530fca2683a5a |
| 82acd6c | https://github.com/reactphp/socket/pull/283/commits/82acd6cf2ab996f68f808858cc0530fca2683a5a |
|
| https://github.com/SimonFrings |
| Use reactphp-block v1.5.0 and remove loop where possible | https://github.com/reactphp/socket/pull/283/commits/4f2497bbf69ba576533aaeba414732f8ab27f26f |
| 4f2497b | https://github.com/reactphp/socket/pull/283/commits/4f2497bbf69ba576533aaeba414732f8ab27f26f |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Jan 13, 2022
| https://github.com/reactphp/socket/pull/283#pullrequestreview-851787577 |
|
View reviewed changes
| https://github.com/reactphp/socket/pull/283/files/4f2497bbf69ba576533aaeba414732f8ab27f26f |
| clue | https://github.com/clue |
| https://github.com/reactphp/socket/pull/283#pullrequestreview-851787577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @SimonFrings | https://github.com/SimonFrings |
| Please reload this page | https://github.com/reactphp/socket/pull/283 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
maintenance
| https://github.com/reactphp/socket/issues?q=state%3Aopen%20label%3Amaintenance |
| Jan 13, 2022 | https://github.com/reactphp/socket/pull/283#event-5887989463 |
| https://github.com/clue |
| clue | https://github.com/clue |
| v1.11.0 | https://github.com/reactphp/socket/milestone/38 |
| Jan 13, 2022 | https://github.com/reactphp/socket/pull/283#event-5887989707 |
| https://github.com/clue |
| clue | https://github.com/clue |
| WyriHaximus | https://github.com/WyriHaximus |
| January 13, 2022 14:30 | https://github.com/reactphp/socket/pull/283#event-5887990269 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
|
Jan 13, 2022
| https://github.com/reactphp/socket/pull/283#pullrequestreview-852243096 |
|
View reviewed changes
| https://github.com/reactphp/socket/pull/283/files/4f2497bbf69ba576533aaeba414732f8ab27f26f |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
| 7b6772a | https://github.com/reactphp/socket/commit/7b6772ab2ba98cd7578a1c87f529dbb71bc33b93 |
| Jan 13, 2022 | https://github.com/reactphp/socket/pull/283#event-5890466257 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Jan 23, 2022
| https://github.com/reactphp/socket/pull/283#ref-pullrequest-1111834591 |
|
Update test suite to use default loop
reactphp/http#438
| https://github.com/reactphp/http/pull/438 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Mar 22, 2022
| https://github.com/reactphp/socket/pull/283#ref-pullrequest-1176578953 |
|
Fix optional test for ENETUNREACH error condition
#288
| https://github.com/reactphp/socket/pull/288 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
|
May 6, 2022
| https://github.com/reactphp/socket/pull/283#ref-issue-1225022087 |
|
Any way to "reset" the loop?
reactphp/event-loop#252
| https://github.com/reactphp/event-loop/issues/252 |
|
Update test suite to use default loop
reactphp/dns#204
| https://github.com/reactphp/dns/pull/204 |
|
Update test suite to use new reactphp/async package instead of clue/reactphp-block
#296
| https://github.com/reactphp/socket/pull/296 |
| https://github.com/SimonFrings |
| SimonFrings | https://github.com/SimonFrings |
|
Oct 11, 2022
| https://github.com/reactphp/socket/pull/283#ref-pullrequest-1393116361 |
|
Use reactphp/async instead of clue/reactphp-block
clue/reactphp-docker#77
| https://github.com/clue/reactphp-docker/pull/77 |
| https://github.com/dinooo13 |
| dinooo13 | https://github.com/dinooo13 |
|
Oct 12, 2022
| https://github.com/reactphp/socket/pull/283#ref-pullrequest-1406496116 |
|
Update tests to close any server sockets
clue/reactphp-docker#79
| https://github.com/clue/reactphp-docker/pull/79 |
| https://github.com/dinooo13 |
| dinooo13 | https://github.com/dinooo13 |
|
Oct 21, 2022
| https://github.com/reactphp/socket/pull/283#ref-pullrequest-1418923482 |
|
Update tests to close any server sockets
clue/reactphp-socks#111
| https://github.com/clue/reactphp-socks/pull/111 |
| https://github.co/hiddenchars |
| https://github.com/reactphp/socket/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F283 |
|
| https://github.com/WyriHaximus |
|
WyriHaximus
| https://github.com/WyriHaximus |
|
| https://github.com/reactphp/socket/pull/283/files/4f2497bbf69ba576533aaeba414732f8ab27f26f |
|
| https://github.com/clue |
|
clue
| https://github.com/clue |
|
| https://github.com/reactphp/socket/pull/283/files/4f2497bbf69ba576533aaeba414732f8ab27f26f |
| Please reload this page | https://github.com/reactphp/socket/pull/283 |
|
maintenance
| https://github.com/reactphp/socket/issues?q=state%3Aopen%20label%3Amaintenance |
|
v1.11.0
| https://github.com/reactphp/socket/milestone/38 |
| Please reload this page | https://github.com/reactphp/socket/pull/283 |
|
| https://github.com/SimonFrings |
|
| https://github.com/WyriHaximus |
|
| https://github.com/clue |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |