| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6f2adaaa-09cf-3cf5-458d-f13c75ff82c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6E6:49948:B30B5:F305D:6B00624C |
| html-safe-nonce | 40d62037eabfc86964c398b70ef85c3b80a78330b675941d5cef68456f0bd700 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkU2OjQ5OTQ4OkIzMEI1OkYzMDVEOjZCMDA2MjRDIiwidmlzaXRvcl9pZCI6IjU2NTE0MjY5OTIyOTg2NDUyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 248445d2b1f20d59a2e8149f31dba8b1960d75f163bd55266391f7489cc3497a |
| hovercard-subject-tag | pull_request:386672861 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/reactphp/socket/225/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/781bc1d8734d582559ad77eb243d4ae828820ada85b00612a77bc67c34cca833/reactphp/socket/pull/225 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/781bc1d8734d582559ad77eb243d4ae828820ada85b00612a77bc67c34cca833/reactphp/socket/pull/225 |
| og:image:alt | This changeset fixes a leftover timer reference when cancelling the happy eyeballs connection attempt. Additionally, this increases test coverage to 100% and significantly improves test times (27s-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | clue |
| hostname | github.com |
| expected-hostname | github.com |
| None | 25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e |
| turbo-cache-control | no-cache |
| go-import | github.com/reactphp/socket git https://github.com/reactphp/socket.git |
| octolytics-dimension-user_id | 1696866 |
| octolytics-dimension-user_login | reactphp |
| octolytics-dimension-repository_id | 4287591 |
| octolytics-dimension-repository_nwo | reactphp/socket |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 4287591 |
| octolytics-dimension-repository_network_root_nwo | reactphp/socket |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4f5c239e31f1f680e6bbc419ff92d774da616ec |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/reactphp/socket/pull/225#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F225 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F225 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=reactphp%2Fsocket |
| Reload | https://github.com/reactphp/socket/pull/225 |
| Reload | https://github.com/reactphp/socket/pull/225 |
| Reload | https://github.com/reactphp/socket/pull/225 |
| reactphp | https://github.com/reactphp |
| socket | https://github.com/reactphp/socket |
| Code | https://github.com/reactphp/socket |
| Issues7 (7) | https://github.com/reactphp/socket/issues |
| Pull requests9 (9) | https://github.com/reactphp/socket/pulls |
| Actions | https://github.com/reactphp/socket/actions |
| Security and quality | https://github.com/reactphp/socket/security |
| Insights | https://github.com/reactphp/socket/insights |
| https://github.com/reactphp/socket |
| jsor | https://github.com/jsor |
| reactphp:master | https://github.com/reactphp/socket/tree/master |
| clue-labs:eyeball-cleanup | https://github.com/clue-labs/socket/tree/eyeball-cleanup |
| Conversation | https://github.com/reactphp/socket/pull/225 |
| Commits2 (2) | https://github.com/reactphp/socket/pull/225/commits |
| Checks | https://github.com/reactphp/socket/pull/225/checks |
| Files changed | https://github.com/reactphp/socket/pull/225/files |
| Fix cancelling happy eyeballs to stop timer, fix rejection reason and simplify timer logic | https://github.com/reactphp/socket/pull/225#top |
| jsor | https://github.com/jsor |
| reactphp:master | https://github.com/reactphp/socket/tree/master |
| clue-labs:eyeball-cleanup | https://github.com/clue-labs/socket/tree/eyeball-cleanup |
|
| https://github.com/clue |
| clue | https://github.com/clue |
| Mar 11, 2020 | https://github.com/reactphp/socket/pull/225#issue-579243592 |
| #224 | https://github.com/reactphp/socket/pull/224 |
| Please reload this page | https://github.com/reactphp/socket/pull/225 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
bug
| https://github.com/reactphp/socket/issues?q=state%3Aopen%20label%3Abug |
| Mar 11, 2020 | https://github.com/reactphp/socket/pull/225#event-3118672157 |
| https://github.com/clue |
| clue | https://github.com/clue |
| v1.4.0 | https://github.com/reactphp/socket/milestone/31 |
| Mar 11, 2020 | https://github.com/reactphp/socket/pull/225#event-3118672167 |
|
| https://github.com/clue |
| Fix cancelling happy eyeballs to stop timer and fix rejection reason | https://github.com/reactphp/socket/pull/225/commits/b400a57fd8718b6d891a232cbc2d62b8634dbb16 |
| b400a57 | https://github.com/reactphp/socket/pull/225/commits/b400a57fd8718b6d891a232cbc2d62b8634dbb16 |
| https://github.com/clue |
| clue | https://github.com/clue |
| force-pushed | https://github.com/reactphp/socket/compare/4e341a2358906bd68b5121d4a2c36bdabe6883e6..8092da0c9cf42c1e4abca9fbe50c770dd05c5132 |
| 4e341a2 | https://github.com/reactphp/socket/commit/4e341a2358906bd68b5121d4a2c36bdabe6883e6 |
| 8092da0 | https://github.com/reactphp/socket/commit/8092da0c9cf42c1e4abca9fbe50c770dd05c5132 |
|
Compare
| https://github.com/reactphp/socket/compare/4e341a2358906bd68b5121d4a2c36bdabe6883e6..8092da0c9cf42c1e4abca9fbe50c770dd05c5132 |
| March 11, 2020 13:01 | https://github.com/reactphp/socket/pull/225#event-3118693207 |
|
| https://github.com/clue |
| Fix resolution delay (50ms) and simplify related timer logic | https://github.com/reactphp/socket/pull/225/commits/511f85d7d8e791d7352e241435e3ff43d34af764 |
| 511f85d | https://github.com/reactphp/socket/pull/225/commits/511f85d7d8e791d7352e241435e3ff43d34af764 |
| https://github.com/clue |
| clue | https://github.com/clue |
| force-pushed | https://github.com/reactphp/socket/compare/8092da0c9cf42c1e4abca9fbe50c770dd05c5132..511f85d7d8e791d7352e241435e3ff43d34af764 |
| 8092da0 | https://github.com/reactphp/socket/commit/8092da0c9cf42c1e4abca9fbe50c770dd05c5132 |
| 511f85d | https://github.com/reactphp/socket/commit/511f85d7d8e791d7352e241435e3ff43d34af764 |
|
Compare
| https://github.com/reactphp/socket/compare/8092da0c9cf42c1e4abca9fbe50c770dd05c5132..511f85d7d8e791d7352e241435e3ff43d34af764 |
| March 11, 2020 13:58 | https://github.com/reactphp/socket/pull/225#event-3118919756 |
| https://github.com/clue |
| clue | https://github.com/clue |
| WyriHaximus | https://github.com/WyriHaximus |
| jsor | https://github.com/jsor |
| March 11, 2020 14:02 | https://github.com/reactphp/socket/pull/225#event-3118938443 |
| https://github.com/WyriHaximus |
| WyriHaximus | https://github.com/WyriHaximus |
|
Mar 11, 2020
| https://github.com/reactphp/socket/pull/225#pullrequestreview-372826919 |
|
View reviewed changes
| https://github.com/reactphp/socket/pull/225/files/511f85d7d8e791d7352e241435e3ff43d34af764 |
| https://github.com/jsor |
| jsor | https://github.com/jsor |
|
Mar 11, 2020
| https://github.com/reactphp/socket/pull/225#pullrequestreview-372999097 |
|
View reviewed changes
| https://github.com/reactphp/socket/pull/225/files/511f85d7d8e791d7352e241435e3ff43d34af764 |
| https://github.com/jsor |
| jsor | https://github.com/jsor |
| 4fbe726 | https://github.com/reactphp/socket/commit/4fbe726799db6902ebd3a80162cc5eb8d6bade9c |
| Mar 11, 2020 | https://github.com/reactphp/socket/pull/225#event-3119930918 |
| https://github.com/clue |
| clue | https://github.com/clue |
| March 11, 2020 18:26 | https://github.com/reactphp/socket/pull/225#event-3120017177 |
|
Improve error reporting when DNS lookup fails (happy eyeballs)
#230
| https://github.com/reactphp/socket/pull/230 |
|
Improve error reporting when TCP/IP connection fails (happy eyeballs)
#231
| https://github.com/reactphp/socket/pull/231 |
|
Immediately try next connection when one attempt fails and fix possible race conditions (happy eyeballs)
#232
| https://github.com/reactphp/socket/pull/232 |
|
Improve error reporting to include both IPv6 & IPv4 errors (happy eyeballs)
#233
| https://github.com/reactphp/socket/pull/233 |
| https://github.com/clue |
| clue | https://github.com/clue |
|
Dec 8, 2023
| https://github.com/reactphp/socket/pull/225#ref-pullrequest-2033428111 |
|
Fix cancelling happy eyeballs when IPv6 resolution is pending
#311
| https://github.com/reactphp/socket/pull/311 |
| https://github.co/hiddenchars |
| https://github.com/reactphp/socket/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Freactphp%2Fsocket%2Fpull%2F225 |
|
| https://github.com/jsor |
|
jsor
| https://github.com/jsor |
|
| https://github.com/reactphp/socket/pull/225/files/511f85d7d8e791d7352e241435e3ff43d34af764 |
|
| https://github.com/WyriHaximus |
|
WyriHaximus
| https://github.com/WyriHaximus |
|
| https://github.com/reactphp/socket/pull/225/files/511f85d7d8e791d7352e241435e3ff43d34af764 |
| Please reload this page | https://github.com/reactphp/socket/pull/225 |
|
bug
| https://github.com/reactphp/socket/issues?q=state%3Aopen%20label%3Abug |
|
v1.4.0
| https://github.com/reactphp/socket/milestone/31 |
| Please reload this page | https://github.com/reactphp/socket/pull/225 |
|
| https://github.com/clue |
|
| https://github.com/jsor |
|
| https://github.com/WyriHaximus |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |